drivers/net/hamradio/6pack.c: move a dereference below a NULL test
Subsystems (2)
PATCH 2/4 drivers/net/hamradio/6pack.c: move a dereference below a NULL test
From: Julia Lawall <[email protected]>
In each case, if the NULL test is necessary, then the dereference should be moved below the NULL test.
The semantic patch that makes this change is as follows:
(http://www.emn.fr/x-info/coccinelle/)
// <smpl>
@@
type T;
expression E;
identifier i,fld;
statement S;
@@
- T i = E->fld;
+ T i;
... when != E
when != i
if (E == NULL) S
+ i = E->fld;
// </smpl>
Signed-off-by Julia Lawall <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
---
drivers/net/hamradio/6pack.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/hamradio/6pack.c renamed from drivers/net/hamradio/6pack.c~drivers-net-hamradio-6packc-move-a-dereference-below-a-null-test +2 -1
@@ -717,11 +717,12 @@ static int sixpack_ioctl(struct tty_stru unsigned int cmd, unsigned long arg) {struct sixpack *sp =sp_get (tty); -struct net_device *dev = sp->dev; +struct net_device *dev;unsigned int tmp, err;if (!sp)return -ENXIO ; + dev = sp->dev;switch (cmd) {case SIOCGIFNAME :
_
Applied.