MAX3100 SPI UART driver
Subsystems (2)
PATCH RESEND 1/1 MAX3100 SPI UART driver
This patch adds support for the MAX3100 SPI UART. I am still waiting for a minor number from [email protected] so that may change.
Generated on 20081002 against v2.6.27-rc7
--- drivers/serial/Kconfig | 6 +- drivers/serial/Makefile | 1 + drivers/serial/max3100.c | 924 ++++++++++++++++++++++++++++++++++++++++ include/linux/serial_core.h | 3 + include/linux/serial_max3100.h | 53 +++ 5 files changed, 986 insertions(+), 1 deletions(-)
drivers/serial/Kconfig +5 -1
@@ -509,7 +509,11 @@ config SERIAL_S3C2440 help Serial port support for the Samsung S3C2440 and S3C2442 SoC - +config SERIAL_MAX3100 + tristate "MAX3100 support" + depends on SPI + help + MAX3100 chip support config SERIAL_DZ bool "DECstation DZ serial driver"
drivers/serial/Makefile +1 -0
@@ -31,6 +31,7 @@ obj-$(CONFIG_SERIAL_S3C2400) += s3c2400.o obj-$(CONFIG_SERIAL_S3C2410) += s3c2410.o obj-$(CONFIG_SERIAL_S3C2412) += s3c2412.o obj-$(CONFIG_SERIAL_S3C2440) += s3c2440.o +obj-$(CONFIG_SERIAL_MAX3100) += max3100.o obj-$(CONFIG_SERIAL_SUNCORE) += suncore.o obj-$(CONFIG_SERIAL_SUNHV) += sunhv.o obj-$(CONFIG_SERIAL_SUNZILOG) += sunzilog.o
drivers/serial/max3100.c new file +924 -0
924 lines not on this page · raw message
include/linux/serial_core.h +3 -0
@@ -155,6 +155,9 @@#define PORT_SC26XX 82 +/* MAX3100 */ +#define PORT_MAX3100 83 +#ifdef __KERNEL__#include <linux/compiler.h>
include/linux/serial_max3100.h new file +53 -0
53 lines not on this page · raw message
--
1.4.4.4
Quoted 4 lines · On Thu, 2 Oct 2008 10:39:13 +0200 Christian Pellegrin…
This patch adds support for the MAX3100 SPI UART. I am still
waiting for a minor number from [email protected] so that may change.
Both Alan and I had numerous review comments on the previous version of this patch.
You have not sent us a point-by-point response to those review comments which forces us to a) go back and see what all the comments were then
b) check the patch to see if/how each point was addressed. Needless to say, that's not a ton of fun for us.
Can you please reply to our earlier emails and let us know what changes were made against each review comment?
Thanks.
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
Quoted 3 lines · Andrew Morton
Can you please reply to our earlier emails and let us know what changes were made against each review comment?
OK, sorry, I just did what you said to do. :-) I' going to reply immediately.
Quoted 2 lines
Thanks.
Sorry again for the misunderstanding.
Bye,
Signature · 5 lines
Christian Pellegrin, see http://www.evolware.org/chri/ "Real Programmers don't play tennis, or any other sport which requires you to change clothes. Mountain climbing is OK, and Real Programmers wear their climbing boots to work in case a mountain should suddenly spring up in the middle of the computer room."
Quoted 1 line · On Thu, 2 Oct 2008 10:39:13 +0200 Christian Pellegrin…
Date: Thu, 2 Oct 2008 10:39:13 +0200
Three months.
Quoted 6 lines
X-Mailer: git-send-email 1.4.4.4
This patch adds support for the MAX3100 SPI UART. I am still
waiting for a minor number from [email protected] so that may change.
afaik this patch is still stuck, awaiting a nod for this:
include/linux/serial_core.h line 160
Quoted 9 lines
include/linux/serial_core.h +3
-0@@ -155,6 +155,9 @@#define PORT_SC26XX 82 +/* MAX3100 */ +#define PORT_MAX3100 83 +
Meanwhile, other people have gone and added new minors in there anyway.
I think I'll just merge it:
From: Christian Pellegrin <[email protected]>
Add support for the MAX3100 SPI UART.
(akpm: queued pending confirmation of the new major number)
max3100 driver need to select SERIAL_CORE like most other serial drivers do.
---
drivers/serial/Kconfig | 7 drivers/serial/Makefile | 1 drivers/serial/max3100.c | 927 +++++++++++++++++++++++++++++++ include/linux/serial_core.h | 3 include/linux/serial_max3100.h | 53 + 5 files changed, 991 insertions(+)
drivers/serial/Kconfig renamed from drivers/serial/Kconfig~max3100-spi-uart-driver +7 -0
@@ -533,6 +533,13 @@ config SERIAL_S3C6400 Serial port support for the Samsung S3C6400 and S3C6410 SoCs +config SERIAL_MAX3100 + tristate "MAX3100 support" + depends on SPI + select SERIAL_CORE + help + MAX3100 chip support + config SERIAL_DZ bool "DECstation DZ serial driver" depends on MACH_DECSTATION && 32BIT
drivers/serial/Makefile renamed from drivers/serial/Makefile~max3100-spi-uart-driver +1 -0
@@ -43,6 +43,7 @@ obj-$(CONFIG_SERIAL_S3C2412) += s3c2412. obj-$(CONFIG_SERIAL_S3C2440) += s3c2440.o obj-$(CONFIG_SERIAL_S3C24A0) += s3c24a0.o obj-$(CONFIG_SERIAL_S3C6400) += s3c6400.o +obj-$(CONFIG_SERIAL_MAX3100) += max3100.o obj-$(CONFIG_SERIAL_IP22_ZILOG) += ip22zilog.o obj-$(CONFIG_SERIAL_MUX) += mux.o obj-$(CONFIG_SERIAL_68328) += 68328serial.o
drivers/serial/max3100.c new file +927 -0
927 lines not on this page · raw message
include/linux/serial_core.h renamed from include/linux/serial_core.h~max3100-spi-uart-driver +3 -0
@@ -164,6 +164,9 @@/* NWPSERIAL */ #define PORT_NWPSERIAL 85 +/* MAX3100 */ +#define PORT_MAX3100 86 +#ifdef __KERNEL__#include <linux/compiler.h>
include/linux/serial_max3100.h new file +53 -0
53 lines not on this page · raw message
_
------------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It is the best place to buy or sell services for
just about anything Open Source.
http://p.sf.net/sfu/Xq1LFB
Quoted 7 lines · Andrew Morton
afaik this patch is still stuck, awaiting a nod for this:
Quoted 4 lines
include/linux/serial_core.h +0
-0@@ -155,6 +155,9 @@
Quoted 6 lines
include/linux/serial_core.h line 169
Quoted 5 lines
include/linux/serial_core.h +3
-0#define PORT_SC26XX 82 +/* MAX3100 */ +#define PORT_MAX3100 83 +
Hello,
I'm sorry. I asked two times following all the instructions in devices.txt (or at least trying to do so) without any response. I hope I didn't do something wrong. :-/
Thanks,
Signature · 5 lines
Christian Pellegrin, see http://www.evolware.org/chri/ "Real Programmers don't play tennis, or any other sport which requires you to change clothes. Mountain climbing is OK, and Real Programmers wear their climbing boots to work in case a mountain should suddenly spring up in the middle of the computer room."