Skip to contentSkip to conversation

crda: prevent key2pub.py from generating bogus output on failure

PATCH In review Pavel Roskin 3 participants 4 messages Jan 10, 2009 – Jan 15, 2009 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crda: prevent key2pub.py from generating bogus output on failure

Specify output file on the command line, so that it's not created in case of fatal errors, such as asbence of M2Crypto.

---
 Makefile         |    2 +-
 utils/key2pub.py |   57 ++++++++++++++++++++++++++++--------------------------
 2 files changed, 31 insertions(+), 28 deletions(-)
Makefile +1 -1
index c871182..292dad0 100644
@@ -64,7 +64,7 @@ $(REG_BIN):
 
 keys-%.c: utils/key2pub.py $(wildcard $(PUBKEY_DIR)/*.pem)
 	$(NQ) '  GEN ' $@
-	$(Q)./utils/key2pub.py --$* $(wildcard $(PUBKEY_DIR)/*.pem) > $@
+	$(Q)./utils/key2pub.py --$* $(wildcard $(PUBKEY_DIR)/*.pem) $@
 
 %.o: %.c regdb.h
 	$(NQ) '  CC  ' $@
utils/key2pub.py +30 -27

118 lines not on this page · raw message

#1 lore raw
Quoted 4 lines · Pavel Roskin

Specify output file on the command line, so that it's not created in case of fatal errors, such as asbence of M2Crypto.

Thanks, BTW these should be addressed to John as its his tree.

Luis

#2 lore raw
Quoted 7 lines · Luis Rodriguez
Quoted 4 lines · Pavel Roskin

Specify output file on the command line, so that it's not created in case of fatal errors, such as asbence of M2Crypto.

Thanks, BTW these should be addressed to John as its his tree.

Ooops wait sorry wrong tree -- heh.. I'll apply! The wireless-regdb is John's tree though.

Thanks!

Luis