mtd/lpddr/qinfo_probe.c needs lpddr_cmds to be compiled

DISCUSSION Alexander Beregalov 3 participants 5 messages Jan 10, 2009 – Jan 11, 2009 Memory technology devices (MTD)

Share & tools

Alexander Beregalov

author

2009-01-10 02:16 UTC #0 lore raw

drivers/built-in.o: In function `lpddr_probe':
drivers/mtd/lpddr/qinfo_probe.c:215:
undefined reference to `lpddr_cmdset'

# CONFIG_MTD_LPDDR is not set
CONFIG_MTD_QINFO_PROBE=y

Randy Dunlap

2009-01-10 05:16 UTC #1 lore raw

Quoted 7 lines · Alexander Beregalov

drivers/built-in.o: In function `lpddr_probe':
drivers/mtd/lpddr/qinfo_probe.c:215:
undefined reference to `lpddr_cmdset'
# CONFIG_MTD_LPDDR is not set
CONFIG_MTD_QINFO_PROBE=y
--

This patch has been posted, just needs to be merged (hint):
---

Signed-off-by Alexey Korolev <[email protected]>

---

drivers/mtd/lpddr/Kconfig +1 -0

index acd4ea9..5a401d8 100644
@@ -12,6 +12,7 @@ config MTD_LPDDR
 	  DDR memories, intended for battery-operated systems.
 
 config MTD_QINFO_PROBE
+	depends on MTD_LPDDR
 	tristate "Detect flash chips by QINFO probe"
 	help
 	    Device Information for LPDDR chips is offered through the Overlay

Alexey Korolev

2009-01-11 10:03 UTC #2 lore raw

Hi Randy,

I've just checked 2.6.29-rc1. It contains LPDDR patches but does not contain this patch. Do you know whom I should ask to make this included?

Thanks,
Alexey

Quoted 28 lines

Quoted 7 lines
drivers/built-in.o: In function `lpddr_probe':
drivers/mtd/lpddr/qinfo_probe.c:215:
undefined reference to `lpddr_cmdset'
# CONFIG_MTD_LPDDR is not set
CONFIG_MTD_QINFO_PROBE=y
--
This patch has been posted, just needs to be merged (hint):
---
Signed-off-by Alexey Korolev <[email protected]>
---
drivers/mtd/lpddr/Kconfig +1 -0
index acd4ea9..5a401d8 100644
@@ -12,6 +12,7 @@ config MTD_LPDDR
 	  DDR memories, intended for battery-operated systems.
 
 config MTD_QINFO_PROBE
+	depends on MTD_LPDDR
 	tristate "Detect flash chips by QINFO probe"
 	help
 	    Device Information for LPDDR chips is offered through the Overlay

Randy Dunlap

2009-01-11 16:51 UTC #3 lore raw

Quoted 4 lines · Alexey Korolev

Hi Randy,
I've just checked 2.6.29-rc1. It contains LPDDR patches but does not contain this patch. Do you know whom I should ask to make this included?

MAINTAINERS file:

MEMORY TECHNOLOGY DEVICES (MTD)

P:      David Woodhouse
M:      [email protected]

Quoted 30 lines

Thanks,
Alexey
Quoted 27 lines
Quoted 7 lines
drivers/built-in.o: In function `lpddr_probe':
drivers/mtd/lpddr/qinfo_probe.c:215:
undefined reference to `lpddr_cmdset'
# CONFIG_MTD_LPDDR is not set
CONFIG_MTD_QINFO_PROBE=y
--
This patch has been posted, just needs to be merged (hint):
---
Signed-off-by Alexey Korolev <[email protected]>
---
drivers/mtd/lpddr/Kconfig +1 -0
index acd4ea9..5a401d8 100644
@@ -12,6 +12,7 @@ config MTD_LPDDR
 	  DDR memories, intended for battery-operated systems.
 
 config MTD_QINFO_PROBE
+	depends on MTD_LPDDR
 	tristate "Detect flash chips by QINFO probe"
 	help
 	    Device Information for LPDDR chips is offered through the Overlay

Signature · 1 line

~Randy

Alexey Korolev

2009-01-11 18:16 UTC #4 lore raw

Randy,
Yes, it has alreay been merged today.

David,
Thank you very much!

Quoted 46 lines

MAINTAINERS file:
MEMORY TECHNOLOGY DEVICES (MTD)
P:      David Woodhouse
M:      [email protected]
Quoted 30 lines
Thanks,
Alexey
Quoted 27 lines
Quoted 7 lines
drivers/built-in.o: In function `lpddr_probe':
drivers/mtd/lpddr/qinfo_probe.c:215:
undefined reference to `lpddr_cmdset'
# CONFIG_MTD_LPDDR is not set
CONFIG_MTD_QINFO_PROBE=y
--
This patch has been posted, just needs to be merged (hint):
---
Signed-off-by Alexey Korolev <[email protected]>
---
drivers/mtd/lpddr/Kconfig +1 -0
index acd4ea9..5a401d8 100644
@@ -12,6 +12,7 @@ config MTD_LPDDR
 	  DDR memories, intended for battery-operated systems.
 
 config MTD_QINFO_PROBE
+	depends on MTD_LPDDR
 	tristate "Detect flash chips by QINFO probe"
 	help
 	    Device Information for LPDDR chips is offered through the Overlay
Signature · 5 lines
~Randy

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/