Skip to contentSkip to conversation

copy_{to,from}_user

DISCUSSION Brad Parker 4 participants 4 messages Jan 9, 2009 – Jan 11, 2009

lore
Share & tools
lore
#0 lore raw

I have a question about copy_{to,from}_user.

Most implementations I've seen do in-order copies and notice when an exception occurs and report back the progress. This is straight forward.

(but to be honest, I have suspicions about how just how accurate those reports are i.e. +/- 1-3 bytes on some architectures)

On some cpu's it is advantageous to do an out-of-order copy to take advantage of various cache fill mechanisms.

The problem is that the out-of-order copy makes it impossible to know where the exception occurred (in terms of progress).

Would it be permissible to have a version of copy_{to,from}_user which does an out-of-order copy and when an exception occurs, restarts the copy from the beginning using a simple in-order copy, to make it possible to identify where the exception occurs?

The idea is that exceptions are rare and so the performance hit of doing the "recopy" would be minimal and would provide the required accuracy.

-brad

#1 lore raw
Quoted 15 lines · Brad Parker

I have a question about copy_{to,from}_user.

Most implementations I've seen do in-order copies and notice when an exception occurs and report back the progress. This is straight forward.

(but to be honest, I have suspicions about how just how accurate those reports are i.e. +/- 1-3 bytes on some architectures)

On some cpu's it is advantageous to do an out-of-order copy to take advantage of various cache fill mechanisms.

The problem is that the out-of-order copy makes it impossible to know where the exception occurred (in terms of progress).

Quoted 7 lines

Would it be permissible to have a version of copy_{to,from}_user which does an out-of-order copy and when an exception occurs, restarts the copy from the beginning using a simple in-order copy, to make it possible to identify where the exception occurs?

The idea is that exceptions are rare and so the performance hit of doing the "recopy" would be minimal and would provide the required accuracy.

x86_64 already does some unrolling and is inaccurate as to where exactly it happens. The only thing that is very important is that you _never_ say you copied more than you actually did.

That was the source of a data corruption bug a while ago, the code did something like sequences: read 8 words, write 8 words. And reported the number of bytes read, instead of bytes written, which is an over-estimation.

#2 lore raw
Quoted 24 lines · Peter Zijlstra
Quoted 15 lines · Brad Parker

I have a question about copy_{to,from}_user.

Most implementations I've seen do in-order copies and notice when an exception occurs and report back the progress. This is straight forward.

(but to be honest, I have suspicions about how just how accurate those reports are i.e. +/- 1-3 bytes on some architectures)

On some cpu's it is advantageous to do an out-of-order copy to take advantage of various cache fill mechanisms.

The problem is that the out-of-order copy makes it impossible to know where the exception occurred (in terms of progress).

Quoted 7 lines

Would it be permissible to have a version of copy_{to,from}_user which does an out-of-order copy and when an exception occurs, restarts the copy from the beginning using a simple in-order copy, to make it possible to identify where the exception occurs?

The idea is that exceptions are rare and so the performance hit of doing the "recopy" would be minimal and would provide the required accuracy.

Quoted 8 lines

x86_64 already does some unrolling and is inaccurate as to where exactly it happens. The only thing that is very important is that you _never_ say you copied more than you actually did.

That was the source of a data corruption bug a while ago, the code did something like sequences: read 8 words, write 8 words. And reported the number of bytes read, instead of bytes written, which is an over-estimation.

you sure must have meant 'write 7 words' or something like that?

Ingo

#3 lore raw
Quoted 29 lines · Ingo Molnar
Quoted 28 lines · Peter Zijlstra
Quoted 15 lines · Brad Parker

I have a question about copy_{to,from}_user.

Most implementations I've seen do in-order copies and notice when an exception occurs and report back the progress. This is straight forward.

(but to be honest, I have suspicions about how just how accurate those reports are i.e. +/- 1-3 bytes on some architectures)

On some cpu's it is advantageous to do an out-of-order copy to take advantage of various cache fill mechanisms.

The problem is that the out-of-order copy makes it impossible to know where the exception occurred (in terms of progress).

Quoted 7 lines

Would it be permissible to have a version of copy_{to,from}_user which does an out-of-order copy and when an exception occurs, restarts the copy from the beginning using a simple in-order copy, to make it possible to identify where the exception occurs?

The idea is that exceptions are rare and so the performance hit of doing the "recopy" would be minimal and would provide the required accuracy.

x86_64 already does some unrolling and is inaccurate as to where exactly it happens. The only thing that is very important is that you _never_ say you copied more than you actually did.

Quoted 6 lines
Quoted 4 lines

That was the source of a data corruption bug a while ago, the code did something like sequences: read 8 words, write 8 words. And reported the number of bytes read, instead of bytes written, which is an over-estimation.

you sure must have meant 'write 7 words' or something like that?

I understood it as: the code read 8 words, and wrote 8 words. But only n < 8 words could be written, while the code still returned 8.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds