Bug in aplay/arecord --list-pcms
PATCH 1/1 Bug in aplay/arecord --list-pcms
Hi,
I have just discovered a minor logic inversion bug in aplay/arecord --list-pcms functionality.
Basically, executing "aplay --list-pcms" lists all devices capable of capture and executing "arecord --list-pcms" lists all devices capable of playback.
Please find below a patch to resolve this issue.
Best regards
Peter Stokes
-------------------------------------------------------------------------------
aplay/aplay.c +1 -1
@@ -287,7 +287,7 @@ static void pcm_list(void) name =snd_device_name_get_hint (*n,"NAME" ); descr =snd_device_name_get_hint (*n,"DESC" ); io =snd_device_name_get_hint (*n,"IOID" ); -if (io !=NULL &&strcmp (io, filter) ==0 ) +if (io !=NULL &&strcmp (io, filter) !=0 ) goto __end;printf ("%s\n" , name);if ((descr1 = descr) !=NULL ) {
At Sun, 11 Jan 2009 15:05:21 +0000,
Quoted 10 lines · Peter Stokes
Hi,
I have just discovered a minor logic inversion bug in aplay/arecord --list-pcms functionality.
Basically, executing "aplay --list-pcms" lists all devices capable of capture and executing "arecord --list-pcms" lists all devices capable of playback.
Please find below a patch to resolve this issue.
Quoted 7 lines
Best regards
Peter Stokes
-------------------------------------------------------------------------------
Signed-off-by Peter Stokes <[email protected]>
Thanks! Applied now.
Takashi
Quoted 20 lines
aplay/aplay.c +1
-1@@ -287,7 +287,7 @@ static void pcm_list(void) name =snd_device_name_get_hint (*n,"NAME" ); descr =snd_device_name_get_hint (*n,"DESC" ); io =snd_device_name_get_hint (*n,"IOID" ); -if (io !=NULL &&strcmp (io, filter) ==0 ) +if (io !=NULL &&strcmp (io, filter) !=0 ) goto __end;printf ("%s\n" , name);if ((descr1 = descr) !=NULL ) {_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel