Skip to contentSkip to conversation

powerpc/83xx: Make serial ports work on MPC8315E-RDB w/ FSL U-Boots

PATCH Applied Anton Vorontsov 4 participants 7 messages Jan 11, 2009 – Jan 13, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 powerpc/83xx: Make serial ports work on MPC8315E-RDB w/ FSL U-Boots

FSL U-Boots use /soc8315@e0000000 node to search and fixup serial nodes' clock-frequency properties. Though in upstream kernels we use new naming convention -- for IMMR address space dts files specify /immr@e0000000 nodes.

This makes FSL U-Boots fail to fixup the clock frequencies, and that leads to serial ports misbehaviour. We can workaround the issue by filling the clock frequency values manually.

p.s. For the same reason FSL U-Boots fail to fixup MAC addresses for ethernet nodes, so users should either change the .dts file locally or set MAC address via `ifconfig hw ether' command.

---

Leon,

With this patch 2.6.28 kernel boots and works fine with the U-Boot I took from this image (downloadable from freescale.com):

$ md5sum MPC8315ERDB_20080321-ltib.iso
009730826366d593347b88fa4fdb9be0  MPC8315ERDB_20080321-ltib.iso

That is, U-Boot 1.3.0-rc2 (Mar 21 2008 - 13:36:09) MPC83XX

 arch/powerpc/boot/dts/mpc8315erdb.dts |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
arch/powerpc/boot/dts/mpc8315erdb.dts +2 -2
index 9a4fa2a..88d691c 100644
@@ -257,7 +257,7 @@
 			device_type = "serial";
 			compatible = "ns16550";
 			reg = <0x4500 0x100>;
-			clock-frequency = <0>;
+			clock-frequency = <133333333>;
 			interrupts = <9 0x8>;
 			interrupt-parent = <&ipic>;
 		};
@@ -267,7 +267,7 @@
 			device_type = "serial";
 			compatible = "ns16550";
 			reg = <0x4600 0x100>;
-			clock-frequency = <0>;
+			clock-frequency = <133333333>;
 			interrupts = <10 0x8>;
 			interrupt-parent = <&ipic>;
 		};
Signature · 1 line
1.5.6.5
#1 lore raw

RE: [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/FSL U-Boots

Quoted 10 lines

-----Original Message-----
From: [email protected]=20 [mailto:[email protected]]=20 On Behalf Of Anton Vorontsov
Sent: Sunday, January 11, 2009 11:30 PM
To: Kumar Gala
Cc: [email protected]
Subject: [PATCH] powerpc/83xx: Make serial ports work on=20 MPC8315E-RDB w/FSL U-Boots
=20

Quoted 8 lines

FSL U-Boots use /soc8315@e0000000 node to search and fixup=20 serial nodes' clock-frequency properties. Though in upstream=20 kernels we use new naming convention -- for IMMR address=20 space dts files specify /immr@e0000000 nodes.
=20
This makes FSL U-Boots fail to fixup the clock frequencies,=20 and that leads to serial ports misbehaviour. We can=20 workaround the issue by filling the clock frequency values manually.

Freescale BSP is for customer who needs the out-of-box experience. It's better tested, but doesn't update very frequently. I would suggest the customer to use the upstream u-boot, if they decide to use latest upstream kernel.

- Leo

#2 lore raw

Re: [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/FSL U-Boots

Quoted 19 lines · Li Yang
Quoted 10 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Anton Vorontsov
Sent: Sunday, January 11, 2009 11:30 PM
To: Kumar Gala
Cc: [email protected]
Subject: [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/FSL U-Boots

Quoted 8 lines

FSL U-Boots use /soc8315@e0000000 node to search and fixup serial nodes' clock-frequency properties. Though in upstream kernels we use new naming convention -- for IMMR address space dts files specify /immr@e0000000 nodes.

This makes FSL U-Boots fail to fixup the clock frequencies, and that leads to serial ports misbehaviour. We can workaround the issue by filling the clock frequency values manually.

Quoted 6 lines

Freescale BSP is for customer who needs the out-of-box experience. It's better tested, but doesn't update very frequently. I would suggest the customer to use the upstream u-boot, if they decide to use latest upstream kernel.

- Leo

Agreed. However I don't think there is any harm w/the patch as upstream u-boot will update the property.

- k

#3 lore raw

Re: [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/FSL U-Boots

Hello,

Quoted 8 lines · Kumar Gala
Quoted 6 lines · Li Yang
Quoted 1 line

-----Original Message-----

Freescale BSP is for customer who needs the out-of-box experience. It's better tested, but doesn't update very frequently. I would suggest the customer to use the upstream u-boot, if they decide to use latest upstream kernel.

The upstream u-boot did however not support PCI Express, which the latest Freescale kernel did.

So it was a chicken-egg problem experience for people wanting to test both the latest Freescale kernel as well as Antov's work to bring the PCI Express support upstream.

Thanks Antov et al,

Signature · 1 line
Leon
#4 lore raw

Re: [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/FSL U-Boots

Quoted 11 lines · Leon Woestenberg

Hello,

Quoted 8 lines · Kumar Gala
Quoted 6 lines · Li Yang
Quoted 1 line

-----Original Message-----

Freescale BSP is for customer who needs the out-of-box experience. It's better tested, but doesn't update very frequently. I would suggest the customer to use the upstream u-boot, if they decide to use latest upstream kernel.

Quoted 8 lines

The upstream u-boot did however not support PCI Express, which the latest Freescale kernel did.

So it was a chicken-egg problem experience for people wanting to test both the latest Freescale kernel as well as Antov's work to bring the PCI Express support upstream.

Thanks Antov et al,

Please gripe at your Freescale contacts about getting code into mainline/upstream kernel.

(The more they hear it from customers the more importance it will get. The team I work on at Freescale can focus on only so much and the other groups need to hear that customers want code in mainline.)

And thanks Anton for cleaning all this up and getting it in a state that is acceptable :)

- k

#5 lore raw

Re: [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/FSL U-Boots

In reply to Kumar Gala
Quoted 27 lines · Kumar Gala
Quoted 24 lines · Li Yang
Quoted 10 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Anton Vorontsov
Sent: Sunday, January 11, 2009 11:30 PM
To: Kumar Gala
Cc: [email protected]
Subject: [PATCH] powerpc/83xx: Make serial ports work on MPC8315E-RDB w/FSL U-Boots

Quoted 8 lines

FSL U-Boots use /soc8315@e0000000 node to search and fixup serial nodes' clock-frequency properties. Though in upstream kernels we use new naming convention -- for IMMR address space dts files specify /immr@e0000000 nodes.

This makes FSL U-Boots fail to fixup the clock frequencies, and that leads to serial ports misbehaviour. We can workaround the issue by filling the clock frequency values manually.

Freescale BSP is for customer who needs the out-of-box experience. It's better tested, but doesn't update very frequently. I would suggest the customer to use the upstream u-boot, if they decide to use latest upstream kernel.

Quoted 4 lines
Quoted 1 line

- Leo

Agreed. However I don't think there is any harm w/the patch as upstream u-boot will update the property.

You are right. There will be no harm as upstream u-boot can update
the DTS of old binding.

- Leo

Applied
#6 lore raw
In reply to Anton Vorontsov
Quoted 21 lines · Anton Vorontsov

FSL U-Boots use /soc8315@e0000000 node to search and fixup serial nodes' clock-frequency properties. Though in upstream kernels we use new naming convention -- for IMMR address space dts files specify /immr@e0000000 nodes.

This makes FSL U-Boots fail to fixup the clock frequencies, and that leads to serial ports misbehaviour. We can workaround the issue by filling the clock frequency values manually.

p.s. For the same reason FSL U-Boots fail to fixup MAC addresses for ethernet nodes, so users should either change the .dts file locally or set MAC address via `ifconfig hw ether' command.

---

Leon,

With this patch 2.6.28 kernel boots and works fine with the U-Boot I took from this image (downloadable from freescale.com):

Quoted 7 lines
$ md5sum MPC8315ERDB_20080321-ltib.iso
009730826366d593347b88fa4fdb9be0  MPC8315ERDB_20080321-ltib.iso

That is, U-Boot 1.3.0-rc2 (Mar 21 2008 - 13:36:09) MPC83XX

arch/powerpc/boot/dts/mpc8315erdb.dts | 4 ++--

1 files changed, 2 insertions(+), 2 deletions(-)

applied

- k