pcf50663 MFD driver modular build failure
This started happening with Linus's pull from today for sparc64 allmodconfig:
ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined!
ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined!
Sure we can export __set_irq_handler() and handle_level_irq() to modules to fix this, but that looks like some hokey stuff for a MFD driver to be doing :-)
Quoted 10 lines · David Miller
This started happening with Linus's pull from today for sparc64 allmodconfig:
ERROR: "
__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined!
ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined!Sure we can export
__set_irq_handler()andhandle_level_irq()to modules to fix this, but that looks like some hokey stuff for a MFD driver to be doing :-)
Yes, right! It's really not necessary. I've sent a patch to remove it.
Thanks,
Balaji
Quoted 5 lines · Balaji Rao
Quoted 4 lines · David Miller
This started happening with Linus's pull from today for sparc64 allmodconfig:
Quoted 9 lines
Quoted 6 lines
ERROR: "
__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined!
ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined!Sure we can export
__set_irq_handler()andhandle_level_irq()to modules to fix this, but that looks like some hokey stuff for a MFD driver to be doing :-)Yes, right! It's really not necessary. I've sent a patch to remove it.
Thanks, I just hit this on a rawhide build as well...
Quoted 5 lines · On Tue, 13 Jan 2009 12:22:02 +0530 Balaji Rao wrote:
Quoted 4 lines · David Miller
This started happening with Linus's pull from today for sparc64 allmodconfig:
Quoted 8 lines
Quoted 6 lines
ERROR: "
__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined!
ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined!Sure we can export
__set_irq_handler()andhandle_level_irq()to modules to fix this, but that looks like some hokey stuff for a MFD driver to be doing :-)Yes, right! It's really not necessary. I've sent a patch to remove it.
Who did you send the patch to and where is it in the queue??
thanks,
---
~Randy
Quoted 10 lines · Randy Dunlap
Quoted 8 lines · On Tue, 13 Jan 2009 12:22:02 +0530 Balaji Rao wrote:
Quoted 7 lines · David Miller
This started happening with Linus's pull from today for sparc64 allmodconfig:
ERROR: "
__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined!
ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined!
Quoted 7 lines
Quoted 5 lines
Quoted 3 lines
Sure we can export
__set_irq_handler()andhandle_level_irq()to modules to fix this, but that looks like some hokey stuff for a MFD driver to be doing :-)Yes, right! It's really not necessary. I've sent a patch to remove it.
Who did you send the patch to and where is it in the queue??
Samuel has taken it into his linux-mfd tree and should be sending a pull request real soon.
Thanks,
Balaji