MPC8349EMDS: do not setup unused PCI clock outputs in PCI agent mode
PATCH 1/1 MPC8349EMDS: do not setup unused PCI clock outputs in PCI agent mode
When running in PCI agent mode, the PCI_CLK_OUT signals are not used, so do not enable them. See the MPC8349EA Reference Manual, Section 4.4.2 "Clocking in PCI Agent Mode".
--- board/freescale/mpc8349emds/pci.c | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-)
board/freescale/mpc8349emds/pci.c +0 -7
@@ -171,15 +171,10 @@ void pci_init_board(void)void pci_init_board (void ) {volatile immap_t *immr = (volatile immap_t *)CONFIG_SYS_IMMR ; -volatile clk83xx_t *clk = (volatile clk83xx_t *)&immr->clk;volatile law83xx_t *pci_law = immr->sysconf.pcilaw;volatile pcictrl83xx_t *pci_ctrl = &immr->pci_ctrl[0 ];struct pci_region *reg[] = { pci1_regions }; -/* Enable all 8 PCI_CLK_OUTPUTS */ - clk->occr =0xff000000 ; -udelay (2000 ); -/* Configure PCI Local Access Windows */ pci_law[0 ].bar =CONFIG_SYS_PCI1_MEM_PHYS &LAWBAR_BAR ; pci_law[0 ].ar =LAWAR_EN |LAWAR_SIZE_1G ;
@@ -187,8 +182,6 @@ void pci_init_board(void) pci_law[1 ].bar =CONFIG_SYS_PCI1_IO_PHYS &LAWBAR_BAR ; pci_law[1 ].ar =LAWAR_EN |LAWAR_SIZE_4M ; -udelay (2000 ); -mpc83xx_pci_init (1 , reg,0 );/* Configure PCI Inbound Translation Windows (3 1MB windows) */
Signature · 1 line
1.5.4.3
PATCH 1/1 MPC8349EMDS: do not setup unused PCI clock outputsin PCI agent mode
board/freescale/mpc8349emds/pci.c void pci_init_board(void) · line 181
Quoted 11 lines
void
pci_init_board(void)
{board/freescale/mpc8349emds/pci.c +0
-4volatile immap_t *immr = (volatile immap_t *)CONFIG_SYS_IMMR ; -volatile clk83xx_t *clk = (volatile clk83xx_t *)&immr->clk;volatile law83xx_t *pci_law = immr->sysconf.pcilaw;volatile pcictrl83xx_t *pci_ctrl = &immr->pci_ctrl[0 ];struct pci_region *reg[] = { pci1_regions }; -/* Enable all 8 PCI_CLK_OUTPUTS */ - clk->occr =0xff000000 ; -udelay (2000 );
It will cause the PCI host broken. It needs case by case
PATCH 1/1 MPC8349EMDS: do not setup unused PCI clock outputsin PCI agent mode
Quoted 8 lines · Liu Dave
Quoted 8 lines
void
pci_init_board(void)
{board/freescale/mpc8349emds/pci.c +0
-1volatile immap_t *immr = (volatile immap_t *)CONFIG_SYS_IMMR ; -volatile clk83xx_t *clk = (volatile clk83xx_t *)&immr->clk;volatile law83xx_t *pci_law = immr->sysconf.pcilaw;volatile pcictrl83xx_t *pci_ctrl = &immr->pci_ctrl[0 ];struct pci_region *reg[] = { pci1_regions };
Quoted 6 lines
board/freescale/mpc8349emds/pci.c void pci_init_board(void) · line 181
Quoted 3 lines
board/freescale/mpc8349emds/pci.c +0
-3-/* Enable all 8 PCI_CLK_OUTPUTS */ - clk->occr =0xff000000 ; -udelay (2000 );It will cause the PCI host broken. It needs case by case
Yes, there are two pci_init_board() functions in this file. One for PCI host mode, and one for PCI agent mode. This version only runs in agent mode, it doesn't even get compiled in host mode.
It should be fine in host mode.
Thanks,
Ira
PATCH 1/1 MPC8349EMDS: do not setup unused PCI clockoutputsin PCI agent mode
Quoted 4 lines
Yes, there are two
pci_init_board()functions in this file. One for PCI
host mode, and one for PCI agent mode. This version only runs in agent mode, it doesn't even get compiled in host mode.
That is fine.
PATCH 1/1 MPC8349EMDS: do not setup unused PCI clock outputs in PCI agent mode
In reply to Ira SnyderQuoted 8 lines · On Mon, 12 Jan 2009 13:33:17 -0800 Ira Snyder <[email protected]> wrote:
When running in PCI agent mode, the
PCI_CLK_OUTsignals are not used, so do not enable them. See the MPC8349EA Reference Manual, Section 4.4.2 "Clocking in PCI Agent Mode".Signed-off-by Ira W. Snyder <[email protected]>--- board/freescale/mpc8349emds/pci.c | 7 ------- 1 files changed, 0 insertions(+), 7 deletions(-)
applied to u-boot-mpc83xx next.
Thanks,
Kim