wrong usage of __devexit_p and __exit_p
Subsystems (26)
Hello,
I found several drivers that use __devexit_p and __exit_p on functions that don't live in .devexit.text or .exit.text resp.
The impact is either that these functions use memory without being used or that they don't link.
I send 24 patches as a reply to this mail. I choosed to move the functions into the respective function instead of using the right __{dev,}exit_p wrapper because it seems to me to have less impact.
I didn't made the effort to find out the right people to Cc: but I hope that Andrew takes care of that :-)
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH 1/1 move asic3_remove to .devexit.text
The function asic3_remove is used only wrapped by __devexit_p so define it using __devexit.
--- drivers/mfd/asic3.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mfd/asic3.c +1 -1
@@ -606,7 +606,7 @@ static int __init asic3_probe(struct platform_device *pdev)return ret; } -static int asic3_remove (struct platform_device *pdev) +static int __devexit asic3_remove(struct platform_device *pdev) {int ret;struct asic3 *asic =platform_get_drvdata (pdev);
Signature · 1 line
1.5.6.5
PATCH 1/1 move bbc_remove to .devexit.text
In reply to Uwe Kleine-KönigThe function bbc_remove is used only wrapped by __devexit_p so define it using __devexit.
--- drivers/input/misc/sparcspkr.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/input/misc/sparcspkr.c +1 -1
@@ -230,7 +230,7 @@ out_err:return err; } -static int bbc_remove (struct of_device *op) +static int __devexit bbc_remove(struct of_device *op) {struct sparcspkr_state *state =dev_get_drvdata (&op->dev);struct input_dev *input_dev = state->input_dev;
Signature · 1 line
1.5.6.5
PATCH 1/1 move grover_remove to .devexit.text
In reply to Uwe Kleine-KönigThe function grover_remove is used only wrapped by __devexit_p so define it using __devexit.
--- drivers/input/misc/sparcspkr.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/input/misc/sparcspkr.c +1 -1
@@ -308,7 +308,7 @@ out_err:return err; } -static int grover_remove (struct of_device *op) +static int __devexit grover_remove(struct of_device *op) {struct sparcspkr_state *state =dev_get_drvdata (&op->dev);struct grover_beep_info *info = &state->u.grover;
Signature · 1 line
1.5.6.5
PATCH 1/1 move hifn_remove to .devexit.text
In reply to Uwe Kleine-KönigThe function hifn_remove is used only wrapped by __devexit_p so define it using __devexit.
--- drivers/crypto/hifn_795x.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/crypto/hifn_795x.c +1 -1
@@ -2696,7 +2696,7 @@ err_out_disable_pci_device:return err; } -static void hifn_remove (struct pci_dev *pdev) +static void __devexit hifn_remove(struct pci_dev *pdev) {int i;struct hifn_device *dev;
Signature · 1 line
1.5.6.5
PATCH 1/1 move ilo_remove to .devexit.text
In reply to Uwe Kleine-KönigThe function ilo_remove is used only wrapped by __devexit_p so define it using __devexit.
--- drivers/misc/hpilo.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/misc/hpilo.c +1 -1
@@ -611,7 +611,7 @@ out:return error; } -static void ilo_remove (struct pci_dev *pdev) +static void __devexit ilo_remove(struct pci_dev *pdev) {int i, minor;struct ilo_hwinfo *ilo_hw =pci_get_drvdata (pdev);
Signature · 1 line
1.5.6.5
PATCH 1/1 move jsm_remove_one to .devexit.text
In reply to Uwe Kleine-KönigThe function jsm_remove_one is used only wrapped by __devexit_p so define it using __devexit.
--- drivers/serial/jsm/jsm_driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/serial/jsm/jsm_driver.c +1 -1
@@ -180,7 +180,7 @@ static int jsm_probe_one(struct pci_dev *pdev, const struct pci_device_id *ent)return rc; } -static void jsm_remove_one (struct pci_dev *pdev) +static void __devexit jsm_remove_one(struct pci_dev *pdev) {struct jsm_board *brd =pci_get_drvdata (pdev);int i =0 ;
Signature · 1 line
1.5.6.5
PATCH 1/1 move max7301_remove to .devexit.text
In reply to Uwe Kleine-KönigThe function max7301_remove is used only wrapped by __devexit_p so define it using __devexit.
--- drivers/gpio/max7301.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/gpio/max7301.c +1 -1
@@ -285,7 +285,7 @@ exit_destroy:return ret; } -static int max7301_remove (struct spi_device *spi) +static int __devexit max7301_remove(struct spi_device *spi) {struct max7301 *ts;int ret;
Signature · 1 line
1.5.6.5
PATCH 1/1 move megaraid_detach_one to .devexit.text
In reply to Uwe Kleine-KönigThe function megaraid_detach_one is used only wrapped by __devexit_p so define it using __devexit.
--- drivers/scsi/megaraid/megaraid_mbox.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/megaraid/megaraid_mbox.c +2 -2
@@ -76,7 +76,7 @@ static int megaraid_init(void);static void megaraid_exit (void );static int megaraid_probe_one (struct pci_dev *,const struct pci_device_id *); -static void megaraid_detach_one (struct pci_dev *); +static void __devexit megaraid_detach_one(struct pci_dev *);static void megaraid_mbox_shutdown (struct pci_dev *);static int megaraid_io_attach (adapter_t *);
@@ -551,7 +551,7 @@ out_probe_one:* * This routine is also called from the PCI hotplug system. */ -static void +static void __devexitmegaraid_detach_one (struct pci_dev *pdev) {adapter_t *adapter;
Signature · 1 line
1.5.6.5
PATCH 1/1 move mpc85xx_pci_err_remove to .devexit.text
In reply to Uwe Kleine-KönigThe function mpc85xx_pci_err_remove is used only wrapped by __devexit_p so define it using __devexit.
--- drivers/edac/mpc85xx_edac.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/edac/mpc85xx_edac.c +1 -1
@@ -302,7 +302,7 @@ err:return res; } -static int mpc85xx_pci_err_remove (struct of_device *op) +static int __devexit mpc85xx_pci_err_remove(struct of_device *op) {struct edac_pci_ctl_info *pci =dev_get_drvdata (&op->dev);struct mpc85xx_pci_pdata *pdata = pci->pvt_info;
Signature · 1 line
1.5.6.5
PATCH 1/1 move mv64x60_pci_err_remove to .devexit.text
In reply to Uwe Kleine-KönigThe function mv64x60_pci_err_remove is used only wrapped by __devexit_p so define it using __devexit.
--- drivers/edac/mv64x60_edac.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/edac/mv64x60_edac.c +1 -1
@@ -206,7 +206,7 @@ err:return res; } -static int mv64x60_pci_err_remove (struct platform_device *pdev) +static int __devexit mv64x60_pci_err_remove(struct platform_device *pdev) {struct edac_pci_ctl_info *pci =platform_get_drvdata (pdev);
Signature · 1 line
1.5.6.5
PATCH 1/1 move mxcnd_remove to .exit.text
In reply to Uwe Kleine-KönigThe function mxcnd_remove is used only wrapped by __exit_p so define it using __exit.
--- drivers/mtd/nand/mxc_nand.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/mtd/nand/mxc_nand.c +1 -1
@@ -991,7 +991,7 @@ eclk:return err; } -static int __devexit mxcnd_remove(struct platform_device *pdev) +static int __exit mxcnd_remove(struct platform_device *pdev) {struct mxc_nand_host *host =platform_get_drvdata (pdev);
Signature · 1 line
1.5.6.5
PATCH 1/1 move pxa_camera_remove to .exit.text
In reply to Uwe Kleine-KönigThe function pxa_camera_remove is used only wrapped by __exit_p so define it using __exit.
--- drivers/media/video/pxa_camera.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/media/video/pxa_camera.c +1 -1
@@ -1521,7 +1521,7 @@ exit:return err; } -static int __devexit pxa_camera_remove(struct platform_device *pdev) +static int __exit pxa_camera_remove(struct platform_device *pdev) {struct pxa_camera_dev *pcdev =platform_get_drvdata (pdev);struct resource *res;
Signature · 1 line
1.5.6.5
PATCH 1/1 move s3c_adc_remove to .devexit.text
In reply to Uwe Kleine-KönigThe function s3c_adc_remove is used only wrapped by __devexit_p so define it using __devexit.
--- arch/arm/plat-s3c24xx/adc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-s3c24xx/adc.c +1 -1
@@ -302,7 +302,7 @@ static int s3c_adc_probe(struct platform_device *pdev)return ret; } -static int s3c_adc_remove (struct platform_device *pdev) +static int __devexit s3c_adc_remove(struct platform_device *pdev) {struct adc_device *adc =platform_get_drvdata (pdev);
Signature · 1 line
1.5.6.5
PATCH 1/1 move s3c_pwm_remove to .devexit.text
In reply to Uwe Kleine-KönigThe function s3c_pwm_remove is used only wrapped by __devexit_p so define it using __devexit.
--- arch/arm/plat-s3c24xx/pwm.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-s3c24xx/pwm.c +1 -1
@@ -363,7 +363,7 @@ static int s3c_pwm_probe(struct platform_device *pdev)return ret; } -static int s3c_pwm_remove (struct platform_device *pdev) +static int __devexit s3c_pwm_remove(struct platform_device *pdev) {struct pwm_device *pwm =platform_get_drvdata (pdev);
Signature · 1 line
1.5.6.5
PATCH 1/1 move sc26xx_driver_remove to .devexit.text
In reply to Uwe Kleine-KönigThe function pxa_camera_remove is used only wrapped by __devexit_p so define it using __devexit.
--- drivers/serial/sc26xx.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/serial/sc26xx.c +1 -1
@@ -709,7 +709,7 @@ out_free_port: } -static int __exit sc26xx_driver_remove(struct platform_device *dev) +static int __devexit sc26xx_driver_remove(struct platform_device *dev) {struct uart_sc26xx_port *up =dev_get_drvdata (&dev->dev);
Signature · 1 line
1.5.6.5
PATCH 1/1 move spidev_remove to .devexit.text
In reply to Uwe Kleine-KönigThe function spidev_remove is used only wrapped by __devexit_p so define it using __devexit.
--- drivers/spi/spidev.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/spi/spidev.c +1 -1
@@ -605,7 +605,7 @@ static int spidev_probe(struct spi_device *spi)return status; } -static int spidev_remove (struct spi_device *spi) +static int __devexit spidev_remove(struct spi_device *spi) {struct spidev_data *spidev =spi_get_drvdata (spi);
Signature · 1 line
1.5.6.5
PATCH 1/1 move stex_remove to .devexit.text
In reply to Uwe Kleine-KönigThe function stex_remove is used only wrapped by __devexit_p so define it using __devexit.
--- drivers/scsi/stex.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/scsi/stex.c +1 -1
@@ -1260,7 +1260,7 @@ static void stex_hba_free(struct st_hba *hba) hba->dma_mem, hba->dma_handle); } -static void stex_remove (struct pci_dev *pdev) +static void __devexit stex_remove(struct pci_dev *pdev) {struct st_hba *hba =pci_get_drvdata (pdev);
Signature · 1 line
1.5.6.5
PATCH 1/1 move stli_pciremove to .devexit.text
In reply to Uwe Kleine-KönigThe function stli_pciremove is used only wrapped by __devexit_p so define it using __devexit.
--- drivers/char/istallion.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/char/istallion.c +1 -1
@@ -3802,7 +3802,7 @@ err:return retval; } -static void stli_pciremove (struct pci_dev *pdev) +static void __devexit stli_pciremove(struct pci_dev *pdev) {struct stlibrd *brdp =pci_get_drvdata (pdev);
Signature · 1 line
1.5.6.5
PATCH 1/1 move vhci_hcd_remove to .devexit.text
In reply to Uwe Kleine-KönigThe function vhci_hcd_remove is used only wrapped by __devexit_p so define it using __devexit.
--- drivers/staging/usbip/vhci_hcd.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/staging/usbip/vhci_hcd.c +1 -1
@@ -1119,7 +1119,7 @@ static int vhci_hcd_probe(struct platform_device *pdev) } -static int vhci_hcd_remove (struct platform_device *pdev) +static int __devexit vhci_hcd_remove(struct platform_device *pdev) {struct usb_hcd *hcd;
Signature · 1 line
1.5.6.5
PATCH 1/1 move virtballoon_remove to .devexit.text
In reply to Uwe Kleine-KönigThe function virtballoon_remove is used only wrapped by __devexit_p so define it using __devexit.
--- drivers/virtio/virtio_balloon.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/virtio/virtio_balloon.c +1 -1
@@ -250,7 +250,7 @@ out:return err; } -static void virtballoon_remove (struct virtio_device *vdev) +static void __devexit virtballoon_remove(struct virtio_device *vdev) {struct virtio_balloon *vb = vdev->priv;
Signature · 1 line
1.5.6.5
PATCH 1/1 move virtblk_remove to .devexit.text
In reply to Uwe Kleine-KönigThe function virtblk_remove is used only wrapped by __devexit_p so define it using __devexit.
--- drivers/block/virtio_blk.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/block/virtio_blk.c +1 -1
@@ -330,7 +330,7 @@ out:return err; } -static void virtblk_remove (struct virtio_device *vdev) +static void __devexit virtblk_remove(struct virtio_device *vdev) {struct virtio_blk *vblk = vdev->priv;
Signature · 1 line
1.5.6.5
PATCH 1/1 move virtnet_remove to .devexit.text
In reply to Uwe Kleine-KönigThe function virtnet_remove is used only wrapped by __devexit_p so define it using __devexit.
--- drivers/net/virtio_net.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/virtio_net.c +1 -1
@@ -752,7 +752,7 @@ free:return err; } -static void virtnet_remove (struct virtio_device *vdev) +static void __devexit virtnet_remove(struct virtio_device *vdev) {struct virtnet_info *vi = vdev->priv;struct sk_buff *skb;
Signature · 1 line
1.5.6.5
PATCH 1/1 move virtrng_remove to .devexit.text
In reply to Uwe Kleine-KönigThe function virtrng_remove is used only wrapped by __devexit_p so define it using __devexit.
--- drivers/char/hw_random/virtio-rng.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/char/hw_random/virtio-rng.c +1 -1
@@ -108,7 +108,7 @@ static int virtrng_probe(struct virtio_device *vdev)return 0 ; } -static void virtrng_remove (struct virtio_device *vdev) +static void __devexit virtrng_remove(struct virtio_device *vdev) { vdev->config->reset (vdev);hwrng_unregister (&virtio_hwrng);
Signature · 1 line
1.5.6.5
Quoted 8 lines · Uwe Kleine-König
Hello,
I found several drivers that use
__devexit_pand__exit_pon functions that don't live in .devexit.text or .exit.text resp.The impact is either that these functions use memory without being used or that they don't link.
Quoted 6 lines
I send 24 patches as a reply to this mail. I choosed to move the functions into the respective function instead of using the right __{dev,}exit_p wrapper because it seems to me to have less impact.
I didn't made the effort to find out the right people to Cc: but I hope that Andrew takes care of that :-)
Did you check that this did not introduce any new Section mismatch warnings? We have seen several __exit annotated functions that was used from __init annotated code or even from normal code.
Thus the __exit annotation was wrong in these cases.
Sam
Quoted 13 lines · Sam Ravnborg
Quoted 12 lines · Uwe Kleine-König
Hello,
I found several drivers that use
__devexit_pand__exit_pon functions that don't live in .devexit.text or .exit.text resp.The impact is either that these functions use memory without being used or that they don't link.
I send 24 patches as a reply to this mail. I choosed to move the functions into the respective function instead of using the right __{dev,}exit_p wrapper because it seems to me to have less impact.
Quoted 7 lines
Quoted 2 lines
I didn't made the effort to find out the right people to Cc: but I hope that Andrew takes care of that :-)
Did you check that this did not introduce any new Section mismatch warnings? We have seen several
__exitannotated functions that was used from__initannotated code or even from normal code.
Thus the__exitannotation was wrong in these cases.
I wrote in the commit logs, that the functions are only used as argument to __{dev,}exit_p. There are no direct calls. (IIRC there was only one exception that I checked manually.)
I think the __{dev,}exit_p wrappers are only used to define remove callbacks, so there should be no harm.
Best regards and thanks for your feedback,
Uwe
Signature · 4 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Strasse 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Hello Sam,
Quoted 7 lines
Quoted 4 lines
Did you check that this did not introduce any new Section mismatch warnings? We have seen several
__exitannotated functions that was used from__initannotated code or even from normal code.
Thus the__exitannotation was wrong in these cases.I wrote in the commit logs, that the functions are only used as argument to __{dev,}exit_p. There are no direct calls. (IIRC there was only one exception that I checked manually.)
Actually the case I remembered here isn't part of the series.
Quoted 2 lines
I think the __{dev,}exit_p wrappers are only used to define remove callbacks, so there should be no harm.
In the meantime I checked this:
~/gsrc/linux-2.6$ git diff-tree -r linus/master expsec-master | cut -f 2 | xargs grep -h -E '__(dev)?exit_p' .remove = __devexit_p(s3c_adc_remove), .remove = __devexit_p(s3c_pwm_remove), .remove = __devexit_p(virtblk_remove), .remove = __devexit_p(virtrng_remove), .remove = __devexit_p(stli_pciremove) .remove = __devexit_p(hifn_remove), .remove = __devexit_p(mpc85xx_pci_err_remove), .remove = __devexit_p(mv64x60_pci_err_remove), .remove = __devexit_p(max7301_remove), .remove = __devexit_p(bbc_remove), .remove = __devexit_p(grover_remove), .remove = __exit_p(pxa_camera_remove), .remove = __devexit_p(asic3_remove), .remove = __devexit_p(ilo_remove), .remove = __exit_p(mxcnd_remove), .remove = __devexit_p(virtnet_remove), .remove = __devexit_p(atp870u_remove), .remove = __devexit_p(megaraid_detach_one), .remove = __devexit_p(stex_remove), .remove = __devexit_p(jsm_remove_one), .remove = __devexit_p(sc26xx_driver_remove), .remove = __devexit_p(spidev_remove), .remove = __devexit_p(vhci_hcd_remove), .remove = __devexit_p(virtballoon_remove),
So in the patched files __(dev)?exit_p is only used to fill struct members. Provided this is the only usage of the respective functions---and I checked that---it doesn't make sense that they don't live in .devexit.text (or .exit.text respectively).
Does it make sence for you, too?
Best regards
Uwe
Signature · 4 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Strasse 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Quoted 41 lines · Uwe Kleine-König
Hello Sam,
Quoted 7 lines
Quoted 4 lines
Did you check that this did not introduce any new Section mismatch warnings? We have seen several
__exitannotated functions that was used from__initannotated code or even from normal code.
Thus the__exitannotation was wrong in these cases.I wrote in the commit logs, that the functions are only used as argument to __{dev,}exit_p. There are no direct calls. (IIRC there was only one exception that I checked manually.)
Actually the case I remembered here isn't part of the series.
Quoted 2 lines
I think the __{dev,}exit_p wrappers are only used to define remove callbacks, so there should be no harm.
In the meantime I checked this:
~/gsrc/linux-2.6$ git diff-tree -r linus/master expsec-master | cut -f 2 | xargs grep -h -E '__(dev)?exit_p' .remove = __devexit_p(s3c_adc_remove), .remove = __devexit_p(s3c_pwm_remove), .remove = __devexit_p(virtblk_remove), .remove = __devexit_p(virtrng_remove), .remove = __devexit_p(stli_pciremove) .remove = __devexit_p(hifn_remove), .remove = __devexit_p(mpc85xx_pci_err_remove), .remove = __devexit_p(mv64x60_pci_err_remove), .remove = __devexit_p(max7301_remove), .remove = __devexit_p(bbc_remove), .remove = __devexit_p(grover_remove), .remove = __exit_p(pxa_camera_remove), .remove = __devexit_p(asic3_remove), .remove = __devexit_p(ilo_remove), .remove = __exit_p(mxcnd_remove), .remove = __devexit_p(virtnet_remove), .remove = __devexit_p(atp870u_remove), .remove = __devexit_p(megaraid_detach_one), .remove = __devexit_p(stex_remove), .remove = __devexit_p(jsm_remove_one), .remove = __devexit_p(sc26xx_driver_remove), .remove = __devexit_p(spidev_remove), .remove = __devexit_p(vhci_hcd_remove), .remove = __devexit_p(virtballoon_remove),
Quoted 6 lines
So in the patched files __(dev)?exit_p is only used to fill struct members. Provided this is the only usage of the respective functions---and I checked that---it doesn't make sense that they don't live in .devexit.text (or .exit.text respectively).
Does it make sence for you, too?
Yes - if I understood you correct.
You already convinced me with your first mail that you had checked that the functions was not used for anything else then the exit path.
Sam
Hello Sam,
Quoted 47 lines · Sam Ravnborg
Quoted 46 lines · Uwe Kleine-König
Hello Sam,
Quoted 7 lines
Quoted 4 lines
Did you check that this did not introduce any new Section mismatch warnings? We have seen several
__exitannotated functions that was used from__initannotated code or even from normal code.
Thus the__exitannotation was wrong in these cases.I wrote in the commit logs, that the functions are only used as argument to __{dev,}exit_p. There are no direct calls. (IIRC there was only one exception that I checked manually.)
Actually the case I remembered here isn't part of the series.
Quoted 2 lines
I think the __{dev,}exit_p wrappers are only used to define remove callbacks, so there should be no harm.
In the meantime I checked this:
~/gsrc/linux-2.6$ git diff-tree -r linus/master expsec-master | cut -f 2 | xargs grep -h -E '__(dev)?exit_p' .remove = __devexit_p(s3c_adc_remove), .remove = __devexit_p(s3c_pwm_remove), .remove = __devexit_p(virtblk_remove), .remove = __devexit_p(virtrng_remove), .remove = __devexit_p(stli_pciremove) .remove = __devexit_p(hifn_remove), .remove = __devexit_p(mpc85xx_pci_err_remove), .remove = __devexit_p(mv64x60_pci_err_remove), .remove = __devexit_p(max7301_remove), .remove = __devexit_p(bbc_remove), .remove = __devexit_p(grover_remove), .remove = __exit_p(pxa_camera_remove), .remove = __devexit_p(asic3_remove), .remove = __devexit_p(ilo_remove), .remove = __exit_p(mxcnd_remove), .remove = __devexit_p(virtnet_remove), .remove = __devexit_p(atp870u_remove), .remove = __devexit_p(megaraid_detach_one), .remove = __devexit_p(stex_remove), .remove = __devexit_p(jsm_remove_one), .remove = __devexit_p(sc26xx_driver_remove), .remove = __devexit_p(spidev_remove), .remove = __devexit_p(vhci_hcd_remove), .remove = __devexit_p(virtballoon_remove),So in the patched files __(dev)?exit_p is only used to fill struct members. Provided this is the only usage of the respective functions---and I checked that---it doesn't make sense that they don't live in .devexit.text (or .exit.text respectively).
Quoted 6 lines
Quoted 1 line
Does it make sence for you, too?
Yes - if I understood you correct.
You already convinced me with your first mail that you had checked that the functions was not used for anything else then the exit path.
So I can interpret this as a general Acked-by:?
Best regards and thanks,
Uwe
Signature · 4 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Strasse 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
Quoted 50 lines · Uwe Kleine-König
Hello Sam,
Quoted 47 lines · Sam Ravnborg
Quoted 46 lines · Uwe Kleine-König
Hello Sam,
Quoted 7 lines
Quoted 4 lines
Did you check that this did not introduce any new Section mismatch warnings? We have seen several
__exitannotated functions that was used from__initannotated code or even from normal code.
Thus the__exitannotation was wrong in these cases.I wrote in the commit logs, that the functions are only used as argument to __{dev,}exit_p. There are no direct calls. (IIRC there was only one exception that I checked manually.)
Actually the case I remembered here isn't part of the series.
Quoted 2 lines
I think the __{dev,}exit_p wrappers are only used to define remove callbacks, so there should be no harm.
In the meantime I checked this:
~/gsrc/linux-2.6$ git diff-tree -r linus/master expsec-master | cut -f 2 | xargs grep -h -E '__(dev)?exit_p' .remove = __devexit_p(s3c_adc_remove), .remove = __devexit_p(s3c_pwm_remove), .remove = __devexit_p(virtblk_remove), .remove = __devexit_p(virtrng_remove), .remove = __devexit_p(stli_pciremove) .remove = __devexit_p(hifn_remove), .remove = __devexit_p(mpc85xx_pci_err_remove), .remove = __devexit_p(mv64x60_pci_err_remove), .remove = __devexit_p(max7301_remove), .remove = __devexit_p(bbc_remove), .remove = __devexit_p(grover_remove), .remove = __exit_p(pxa_camera_remove), .remove = __devexit_p(asic3_remove), .remove = __devexit_p(ilo_remove), .remove = __exit_p(mxcnd_remove), .remove = __devexit_p(virtnet_remove), .remove = __devexit_p(atp870u_remove), .remove = __devexit_p(megaraid_detach_one), .remove = __devexit_p(stex_remove), .remove = __devexit_p(jsm_remove_one), .remove = __devexit_p(sc26xx_driver_remove), .remove = __devexit_p(spidev_remove), .remove = __devexit_p(vhci_hcd_remove), .remove = __devexit_p(virtballoon_remove),So in the patched files __(dev)?exit_p is only used to fill struct members. Provided this is the only usage of the respective functions---and I checked that---it doesn't make sense that they don't live in .devexit.text (or .exit.text respectively).
Quoted 7 lines
Quoted 6 lines
Quoted 1 line
Does it make sence for you, too?
Yes - if I understood you correct.
You already convinced me with your first mail that you had checked that the functions was not used for anything else then the exit path.
So I can interpret this as a general Acked-by:?
Yes.
Sam
Hello Sam,
Quoted 5 lines
Quoted 3 lines
Quoted 2 lines
You already convinced me with your first mail that you had checked that the functions was not used for anything else then the exit path.
So I can interpret this as a general Acked-by:?
Yes.
The complete (topgit-controlled) series is now available at
git://git.pengutronix.de/git/ukl/linux-2.6.git expsec-master
with your Acked-by.
Up to now I didn't get any feedback apart from your's. Maybe I need to find the right people to Cc: myself. :-|
Best regards
Uwe
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |