Skip to contentSkip to conversation

hsmmc: card detect irq bugfix

PATCH New David Brownell 1 participant 1 message Jan 13, 2009

Subsystems (2)
MMC, SD and SDIO OMAP hs MMC support
lore
Share & tools
lore

David Brownell

author
#0 lore raw

PATCH 1/1 hsmmc: card detect irq bugfix

From: David Brownell <[email protected]>

Work around lockdep issue when card detect IRQ handlers run in thread context ... it forces IRQF_DISABLED, which prevents all access to twl4030 card detect signals.

Signed-off-by David Brownell <[email protected]>

---
With so many OMAP3 boards having only one MMC/SD slot, used for rootfs by developers, it's no surprise this hasn't been noticed before!

 drivers/mmc/host/omap_hsmmc.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/mmc/host/omap_hsmmc.c +3 -1
@@ -568,6 +568,9 @@ static void mmc_omap_detect(struct work_
 {
 	struct mmc_omap_host *host = container_of(work, struct mmc_omap_host,
 						mmc_carddetect_work);
+	struct omap_mmc_slot_data *slot = &mmc_slot(host);
+
+	host->carddetect = slot->card_detect(slot->card_detect_irq);
 
 	sysfs_notify(&host->mmc->class_dev.kobj, NULL, "cover_switch");
 	mmc_omap_fclk_state(host, ON);

@@ -591,7 +594,6 @@ static irqreturn_t omap_mmc_cd_handler(i
 {
 	struct mmc_omap_host *host = (struct mmc_omap_host *)dev_id;
 
-	host->carddetect = mmc_slot(host).card_detect(irq);
 	schedule_work(&host->mmc_carddetect_work);
 
 	return IRQ_HANDLED;