Skip to contentSkip to conversation

Remove a duplicated option of RCU_CPU_STALL_DETECTOR

PATCH Jiri Kosina 2 participants 3 messages Jan 13, 2009 – Jan 15, 2009 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 22 lines · Kaibin Li

There is a duplicated option of "Check for stalled CPUs delaying RCU grace periods" in Kernel hacking.

---
 lib/Kconfig.debug |   13 -------------
 1 files changed, 0 insertions(+), 13 deletions(-)
lib/Kconfig.debug +0 -6
index 4c9ae60..e770e85 100644
@@ -633,19 +633,6 @@ config RCU_TORTURE_TEST_RUNNABLE
 
 config RCU_CPU_STALL_DETECTOR
    bool "Check for stalled CPUs delaying RCU grace periods"
-   depends on CLASSIC_RCU
-   default n
-   help
-     This option causes RCU to printk information on which
-     CPUs are delaying the current grace period, but only when
-     the grace period extends for excessive time periods.

lib/Kconfig.debug config RCU_TORTURE_TEST_RUNNABLE · line 638

Quoted 10 lines
lib/Kconfig.debug +0 -7
-
-     Say Y if you want RCU to perform such checks.
-
-     Say N if you are unsure.
-
-config RCU_CPU_STALL_DETECTOR
-   bool "Check for stalled CPUs delaying RCU grace periods"
    depends on CLASSIC_RCU || TREE_RCU
    default n
    help

The RCU_CPU_STALL_DETECTOR indeed is duplicate, but the entries themselves are not identical, as they have different dependencies.

Paul -- does Kaibin's patch remove the correct one? If so, I can take it through trivial tree.

Thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs
Reviewed-by
#2 lore raw
Quoted 4 lines · Jiri Kosina
Quoted 2 lines · Kaibin Li

There is a duplicated option of "Check for stalled CPUs delaying RCU grace periods" in Kernel hacking.

Quoted 33 lines
Quoted 19 lines
---
 lib/Kconfig.debug |   13 -------------
 1 files changed, 0 insertions(+), 13 deletions(-)
lib/Kconfig.debug +0 -6
index 4c9ae60..e770e85 100644
@@ -633,19 +633,6 @@ config RCU_TORTURE_TEST_RUNNABLE
 
 config RCU_CPU_STALL_DETECTOR
    bool "Check for stalled CPUs delaying RCU grace periods"
-   depends on CLASSIC_RCU
-   default n
-   help
-     This option causes RCU to printk information on which
-     CPUs are delaying the current grace period, but only when
-     the grace period extends for excessive time periods.

lib/Kconfig.debug config RCU_TORTURE_TEST_RUNNABLE · line 638

Quoted 10 lines
lib/Kconfig.debug +0 -7
-
-     Say Y if you want RCU to perform such checks.
-
-     Say N if you are unsure.
-
-config RCU_CPU_STALL_DETECTOR
-   bool "Check for stalled CPUs delaying RCU grace periods"
    depends on CLASSIC_RCU || TREE_RCU
    default n
    help

The RCU_CPU_STALL_DETECTOR indeed is duplicate, but the entries themselves are not identical, as they have different dependencies.

Quoted 2 lines

Paul -- does Kaibin's patch remove the correct one? If so, I can take it through trivial tree.

Indeed it is: http://lkml.org/lkml/2008/12/23/167 ;-)

CCing Ingo in case he has it queued up.

Thanx, Paul

#3 lore raw
Quoted 3 lines · Paul E. McKenney
Quoted 2 lines
Quoted 2 lines

There is a duplicated option of "Check for stalled CPUs delaying RCU grace periods" in Kernel hacking.

Thanks.

Quoted 33 lines
Quoted 33 lines
Quoted 19 lines
---
 lib/Kconfig.debug |   13 -------------
 1 files changed, 0 insertions(+), 13 deletions(-)
lib/Kconfig.debug +0 -6
index 4c9ae60..e770e85 100644
@@ -633,19 +633,6 @@ config RCU_TORTURE_TEST_RUNNABLE
 
 config RCU_CPU_STALL_DETECTOR
    bool "Check for stalled CPUs delaying RCU grace periods"
-   depends on CLASSIC_RCU
-   default n
-   help
-     This option causes RCU to printk information on which
-     CPUs are delaying the current grace period, but only when
-     the grace period extends for excessive time periods.

lib/Kconfig.debug config RCU_TORTURE_TEST_RUNNABLE · line 638

Quoted 10 lines
lib/Kconfig.debug +0 -7
-
-     Say Y if you want RCU to perform such checks.
-
-     Say N if you are unsure.
-
-config RCU_CPU_STALL_DETECTOR
-   bool "Check for stalled CPUs delaying RCU grace periods"
    depends on CLASSIC_RCU || TREE_RCU
    default n
    help

The RCU_CPU_STALL_DETECTOR indeed is duplicate, but the entries themselves are not identical, as they have different dependencies.

Quoted 4 lines
Quoted 2 lines

Paul -- does Kaibin's patch remove the correct one? If so, I can take it through trivial tree.

Indeed it is: http://lkml.org/lkml/2008/12/23/167 ;-) CCing Ingo in case he has it queued up.

It doesn't seem to be present in today's -next, so I have queued up in trivial tree.

thanks,

Signature · 2 lines
Jiri Kosina
SUSE Labs