drivers/net/irda/irda-usb.c: fix buffer overflow
Subsystems (2)
PATCH 1/1 drivers/net/irda/irda-usb.c: fix buffer overflow
From: Jos-Vicente Gilabert <[email protected]>
Taken from http://bugzilla.kernel.org/show_bug.cgi?id=12397
We're doing an sprintf of an 11-char string into an 11-char buffer. Whoops. It breaks firmware uploading.
Reported-by Jos-Vicente Gilabert <[email protected]>
Cc David S. Miller <[email protected]>
Cc Samuel Ortiz <[email protected]>
Cc "John W. Linville" <[email protected]>
Cc <[email protected]>
Signed-off-by Andrew Morton <[email protected]>
---
drivers/net/irda/irda-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/irda/irda-usb.c renamed from drivers/net/irda/irda-usb.c~drivers-net-irda-irda-usbc-fix-buffer-overflow +1 -1
@@ -1073,7 +1073,7 @@ static int stir421x_patch_device(struct {unsigned int i;int ret; -char stir421x_fw_name[11 ]; +char stir421x_fw_name[12 ];const struct firmware *fw;const unsigned char *fw_version_ptr;/* pointer to version string */ unsigned long fw_version =0 ;
_
David Miller
maintainerFrom: [email protected]
Date: Tue, 13 Jan 2009 13:30:54 -0800
Quoted 9 lines
From: Jos-Vicente Gilabert <[email protected]>
Taken from http://bugzilla.kernel.org/show_bug.cgi?id=12397
We're doing an sprintf of an 11-char string into an 11-char buffer. Whoops. It breaks firmware uploading.
Reported-by Jos-Vicente Gilabert <[email protected]>Signed-off-by Andrew Morton <[email protected]>
Patch applied, thanks.