rcu: add __cpuinit to rcu_init_percpu_data()
PATCH 1/1 rcu: add __cpuinit to rcu_init_percpu_data()
Impact: rcu_init_percpu_data() is not use after boot when !CONFIG_HOTPLUG_CPU
add __cpuinit to rcu_init_percpu_data(), and this function's text will be discarded after boot when !CONFIG_HOTPLUG_CPU.
Signed-off-by Lai Jiangshan <[email protected]>
---
kernel/rcuclassic.c +1 -1
@@ -716,7 +716,7 @@ void rcu_check_callbacks(int cpu, int user)raise_rcu_softirq (); } -static void rcu_init_percpu_data (int cpu,struct rcu_ctrlblk *rcp, +static void __cpuinit rcu_init_percpu_data (int cpu,struct rcu_ctrlblk *rcp,struct rcu_data *rdp) {unsigned long flags;
kernel/rcutree.c +1 -1
@@ -1314,7 +1314,7 @@ int rcu_needs_cpu(int cpu)* access due to the fact that this CPU cannot possibly have any RCU * callbacks in flight yet. */ -static void +static void __cpuinit rcu_init_percpu_data (int cpu,struct rcu_state *rsp) {unsigned long flags;
Ingo Molnar
AppliedQuoted 7 lines · Lai Jiangshan
Impact:
rcu_init_percpu_data()is not use after boot when !CONFIG_HOTPLUG_CPUadd
__cpuinittorcu_init_percpu_data(), and this function's text will be discarded after boot when !CONFIG_HOTPLUG_CPU.Signed-off-by Lai Jiangshan <[email protected]>
applied to tip/core/urgent, thanks!
Ingo
Quoted 5 lines · Lai Jiangshan
Impact:
rcu_init_percpu_data()is not use after boot when !CONFIG_HOTPLUG_CPUadd
__cpuinittorcu_init_percpu_data(), and this function's text will be discarded after boot when !CONFIG_HOTPLUG_CPU.
Good catch!!!
Acked-by Paul E. McKenney <[email protected]>
Quoted 31 lines
Signed-off-by Lai Jiangshan <[email protected]>---
kernel/rcuclassic.c +1
-1@@ -716,7 +716,7 @@ void rcu_check_callbacks(int cpu, int user)raise_rcu_softirq (); } -static void rcu_init_percpu_data (int cpu,struct rcu_ctrlblk *rcp, +static void __cpuinit rcu_init_percpu_data (int cpu,struct rcu_ctrlblk *rcp,struct rcu_data *rdp) {unsigned long flags;kernel/rcutree.c +1
-1@@ -1314,7 +1314,7 @@ int rcu_needs_cpu(int cpu)* access due to the fact that this CPU cannot possibly have any RCU * callbacks in flight yet. */ -static void +static void __cpuinit rcu_init_percpu_data (int cpu,struct rcu_state *rsp) {unsigned long flags;