Skip to contentSkip to conversation

CONFIG_MFD_PCF50633=m breaks the kernel build

DISCUSSION Jean Delvare 3 participants 7 messages Jan 15, 2009 Multifunction devices (MFD)

lore
Share & tools
lore
#0 lore raw

Hi Balaji,

Building kernel 2.6.29-rc1-git4 on x86_64 with CONFIG_MFD_PCF50633=m fails at linking time with:

ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined!
ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined!

Signature · 1 line
Jean Delvare
#1 lore raw
Quoted 7 lines · Jean Delvare

Hi Balaji,

Building kernel 2.6.29-rc1-git4 on x86_64 with CONFIG_MFD_PCF50633=m fails at linking time with:

ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined!
ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined!

Yes, I've seen this. The fix is waiting on linux-mfd to be pulled anytime soon.

Thanks,
Balaji

#2 lore raw
Quoted 11 lines · Balaji Rao
Quoted 7 lines · Jean Delvare

Hi Balaji,

Building kernel 2.6.29-rc1-git4 on x86_64 with CONFIG_MFD_PCF50633=m fails at linking time with:

ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined!
ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined!

Yes, I've seen this. The fix is waiting on linux-mfd to be pulled anytime soon.

Where is linux-mfd? And what is it, a git tree, a mailing list? I couldn't find any reference.

Can you please send me the patch now, so that I can fix my build locally right now?

Thanks,

Signature · 1 line
Jean Delvare
#3 lore raw
Quoted 7 lines · Jean Delvare
Quoted 6 lines · Balaji Rao
Quoted 5 lines · Jean Delvare

Hi Balaji,

Building kernel 2.6.29-rc1-git4 on x86_64 with CONFIG_MFD_PCF50633=m fails at linking time with:

Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined!
ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined!

Yes, I've seen this. The fix is waiting on linux-mfd to be pulled anytime soon.

Where is linux-mfd? And what is it, a git tree, a mailing list? I couldn't find any reference.

It's a git tree at http://git.o-hand.com/cgit.cgi/linux-mfd/

Quoted 4 lines

Can you please send me the patch now, so that I can fix my build locally right now?

pcf50633: Remove references to non-exported functions

Remove references to set_irq_type and handle_level_irq which are not exported to modules.

drivers/mfd/pcf50633-core.c +0 -1
index 24508e2..ea9488e 100644
@@ -626,7 +626,6 @@ static int __devinit pcf50633_probe(struct i2c_client *client,
 	}
 
 	if (client->irq) {
-		set_irq_handler(client->irq, handle_level_irq);
 		ret = request_irq(client->irq, pcf50633_irq,
 				IRQF_TRIGGER_LOW, "pcf50633", pcf);
 
#4 lore raw
Quoted 11 lines · Balaji Rao
Quoted 10 lines · Jean Delvare
Quoted 9 lines · Balaji Rao
Quoted 7 lines · Jean Delvare

Hi Balaji,

Building kernel 2.6.29-rc1-git4 on x86_64 with CONFIG_MFD_PCF50633=m fails at linking time with:

ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined!
ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined!

Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

Yes, I've seen this. The fix is waiting on linux-mfd to be pulled anytime soon.

Where is linux-mfd? And what is it, a git tree, a mailing list? I couldn't find any reference.

It's a git tree at http://git.o-hand.com/cgit.cgi/linux-mfd/

Would you be so kind and write a patch adding this information to MAINTAINERS? And get it upstream, so that developers know where it is.

Quoted 15 lines
Quoted 2 lines

Can you please send me the patch now, so that I can fix my build locally right now?

pcf50633: Remove references to non-exported functions

Remove references to set_irq_type and handle_level_irq which are not exported to modules.

drivers/mfd/pcf50633-core.c +0 -0
index 24508e2..ea9488e 100644

drivers/mfd/pcf50633-core.c static int __devinit pcf50633_probe(struct i2c_client *client, · line 631

Quoted 7 lines
drivers/mfd/pcf50633-core.c +0 -1
@@ -626,7 +626,6 @@ static int __devinit pcf50633_probe(struct i2c_client *client,
 	}
 
 	if (client->irq) {
-		set_irq_handler(client->irq, handle_level_irq);
 		ret = request_irq(client->irq, pcf50633_irq,
 				IRQF_TRIGGER_LOW, "pcf50633", pcf);
 

Great, thanks! Now I can go on with my work.

Signature · 1 line
Jean Delvare
#5 lore raw
Quoted 15 lines · Jean Delvare
Quoted 14 lines · Balaji Rao
Quoted 13 lines · Jean Delvare
Quoted 11 lines · Balaji Rao
Quoted 7 lines · Jean Delvare

Hi Balaji,

Building kernel 2.6.29-rc1-git4 on x86_64 with CONFIG_MFD_PCF50633=m fails at linking time with:

ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined!
ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined!

Yes, I've seen this. The fix is waiting on linux-mfd to be pulled anytime soon.

Quoted 8 lines
Quoted 4 lines
Quoted 2 lines

Where is linux-mfd? And what is it, a git tree, a mailing list? I couldn't find any reference.

It's a git tree at http://git.o-hand.com/cgit.cgi/linux-mfd/

Would you be so kind and write a patch adding this information to MAINTAINERS? And get it upstream, so that developers know where it is.

Yes, that's a good idea. Will do.

- Balaji

#6 lore raw
In reply to Jean Delvare
Quoted 7 lines · Jean Delvare
Quoted 6 lines · Balaji Rao
Quoted 5 lines · Jean Delvare

Hi Balaji,

Building kernel 2.6.29-rc1-git4 on x86_64 with CONFIG_MFD_PCF50633=m fails at linking time with:

Quoted 7 lines
Quoted 4 lines
Quoted 2 lines

ERROR: "__set_irq_handler" [drivers/mfd/pcf50633-core.ko] undefined!
ERROR: "handle_level_irq" [drivers/mfd/pcf50633-core.ko] undefined!

Yes, I've seen this. The fix is waiting on linux-mfd to be pulled anytime soon.

Where is linux-mfd? And what is it, a git tree, a mailing list? I couldn't find any reference.

git://git.o-hand.com/linux-mfd

Quoted 2 lines

Can you please send me the patch now, so that I can fix my build locally right now?

The related commit:
http://git.o-hand.com/cgit.cgi/linux-mfd/commit/?h=for-linus&id=9bf04a9690b3c961150ac508d343c875f0d641ad

Adrian