Skip to contentSkip to conversation

mfd/pcf50633: Terminate i2c_device_id list

PATCH In review Jean Delvare 2 participants 2 messages Jan 15, 2009 Multifunction devices (MFD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mfd/pcf50633: Terminate i2c_device_id list

The i2c_device_id list is supposed to be zero-terminated.

Cc Balaji Rao <[email protected]>
Cc Samuel Ortiz <[email protected]>

---
As a side note, I am currious why you set the driver_data to 0x73 and then never use it...

 drivers/mfd/pcf50633-core.c |    1 +
 1 file changed, 1 insertion(+)
drivers/mfd/pcf50633-core.c +1 -0
@@ -678,6 +678,7 @@ static int __devexit pcf50633_remove(str
 
 static struct i2c_device_id pcf50633_id_table[] = {
 	{"pcf50633", 0x73},
+	{/* end of list */}
 };
 
 static struct i2c_driver pcf50633_driver = {
Signature · 1 line
Jean Delvare
#1 lore raw
Quoted 9 lines · Jean Delvare

The i2c_device_id list is supposed to be zero-terminated.

Cc Balaji Rao <[email protected]>
Cc Samuel Ortiz <[email protected]>

---
As a side note, I am currious why you set the driver_data to 0x73 and then never use it...

Hum, now I don't recall why I had then put it. Anyway, I'll send a patch to get rid of it.

Thanks for your patch.

- Balaji