Skip to contentSkip to conversation

iwl3945: fix some warnings when compiled without debug

PATCH Superseded Helmut Schaa 2 participants 3 messages Jan 19, 2009

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 iwl3945: fix some warnings when compiled without debug

=46ix the following warnings if compiled without CONFIG_IWLWIFI_DEBUG.

drivers/net/wireless/iwlwifi/iwl3945-base.c: In function =E2=80=98iwl39= 45_rx_reply_add_sta=E2=80=99:
drivers/net/wireless/iwlwifi/iwl3945-base.c:2748: warning: unused varia= ble =E2=80=98pkt=E2=80=99 drivers/net/wireless/iwlwifi/iwl3945-base.c: In function =E2=80=98iwl39= 45_rx_scan_results_notif=E2=80=99:
drivers/net/wireless/iwlwifi/iwl3945-base.c:2903: warning: unused varia= ble =E2=80=98notif=E2=80=99 drivers/net/wireless/iwlwifi/iwl3945-base.c: In function =E2=80=98iwl39= 45_rx_scan_complete_notif=E2=80=99:
drivers/net/wireless/iwlwifi/iwl3945-base.c:2928: warning: unused varia= ble =E2=80=98scan_notif=E2=80=99

---

drivers/net/= renamed from drivers/net/wireless/iwlwifi/iwl3945-base.c +0 -0

wireless/iwlwifi/iwl3945-base.c
index b437cac..15d36d8 100644

drivers/net/wireless/iwlwifi/iwl3945-base.c +0 -0
@@ -2744,7 +2744,9 @@ static void iwl3945_rx_reply_alive(struct iwl_pri=

v *priv,
static void iwl3945_rx_reply_add_sta(struct iwl_priv *priv,
struct iwl_rx_mem_buffer *rxb)
{
+ #ifdef CONFIG_IWLWIFI_DEBUG
struct iwl_rx_packet *pkt =3D (void *)rxb->skb->data;
+ #endif=20
=20
IWL_DEBUG_RX("Received REPLY_ADD_STA: 0x%02X\n", pkt->u.status); return;
@@ -2898,9 +2900,11 @@ static void iwl3945_rx_scan_start_notif(struct i= wl_priv *priv,
static void iwl3945_rx_scan_results_notif(struct iwl_priv *priv,
struct iwl_rx_mem_buffer *rxb)
{
+ #ifdef CONFIG_IWLWIFI_DEBUG
struct iwl_rx_packet *pkt =3D (void *)rxb->skb->data; struct iwl_scanresults_notification *notif =3D
(struct iwl_scanresults_notification *)pkt->u.raw;
+ #endif
=20
IWL_DEBUG_SCAN("Scan ch.res: "
"%d [802.11%s] "
@@ -2923,8 +2927,10 @@ static void iwl3945_rx_scan_results_notif(struct=
iwl_priv *priv,
static void iwl3945_rx_scan_complete_notif(struct iwl_priv *priv,
struct iwl_rx_mem_buffer *rxb)
{
+ #ifdef CONFIG_IWLWIFI_DEBUG
struct iwl_rx_packet *pkt =3D (void *)rxb->skb->data; struct iwl_scancomplete_notification *scan_notif =3D (void *)pkt->u.r=
aw;
+ #endif
=20
IWL_DEBUG_SCAN("Scan complete: %d channels (TSF 0x%08X:%08X) - %d\n",
scan_notif->scanned_channels,
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer
#1 lore raw
Quoted 16 lines · Helmut Schaa

Fix the following warnings if compiled without CONFIG_IWLWIFI_DEBUG.

drivers/net/wireless/iwlwifi/iwl3945-base.c: In function ‘iwl3945_rx_reply_add_sta’:
drivers/net/wireless/iwlwifi/iwl3945-base.c:2748: warning: unused variable ‘pkt’ drivers/net/wireless/iwlwifi/iwl3945-base.c: In function ‘iwl3945_rx_scan_results_notif’:
drivers/net/wireless/iwlwifi/iwl3945-base.c:2903: warning: unused variable ‘notif’ drivers/net/wireless/iwlwifi/iwl3945-base.c: In function ‘iwl3945_rx_scan_complete_notif’:
drivers/net/wireless/iwlwifi/iwl3945-base.c:2928: warning: unused variable ‘scan_notif’

---

drivers/net/wireless/iwlwifi/iwl3945-base.c +0 -0
index b437cac..15d36d8 100644

drivers/net/wireless/iwlwifi/iwl3945-base.c static void iwl3945_rx_reply_alive(struct iwl_priv *priv, · line 2749

Quoted 6 lines
drivers/net/wireless/iwlwifi/iwl3945-base.c +2 -0
@@ -2744,7 +2744,9 @@ static void iwl3945_rx_reply_alive(struct iwl_priv *priv,
 static void iwl3945_rx_reply_add_sta(struct iwl_priv *priv,
 				 struct iwl_rx_mem_buffer *rxb)
 {
+	#ifdef CONFIG_IWLWIFI_DEBUG
 	struct iwl_rx_packet *pkt = (void *)rxb->skb->data;
+	#endif 

I for one would definitely prefer you didn't indent preprocessor statements, but I don't care all that much about iwl3945.

johannes

#2 lore raw

Am Montag, 19. Januar 2009 schrieb Johannes Berg:

Quoted 2 lines · Helmut Schaa
Quoted 1 line

Fix the following warnings if compiled without CONFIG_IWLWIFI_DEBUG=

=2E

Quoted 2 lines
Quoted 2 lines

=20
drivers/net/wireless/iwlwifi/iwl3945-base.c: In function =E2=80=98i=

wl3945_rx_reply_add_sta=E2=80=99:

Quoted 1 line
Quoted 1 line

drivers/net/wireless/iwlwifi/iwl3945-base.c:2748: warning: unused v=

ariable =E2=80=98pkt=E2=80=99

Quoted 1 line
Quoted 1 line

drivers/net/wireless/iwlwifi/iwl3945-base.c: In function =E2=80=98i=

wl3945_rx_scan_results_notif=E2=80=99:

Quoted 1 line
Quoted 1 line

drivers/net/wireless/iwlwifi/iwl3945-base.c:2903: warning: unused v=

ariable =E2=80=98notif=E2=80=99

Quoted 1 line
Quoted 1 line

drivers/net/wireless/iwlwifi/iwl3945-base.c: In function =E2=80=98i=

wl3945_rx_scan_complete_notif=E2=80=99:

Quoted 1 line
Quoted 1 line

drivers/net/wireless/iwlwifi/iwl3945-base.c:2928: warning: unused v=

ariable =E2=80=98scan_notif=E2=80=99

Quoted 4 lines

drivers/=

Quoted 4 lines

=20

---

drivers/= renamed from drivers/net/wireless/iwlwifi/iwl3945-base.c +0 -0

net/wireless/iwlwifi/iwl3945-base.c

Quoted 4 lines

drivers/net/wireless/iwlwifi/iwl3945-base.c static void iwl3945_rx_reply_alive(struct iwl=

Quoted 4 lines

index b437cac..15d36d8 100644

drivers/net/wireless/iwlwifi/iwl3945-base.c +0 -0
@@ -2744,7 +2744,9 @@ static void iwl3945_rx_reply_alive(struct iwl=

_priv *priv,

Quoted 9 lines

drivers/net/wireless/iwlwifi/iwl3945-base.c static void iwl3945_rx_reply_alive(struct iwl= · line 2749

Quoted 6 lines
drivers/net/wireless/iwlwifi/iwl3945-base.c +2 -0
 static void iwl3945_rx_reply_add_sta(struct iwl_priv *priv,
 				 struct iwl_rx_mem_buffer *rxb)
 {
+	#ifdef CONFIG_IWLWIFI_DEBUG
 	struct iwl_rx_packet *pkt =3D (void *)rxb->skb->data;
+	#endif=20

=20
I for one would definitely prefer you didn't indent preprocessor statements, but I don't care all that much about iwl3945.

Indeed. My fault. I'll resend this one.

Thanks,
Helmut
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html