Skip to contentSkip to conversation

p54: add missing break in eeprom parser

PATCH New Chr 1 participant 1 message Jan 19, 2009 Networking drivers (wireless)

lore
Share & tools
lore

Chr

author
#0 lore raw

PATCH 1/2 p54: add missing break in eeprom parser

This patch fixes a obvious memory leak in the eeprom parser.

---
John,

can you please add this patch and "p54: more cryptographic accelerator fixes" to wireless-2.6 as well?
---

drivers/net/wireless/p54/p54common.c +2 -2
index 6203105..2a515ef 100644
@@ -545,8 +545,8 @@ int p54_parse_eeprom(struct ieee80211_hw *dev, void *eeprom, int len)
 			}
 			if (err)
 				goto err;
-
-		}
+			}
+			break;
 		case PDR_PRISM_ZIF_TX_IQ_CALIBRATION:
 			priv->iq_autocal = kmalloc(data_len, GFP_KERNEL);
 			if (!priv->iq_autocal) {