Skip to contentSkip to conversation

bnx2x: remove a few trivial macros

PATCH In review Harvey Harrison 3 participants 5 messages Jan 21, 2009 – Jan 22, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/9 bnx2x: remove a few trivial macros

---
Eilon, after this series, sparse with endian-checking at least gets through a compile without hitting too many errors, patch 9 is a functional change and may have exposed an endian bug in the driver....but I had to get through the other 8 to see it ;-)

patches 1-8 shouldn't change any behavior...if it does it wasn't intentional.

 drivers/net/bnx2x.h      |    4 ---
 drivers/net/bnx2x_main.c |   62 +++++++++++++++++++++++-----------------------
 2 files changed, 31 insertions(+), 35 deletions(-)
drivers/net/bnx2x.h +0 -4
index 15a5cf0..7bda49d 100644
@@ -228,10 +228,6 @@ struct bnx2x_fastpath {
 	u8			index;	/* number in fp array */
 	u8			cl_id;	/* eth client id */
 	u8			sb_id;	/* status block number in HW */
-#define FP_IDX(fp)			(fp->index)
-#define FP_CL_ID(fp)			(fp->cl_id)
-#define BP_CL_ID(bp)			(bp->fp[0].cl_id)
-#define FP_SB_ID(fp)			(fp->sb_id)
 #define CNIC_SB_ID			0
 
 	u16			tx_pkt_prod;
drivers/net/bnx2x_main.c +31 -31

220 lines not on this page · raw message

Signature · 1 line
1.6.1.249.g455e5
#1 lore raw
Quoted 7 lines · Harvey Harrison

---
Eilon, after this series, sparse with endian-checking at least gets through a compile without hitting too many errors, patch 9 is a functional change and may have exposed an endian bug in the driver....but I had to get through the other 8 to see it ;-)

Wooh!!! Harvey - thanks for all the hard work!

I will review it carefully and start regression tests on few different platforms to verify this fix. Stay tuned.

Thanks!
Eilon

maintainer
#2 lore raw

From: "Eilon Greenstein" <[email protected]>
Date: Wed, 21 Jan 2009 09:14:53 +0200

Quoted 8 lines · Harvey Harrison
Quoted 7 lines

---
Eilon, after this series, sparse with endian-checking at least gets through a compile without hitting too many errors, patch 9 is a functional change and may have exposed an endian bug in the driver....but I had to get through the other 8 to see it ;-)

Quoted 4 lines

Wooh!!! Harvey - thanks for all the hard work!

I will review it carefully and start regression tests on few different platforms to verify this fix. Stay tuned.

Thanks Eilon, once you've validated these changes let me know so I can add them to net-next-2.6

#3 lore raw
Quoted 11 lines · David Miller

From: "Eilon Greenstein" <[email protected]>
Date: Wed, 21 Jan 2009 09:14:53 +0200

Quoted 8 lines · Harvey Harrison
Quoted 7 lines

---
Eilon, after this series, sparse with endian-checking at least gets through a compile without hitting too many errors, patch 9 is a functional change and may have exposed an endian bug in the driver....but I had to get through the other 8 to see it ;-)

Quoted 8 lines
Quoted 4 lines

Wooh!!! Harvey - thanks for all the hard work!

I will review it carefully and start regression tests on few different platforms to verify this fix. Stay tuned.

Thanks Eilon, once you've validated these changes let me know so I can add them to net-next-2.6

Besides the eeprom changes that broke a utility that uses it, this patch is working just fine. I have few cosmetic issues with le_to_cpu for zero (which I plan to remove) and I'm not sure if replacing swab with cpu_to_le on top of be_to_cpu is the way to go - I hope to get some comments on this one.

Harvey - I truly appreciate your work. I will pack it and resend it after receiving some comments.

Thanks again,
Eilon

Acked-by on v1 1/9
#4 lore raw
In reply to Harvey Harrison
Quoted 7 lines · Harvey Harrison

---
Eilon, after this series, sparse with endian-checking at least gets through a compile without hitting too many errors, patch 9 is a functional change and may have exposed an endian bug in the driver....but I had to get through the other 8 to see it ;-)

Quoted 5 lines

patches 1-8 shouldn't change any behavior...if it does it wasn't intentional.

 drivers/net/bnx2x.h      |    4 ---
 drivers/net/bnx2x_main.c |   62 +++++++++++++++++++++++-----------------------
 2 files changed, 31 insertions(+), 35 deletions(-)

Thanks Harvey! This change looks good