Skip to contentSkip to conversation

ASoC: Complete Beagleboard support

PATCH In review Steve Sakoman 4 participants 9 messages Jan 21, 2009 – Mar 11, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: Complete Beagleboard support

Commit dc06102a0c8b5aa0dd7f9a40ce241e793c252a87 in the asoc tree did not include the necessary Kconfig and Makefile changes. This patch completes the support for Beagleboard

---
 sound/soc/omap/Kconfig  |   10 ++++++++++
 sound/soc/omap/Makefile |    2 ++
 2 files changed, 12 insertions(+), 0 deletions(-)
sound/soc/omap/Kconfig +10 -0
index 4f7f040..ccd8973 100644
@@ -55,3 +55,13 @@ config SND_OMAP_SOC_OMAP3_PANDORA
 	select SND_SOC_TWL4030
 	help
 	  Say Y if you want to add support for SoC audio on the OMAP3 Pandora.
+
+config SND_OMAP_SOC_OMAP3_BEAGLE
+	tristate "SoC Audio support for OMAP3 Beagle"
+	depends on TWL4030_CORE && SND_OMAP_SOC && MACH_OMAP3_BEAGLE
+	select SND_OMAP_SOC_MCBSP
+	select SND_SOC_TWL4030
+	help
+	  Say Y if you want to add support for SoC audio on the Beagleboard.
+
+
sound/soc/omap/Makefile +2 -0
index 76fedd9..0c9e4ac 100644
@@ -12,6 +12,7 @@ snd-soc-overo-objs := overo.o
 snd-soc-omap2evm-objs := omap2evm.o
 snd-soc-sdp3430-objs := sdp3430.o
 snd-soc-omap3pandora-objs := omap3pandora.o
+snd-soc-omap3beagle-objs := omap3beagle.o
 
 obj-$(CONFIG_SND_OMAP_SOC_N810) += snd-soc-n810.o
 obj-$(CONFIG_SND_OMAP_SOC_OSK5912) += snd-soc-osk5912.o
@@ -19,3 +20,4 @@ obj-$(CONFIG_SND_OMAP_SOC_OVERO) += snd-soc-overo.o
 obj-$(CONFIG_MACH_OMAP2EVM) += snd-soc-omap2evm.o
 obj-$(CONFIG_SND_OMAP_SOC_SDP3430) += snd-soc-sdp3430.o
 obj-$(CONFIG_SND_OMAP_SOC_OMAP3_PANDORA) += snd-soc-omap3pandora.o
+obj-$(CONFIG_SND_OMAP_SOC_OMAP3_BEAGLE) += snd-soc-omap3beagle.o
Signature · 1 line
1.5.6.3
#1 lore raw

Hello,

for ure now you can build it, but does it actually works? I mean there has been quite a bit of change in the twl4030 codec driver... The DAPM routing implementation might require some change in the board file also (SND_SOC_DAPM_HP, SND_SOC_DAPM_LINE, etc).

Signature · 1 line
Péter
Quoted 46 lines · On Wednesday 21 January 2009 09:05:27 ext Steve Sakoman wrote:

Commit dc06102a0c8b5aa0dd7f9a40ce241e793c252a87 in the asoc tree did not include the necessary Kconfig and Makefile changes. This patch completes the support for Beagleboard

---
 sound/soc/omap/Kconfig  |   10 ++++++++++
 sound/soc/omap/Makefile |    2 ++
 2 files changed, 12 insertions(+), 0 deletions(-)
sound/soc/omap/Kconfig +10 -0
index 4f7f040..ccd8973 100644
@@ -55,3 +55,13 @@ config SND_OMAP_SOC_OMAP3_PANDORA
 	select SND_SOC_TWL4030
 	help
 	  Say Y if you want to add support for SoC audio on the OMAP3 Pandora.
+
+config SND_OMAP_SOC_OMAP3_BEAGLE
+	tristate "SoC Audio support for OMAP3 Beagle"
+	depends on TWL4030_CORE && SND_OMAP_SOC && MACH_OMAP3_BEAGLE
+	select SND_OMAP_SOC_MCBSP
+	select SND_SOC_TWL4030
+	help
+	  Say Y if you want to add support for SoC audio on the Beagleboard.
+
+
sound/soc/omap/Makefile +2 -0
index 76fedd9..0c9e4ac 100644
@@ -12,6 +12,7 @@ snd-soc-overo-objs := overo.o
 snd-soc-omap2evm-objs := omap2evm.o
 snd-soc-sdp3430-objs := sdp3430.o
 snd-soc-omap3pandora-objs := omap3pandora.o
+snd-soc-omap3beagle-objs := omap3beagle.o
 
 obj-$(CONFIG_SND_OMAP_SOC_N810) += snd-soc-n810.o
 obj-$(CONFIG_SND_OMAP_SOC_OSK5912) += snd-soc-osk5912.o
@@ -19,3 +20,4 @@ obj-$(CONFIG_SND_OMAP_SOC_OVERO) += snd-soc-overo.o
 obj-$(CONFIG_MACH_OMAP2EVM) += snd-soc-omap2evm.o
 obj-$(CONFIG_SND_OMAP_SOC_SDP3430) += snd-soc-sdp3430.o
 obj-$(CONFIG_SND_OMAP_SOC_OMAP3_PANDORA) += snd-soc-omap3pandora.o
+obj-$(CONFIG_SND_OMAP_SOC_OMAP3_BEAGLE) += snd-soc-omap3beagle.o
#2 lore raw
Quoted 5 lines · Peter Ujfalusi

for ure now you can build it, but does it actually works? I mean there has been quite a bit of change in the twl4030 codec driver... The DAPM routing implementation might require some change in the board file also (SND_SOC_DAPM_HP, SND_SOC_DAPM_LINE, etc).

The DAPM default is that all the endpoints are on so it should work fine but possibly won't be optimal so further tuning patches may be required.

I'll apply the patch since it's going to be needed whatever the case.

#3 lore raw
In reply to Peter Ujfalusi
Quoted 7 lines · Peter Ujfalusi

Hello,

for ure now you can build it, but does it actually works? I mean there has been quite a bit of change in the twl4030 codec driver... The DAPM routing implementation might require some change in the board file also (SND_SOC_DAPM_HP, SND_SOC_DAPM_LINE, etc).

I will test this morning. I expect it should work since Overo works and Beagle is largely identical.

Steve

#4 lore raw
Quoted 4 lines · Steve Sakoman
Quoted 2 lines · Peter Ujfalusi

Hello,

Quoted 8 lines
Quoted 5 lines

for ure now you can build it, but does it actually works? I mean there has been quite a bit of change in the twl4030 codec driver... The DAPM routing implementation might require some change in the board file also (SND_SOC_DAPM_HP, SND_SOC_DAPM_LINE, etc).

I will test this morning. I expect it should work since Overo works and Beagle is largely identical.

I did a quick mplayer test and was able to play an mp3 with this patch applied to linux-omap top of tree.

Hardware was Beagle Rev C1D

Steve

#5 lore raw
Quoted 2 lines · On Wednesday 21 January 2009 18:35:54 ext Steve Sakoman wrote:

I did a quick mplayer test and was able to play an mp3 with this patch applied to linux-omap top of tree.

That's great!
Not that I had any objections to the patch itself, but I was not sure if it is working. As Mark pointed out - and I was not aware off - that all endpoints are on by default and has to be explicitely marked as not connected if they are not in use.

Quoted 3 lines

Hardware was Beagle Rev C1D

Steve

Signature · 1 line
Péter
Quoted 4 lines

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Acked-by on v1 1/1
#6 lore raw
In reply to Steve Sakoman
Quoted 6 lines · On Tue, 20 Jan 2009 23:05:27 -0800 "ext Steve Sakoman" <[email protected]>…

Commit dc06102a0c8b5aa0dd7f9a40ce241e793c252a87 in the asoc tree did not include the necessary Kconfig and Makefile changes. This patch completes the support for Beagleboard

Not tested but definitely a way to go forward :-)

Jarkko

#7 lore raw
Quoted 7 lines · Jarkko Nikula
Quoted 4 lines · On Tue, 20 Jan 2009 23:05:27 -0800 "ext Steve Sakoman" <[email protected]>…

Commit dc06102a0c8b5aa0dd7f9a40ce241e793c252a87 in the asoc tree did not include the necessary Kconfig and Makefile changes.  This patch completes the support for Beagleboard

Quoted 5 lines
Quoted 2 lines

Not tested but definitely a way to go forward :-)

Any updates on the status of this patch? Doesn't seem to have been applied yet.

I've seen lot's of folks on the Beagle mailing list and IRC channels who are getting bitten by this issue.

Steve