usb/mcs7830: Don't use buffers from stack for USB transfers
Subsystems (3)
PATCH 1/1 usb/mcs7830: Don't use buffers from stack for USB transfers
From: Christian Eggers <[email protected]>
mcs7830_set_reg() and mcs7830_get_reg() are called with buffers from stack which must not be used directly for USB transfers. This causes corruption of the stack particulary on non x86 architectures because DMA may be used for these transfers.
---
This mail was sent by KMail. I hope tabs/spaces are ok now.
drivers/net/usb/mcs7830.c +18 -2
@@ -94,10 +94,18 @@ static int mcs7830_get_reg(struct usbnet {struct usb_device *xdev = dev->udev;int ret; +void *buffer; + + buffer =kmalloc (size,GFP_NOIO ); +if (buffer ==NULL ) +return -ENOMEM ; ret =usb_control_msg (xdev,usb_rcvctrlpipe (xdev,0 ),MCS7830_RD_BREQ , -MCS7830_RD_BMREQ ,0x0000 , index, data, +MCS7830_RD_BMREQ ,0x0000 , index, buffer, size,MCS7830_CTRL_TIMEOUT ); +memcpy (data, buffer, size); +kfree (buffer); +return ret; }
@@ -105,10 +113,18 @@ static int mcs7830_set_reg(struct usbnet {struct usb_device *xdev = dev->udev;int ret; +void *buffer; + + buffer =kmalloc (size,GFP_NOIO ); +if (buffer ==NULL ) +return -ENOMEM ; + +memcpy (buffer, data, size); ret =usb_control_msg (xdev,usb_sndctrlpipe (xdev,0 ),MCS7830_WR_BREQ , -MCS7830_WR_BMREQ ,0x0000 , index, data, +MCS7830_WR_BMREQ ,0x0000 , index, buffer, size,MCS7830_CTRL_TIMEOUT ); +kfree (buffer);return ret; }
From: Christian Eggers <[email protected]>
Date: Wed, 21 Jan 2009 12:48:30 +0100
Quoted 6 lines
mcs7830_set_reg()andmcs7830_get_reg()are called with buffers from stack which must not be used directly for USB transfers. This causes corruption of the stack particulary on non x86 architectures because DMA may be used for these transfers.Signed-off-by Christian Eggers <[email protected]>
Applied, thanks everyone.