Skip to contentSkip to conversation

USB: Change "usb tree" cmd to print 480MBit upon highspeed connection

PATCH New Stefan Roese 3 participants 5 messages Jan 21, 2009 – Jan 22, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 USB: Change "usb tree" cmd to print 480MBit upon highspeed connection

---
 common/cmd_usb.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
common/cmd_usb.c +1 -0
index 9e55c7c..773d1b5 100644
@@ -310,6 +310,7 @@ void usb_show_tree_graph(struct usb_device *dev, char *pre)
 	pre[index] = 0;
 	printf(" %s (%s, %dmA)\n", usb_get_class_desc(
 					dev->config.if_desc[0].bInterfaceClass),
+					dev->speed == 2 ? "480MBit/s" :
 					dev->speed ? "1.5MBit/s" : "12MBit/s",
 					dev->config.MaxPower * 2);
 	if (strlen(dev->mf) || strlen(dev->prod) || strlen(dev->serial))
Signature · 1 line
1.6.1
#1 lore raw

PATCH 1/1 USB: Change "usb tree" cmd to print 480MBit upon highspeed connection

Hi Remy,

I forgot to number those USB related patches. Here the list:

USB-Change-usb-tree-cmd-to-print-480MBit-upon-hig.patch USB-Fix-speed-detection-on-EHCI-cntr-with-root-hub.patch USB-Add-config-option-to-call-ehci_hcd_init-again.patch USB-Add-dcache-support-to-the-EHCI-driver.patch USB-Add-EHCI-support-for-VCT-EHCI-controller.patch

They are based on the usb/testing branch. Comments welcome.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#2 lore raw

PATCH 1/1 USB: Change "usb tree" cmd to print 480MBit upon highspeed connection

In reply to Stefan Roese
Quoted 10 lines · On Wednesday 21 January 2009 11:11:47 Stefan Roese wrote:
---
 common/cmd_usb.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
common/cmd_usb.c +0 -0
index 9e55c7c..773d1b5 100644

common/cmd_usb.c void usb_show_tree_graph(struct usb_device *dev, char · line 316

Quoted 7 lines
common/cmd_usb.c +1 -0
@@ -310,6 +310,7 @@ void usb_show_tree_graph(struct usb_device *dev, char
 *pre) pre[index] = 0;
 	printf(" %s (%s, %dmA)\n", usb_get_class_desc(
 					dev->config.if_desc[0].bInterfaceClass),
+					dev->speed == 2 ? "480MBit/s" :
 					dev->speed ? "1.5MBit/s" : "12MBit/s",
 					dev->config.MaxPower * 2);
 	if (strlen(dev->mf) || strlen(dev->prod) || strlen(dev->serial))

we had a similar patch cooking locally for this

-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 835 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090121/760a1c85/attachment.pgp

#3 lore raw

PATCH 1/1 USB: Change "usb tree" cmd to print 480MBit upon highspeed connection

Quoted 7 lines · Mike Frysinger
Quoted 5 lines · On Wednesday 21 January 2009 11:11:47 Stefan Roese wrote:
---
 common/cmd_usb.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Quoted 13 lines

common/cmd_usb.c void usb_show_tree_graph(struct usb_device *dev, char · line 316

Quoted 13 lines
common/cmd_usb.c +1 -0
index 9e55c7c..773d1b5 100644
@@ -310,6 +310,7 @@ void usb_show_tree_graph(struct usb_device *dev, char
 *pre) pre[index] = 0;
 	printf(" %s (%s, %dmA)\n", usb_get_class_desc(
 					dev->config.if_desc[0].bInterfaceClass),
+					dev->speed == 2 ? "480MBit/s" :
 					dev->speed ? "1.5MBit/s" : "12MBit/s",
 					dev->config.MaxPower * 2);
 	if (strlen(dev->mf) || strlen(dev->prod) || strlen(dev->serial))

I personally prefer using the #define instead the number 1, 2, 3 (refer to linux/drivers/usb/core/hub.c)

Michael

#4 lore raw

PATCH 1/1 USB: Change "usb tree" cmd to print 480MBit upon highspeed connection

Quoted 7 lines · Michael Trimarchi
Quoted 6 lines · Mike Frysinger
Quoted 5 lines · On Wednesday 21 January 2009 11:11:47 Stefan Roese wrote:
---
 common/cmd_usb.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Quoted 15 lines
Quoted 4 lines
Quoted 4 lines
common/cmd_usb.c +0 -0
index 9e55c7c..773d1b5 100644
Quoted 8 lines

common/cmd_usb.c void usb_show_tree_graph(struct usb_device *dev, · line 316

Quoted 8 lines
common/cmd_usb.c +1 -0
@@ -310,6 +310,7 @@ void usb_show_tree_graph(struct usb_device *dev,
 char *pre) pre[index] = 0;
 	printf(" %s (%s, %dmA)\n", usb_get_class_desc(
 					dev->config.if_desc[0].bInterfaceClass),
+					dev->speed == 2 ? "480MBit/s" :
 					dev->speed ? "1.5MBit/s" : "12MBit/s",
 					dev->config.MaxPower * 2);
 	if (strlen(dev->mf) || strlen(dev->prod) || strlen(dev->serial))

I personally prefer using the #define instead the number 1, 2, 3 (refer to linux/drivers/usb/core/hub.c)

OK, I'll provide a patch using the defines later today.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================