Skip to contentSkip to conversation

orinoco: trivial cleanup in alloc_orinocodev

PATCH In review Andrey Borzenkov 4 participants 6 messages Jan 21, 2009 – Jan 22, 2009 Networking drivers (wireless)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 orinoco: trivial cleanup in alloc_orinocodev

Subject: [PATCH] orinoco: trivial cleanup in alloc_orinocodev
From: Andrey Borzenkov <[email protected]>

Remove extra space; remove redundant cast

---

This is on top of previous patch for struct net_device_ops.

 drivers/net/wireless/orinoco/orinoco.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0

b/drivers/net/wireless/orinoco/orinoco.c
index d1207d0..497f324 100644

drivers/net/wireless/orinoco/orinoco.c +2 -2
@@ -3603,7 +3603,7 @@ struct net_device
 	struct orinoco_private *priv;
 
 	dev = alloc_etherdev(sizeof(struct orinoco_private) + sizeof_card);
-	if (! dev)
+	if (!dev)
 		return NULL;
 	priv = netdev_priv(dev);
 	priv->ndev = dev;
@@ -3618,7 +3618,7 @@ struct net_device
 	dev->netdev_ops = &orinoco_netdev_ops;
 	dev->watchdog_timeo = HZ; /* 1 second timeout */
 	dev->ethtool_ops = &orinoco_ethtool_ops;
-	dev->wireless_handlers = (struct iw_handler_def *)&orinoco_handler_def;
+	dev->wireless_handlers = &orinoco_handler_def;
 #ifdef WIRELESS_SPY
 	priv->wireless_data.spy_data = &priv->spy_data;
 	dev->wireless_data = &priv->wireless_data;
#1 lore raw
Quoted 6 lines · Andrey Borzenkov

Subject: [PATCH] orinoco: trivial cleanup in alloc_orinocodev
From: Andrey Borzenkov <[email protected]>

Remove extra space; remove redundant cast

drivers/net/wireless/orinoco/orinoco.c struct net_device · line 3606

Quoted 2 lines
drivers/net/wireless/orinoco/orinoco.c +1 -1
-	if (! dev)
+	if (!dev)

There are 41 occurrences of "(! " in drivers/net/wireless, all in drivers/net/wireless/orinoco. Care to fix them all?

By the way, I made a patch that adds all C sources in drivers/net/wireless/orinoco and ran it through checkpatch.pl. There were 226 errors and 174 warnings. That includes those spaces, trailing whitespace, excessively long lines and so on. It would be great if you fix at least some of that. Actually, long lines are justified in many cases, so please don't overdo it.

drivers/net/wireless/orinoco/orinoco.c struct net_device · line 3621

Quoted 2 lines
drivers/net/wireless/orinoco/orinoco.c +1 -1
-	dev->wireless_handlers = (struct iw_handler_def *)&orinoco_handler_def;
+	dev->wireless_handlers = &orinoco_handler_def;

That's fine.

Signature · 2 lines
Regards,
Pavel Roskin
#2 lore raw
Quoted 16 lines · Pavel Roskin
Quoted 6 lines · Andrey Borzenkov

Subject: [PATCH] orinoco: trivial cleanup in alloc_orinocodev
From: Andrey Borzenkov <[email protected]>

Remove extra space; remove redundant cast

drivers/net/wireless/orinoco/orinoco.c struct net_device · line 3606

Quoted 2 lines
drivers/net/wireless/orinoco/orinoco.c +1 -1
-	if (! dev)
+	if (!dev)

There are 41 occurrences of "(! " in drivers/net/wireless, all in drivers/net/wireless/orinoco. Care to fix them all?

Quoted 6 lines

By the way, I made a patch that adds all C sources in drivers/net/wireless/orinoco and ran it through checkpatch.pl. There were 226 errors and 174 warnings. That includes those spaces, trailing whitespace, excessively long lines and so on. It would be great if you fix at least some of that. Actually, long lines are justified in many cases, so please don't overdo it.

I've a patch series reorganising the orinoco driver a bit to help with future changes. It should fix a good proportion of those warnings. I plan to post it soon - so I'd appreciate it if you held off submitting further cleanup patches until I get it done (I'll try for the end of this week).

I should be able to rebase around this one.

Thanks,

Dave.

#3 lore raw
Quoted 7 lines · Dave

I've a patch series reorganising the orinoco driver a bit to help with future changes. It should fix a good proportion of those warnings. I plan to post it soon - so I'd appreciate it if you held off submitting further cleanup patches until I get it done (I'll try for the end of this week).

I should be able to rebase around this one.

OK, good to know.

Signature · 2 lines
Regards,
Pavel Roskin
#4 lore raw
In reply to Pavel Roskin
Quoted 2 lines · Pavel Roskin

By the way, I made a patch that adds all C sources in drivers/net/wireless/orinoco and ran it through checkpatch.pl.

You can use checkpatch's --file argument directly, no need to create patches manually :)

Signature · 1 line
Kalle Valo
#5 lore raw
Quoted 7 lines · Kalle Valo
Quoted 2 lines · Pavel Roskin

By the way, I made a patch that adds all C sources in drivers/net/wireless/orinoco and ran it through checkpatch.pl.

You can use checkpatch's --file argument directly, no need to create patches manually :)

Thanks. Doing it now!

Signature · 2 lines
Regards,
Pavel Roskin