Skip to contentSkip to conversation

Fix longstanding "error: storage size of '__mod_dmi_device_table' isn't known"

PATCH In review Alexey Dobriyan 2 participants 2 messages Jan 21, 2009 – Jan 27, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Fix longstanding "error: storage size of '__mod_dmi_device_table' isn't known"

gcc 3.4.6 doesn't like MODULE_DEVICE_TABLE(dmi, x) expansion enough to error out. Shut it up in a most simple way.

---

 include/linux/mod_devicetable.h |    7 +++++++
 1 file changed, 7 insertions(+)
include/linux/mod_devicetable.h +7 -0
@@ -443,6 +443,13 @@ struct dmi_system_id {
 	struct dmi_strmatch matches[4];
 	void *driver_data;
 };
+/*
+ * struct dmi_device_id appears during expansion of
+ * "MODULE_DEVICE_TABLE(dmi, x)". Compiler doesn't look inside it
+ * but this is enough for gcc 3.4.6 to error out:
+ *	error: storage size of '__mod_dmi_device_table' isn't known
+ */
+#define dmi_device_id dmi_system_id
 #endif
 
 #define DMI_MATCH(a, b)	{ a, b }
#1 lore raw
Quoted 15 lines · On Thu, 22 Jan 2009 01:58:36 +0300 Alexey Dobriyan <[email protected]> wrote:

gcc 3.4.6 doesn't like MODULE_DEVICE_TABLE(dmi, x) expansion enough to error out. Shut it up in a most simple way.

---

 include/linux/mod_devicetable.h |    7 +++++++
 1 file changed, 7 insertions(+)
include/linux/mod_devicetable.h +0 -0
@@ -443,6 +443,13 @@ struct dmi_system_id {
 	struct dmi_strmatch matches[4];
 	void *driver_data;
 };

include/linux/mod_devicetable.h struct dmi_system_id { · line 455

Quoted 10 lines
include/linux/mod_devicetable.h +7 -0
+/*
+ * struct dmi_device_id appears during expansion of
+ * "MODULE_DEVICE_TABLE(dmi, x)". Compiler doesn't look inside it
+ * but this is enough for gcc 3.4.6 to error out:
+ *	error: storage size of '__mod_dmi_device_table' isn't known
+ */
+#define dmi_device_id dmi_system_id
 #endif
 
 #define DMI_MATCH(a, b)	{ a, b }

I don't get it.

If code has

MODULE_DEVICE_TABLE(dmi, x);

and correctly includes mod_devicetable.h then that code will be expanded and compiled happily by all compiler versions? Or not?

Under what circumstances does it fail? Presumably if some header files weren't included? If so, why is that specific to a gcc version?

Or something else. I have no idea. Sigh. New changelog, please.