Hacks to make Nokia N800 compile
Subsystems (6)
cover Hacks to make Nokia N800 compile
In currently linux-omap tree n800_defconfig doesn't compile because of few compiler and linker errors. Here are the fixes/hacks which I use. I'll send them in case anyone else is interested them.
---
Kalle Valo (3):
Disable linux-omap version of menelaus
tsub6010: fix omap compile
n800-bt: include board-nokia.h
arch/arm/mach-omap2/board-n800-bt.c | 1 + drivers/i2c/chips/Makefile | 1 - drivers/usb/musb/tusb6010_omap.c | 4 ++-- 3 files changed, 3 insertions(+), 3 deletions(-)
PATCH 1/3 n800-bt: include board-nokia.h
Fixes compilation error:
arch/arm/mach-omap2/board-n800-bt.c: In function 'n800_bt_init':arch/arm/mach-omap2/board-n800-bt.c:36: error: 'OMAP_TAG_NOKIA_BT' undeclared (first use in this function) arch/arm/mach-omap2/board-n800-bt.c:36: error: (Each undeclared identifier is reported only once arch/arm/mach-omap2/board-n800-bt.c:36: error: for each function it appears in.) arch/arm/mach-omap2/board-n800-bt.c:36: error: invalid application of 'sizeof' to incomplete type 'struct omap_bluetooth_config'
---
arch/arm/mach-omap2/board-n800-bt.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
arch/arm/mach-omap2/board-n800-bt.c +1 -0
@@ -22,6 +22,7 @@#include <linux/kernel.h> #include <linux/platform_device.h> #include <mach/board.h> +#include <mach/board-nokia.h> static struct platform_device n800_bt_device = { .name ="hci_h4p" ,
Tony Lindgren
maintainerRe: [PATCH 1/3] n800-bt: include board-nokia.h
Quoted 7 lines · Kalle Valo
Fixes compilation error:
arch/arm/mach-omap2/board-n800-bt.c: In function 'n800_bt_init':arch/arm/mach-omap2/board-n800-bt.c:36: error: 'OMAP_TAG_NOKIA_BT' undeclared (first use in this function)arch/arm/mach-omap2/board-n800-bt.c:36: error: (Each undeclared identifier is reported only oncearch/arm/mach-omap2/board-n800-bt.c:36: error: for each function it appears in.)arch/arm/mach-omap2/board-n800-bt.c:36: error: invalid application of 'sizeof' to incomplete type 'structomap_bluetooth_config'
Thanks, pushing to l-o.
Tony
Quoted 23 lines
Signed-off-by Kalle Valo <[email protected]>---
arch/arm/mach-omap2/board-n800-bt.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)arch/arm/mach-omap2/board-n800-bt.c +1
-1@@ -22,6 +22,7 @@#include <linux/kernel.h> #include <linux/platform_device.h> #include <mach/board.h> +#include <mach/board-nokia.h> static struct platform_device n800_bt_device = { .name ="hci_h4p" , --To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 2/3 tsub6010: fix omap compile
In reply to Kalle Valodrivers/usb/musb/tusb6010_omap.c:18:26: error: asm/arch/dma.h: No such file or directory drivers/usb/musb/tusb6010_omap.c:19:26: error: asm/arch/mux.h: No such file or directory
---
drivers/usb/musb/tusb6010_omap.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)
drivers/usb/musb/tusb6010_omap.c +2 -2
@@ -15,8 +15,8 @@#include <linux/usb.h> #include <linux/platform_device.h> #include <linux/dma-mapping.h> -#include <asm/arch/dma.h> -#include <asm/arch/mux.h> +#include <mach/dma.h> +#include <mach/mux.h> #include "musb_core.h"
Tony Lindgren
maintainerRe: [PATCH 2/3] tsub6010: fix omap compile
Quoted 2 lines · Kalle Valo
drivers/usb/musb/tusb6010_omap.c:18:26: error:asm/arch/dma.h: No such file or directorydrivers/usb/musb/tusb6010_omap.c:19:26: error:asm/arch/mux.h: No such file or directory
Not touching this, Felipe needs to queue this up via linux-usb list.
Tony
Quoted 27 lines
Signed-off-by Kalle Valo <[email protected]>---
drivers/usb/musb/tusb6010_omap.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)drivers/usb/musb/tusb6010_omap.c +2
-3@@ -15,8 +15,8 @@#include <linux/usb.h> #include <linux/platform_device.h> #include <linux/dma-mapping.h> -#include <asm/arch/dma.h> -#include <asm/arch/mux.h> +#include <mach/dma.h> +#include <mach/mux.h> #include "musb_core.h" --To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/3] tsub6010: fix omap compile
Quoted 5 lines · Tony Lindgren
Quoted 2 lines · Kalle Valo
drivers/usb/musb/tusb6010_omap.c:18:26: error:asm/arch/dma.h: No such file or directorydrivers/usb/musb/tusb6010_omap.c:19:26: error:asm/arch/mux.h: No such file or directoryNot touching this, Felipe needs to queue this up via linux-usb list.
sure, kalle, could you resend to [email protected] ??
also, sure to Cc me
Signature · 1 line
balbi
Re: [PATCH 2/3] tsub6010: fix omap compile
Quoted 8 lines · Felipe Balbi
Quoted 5 lines · Tony Lindgren
Quoted 2 lines · Kalle Valo
drivers/usb/musb/tusb6010_omap.c:18:26: error:asm/arch/dma.h: No such file or directorydrivers/usb/musb/tusb6010_omap.c:19:26: error:asm/arch/mux.h: No such file or directoryNot touching this, Felipe needs to queue this up via linux-usb list.
sure, kalle, could you resend to [email protected] ??
Ok, I will.
Quoted 1 line
also, sure to Cc me
Tá bom :)
Signature · 5 lines
Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 2/3] tsub6010: fix omap compile
Quoted 1 line · Kalle Valo
Tá bom :)
hehe :-)
Signature · 5 lines
balbi -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 3/3 Disable linux-omap version of menelaus
In reply to Kalle ValoFixes linker errors like this:
drivers/i2c/built-in.o: In function `menelaus_set_vdcdc':
lp5521.c:(.text+0x3910): multiple definition of menelaus_set_vdcdc' drivers/mfd/built-in.o:menelaus.c:(.text+0x95c): first defined here drivers/i2c/built-in.o: In function menelaus_set_vio':
lp5521.c:(.text+0x3990): multiple definition of `menelaus_set_vio'
---
drivers/i2c/chips/Makefile | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
drivers/i2c/chips/Makefile +0 -1
@@ -18,7 +18,6 @@ obj-$(CONFIG_SENSORS_PCA9539) += pca9539.o obj-$(CONFIG_SENSORS_PCF8574) += pcf8574.o obj-$(CONFIG_PCF8575) += pcf8575.o obj-$(CONFIG_SENSORS_PCF8591) += pcf8591.o -obj-$(CONFIG_MENELAUS) += menelaus.o obj-$(CONFIG_SENSORS_TSL2550) += tsl2550.o obj-$(CONFIG_TWL4030_POWEROFF) += twl4030-poweroff.o obj-$(CONFIG_TWL4030_PWRBUTTON) += twl4030-pwrbutton.o
Re: [PATCH 3/3] Disable linux-omap version of menelaus
Quoted 19 lines · Kalle Valo
Fixes linker errors like this:
drivers/i2c/built-in.o: In function `menelaus_set_vdcdc':
lp5521.c:(.text+0x3910): multiple definition ofmenelaus_set_vdcdc' drivers/mfd/built-in.o:menelaus.c:(.text+0x95c): first defined here drivers/i2c/built-in.o: In functionmenelaus_set_vio':
lp5521.c:(.text+0x3990): multiple definition of `menelaus_set_vio'Signed-off-by Kalle Valo <[email protected]>---
drivers/i2c/chips/Makefile | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)drivers/i2c/chips/Makefile +0
-0
drivers/i2c/chips/Makefile obj-$(CONFIG_SENSORS_PCA9539) += pca9539.o · line 21
Quoted 4 lines
drivers/i2c/chips/Makefile +0
-1@@ -18,7 +18,6 @@ obj-$(CONFIG_SENSORS_PCA9539) += pca9539.o obj-$(CONFIG_SENSORS_PCF8574) += pcf8574.o obj-$(CONFIG_PCF8575) += pcf8575.o obj-$(CONFIG_SENSORS_PCF8591) += pcf8591.o -obj-$(CONFIG_MENELAUS) += menelaus.o
and mmc is broken again
Signature · 1 line
balbi
Tony Lindgren
maintainerRe: [PATCH 3/3] Disable linux-omap version of menelaus
Quoted 15 lines · Felipe Balbi
Quoted 14 lines · Kalle Valo
Fixes linker errors like this:
drivers/i2c/built-in.o: In function `menelaus_set_vdcdc':
lp5521.c:(.text+0x3910): multiple definition ofmenelaus_set_vdcdc' drivers/mfd/built-in.o:menelaus.c:(.text+0x95c): first defined here drivers/i2c/built-in.o: In functionmenelaus_set_vio':
lp5521.c:(.text+0x3990): multiple definition of `menelaus_set_vio'Signed-off-by Kalle Valo <[email protected]>---
drivers/i2c/chips/Makefile | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
Quoted 9 lines
drivers/i2c/chips/Makefile obj-$(CONFIG_SENSORS_PCA9539) += pca9539.o · line 21
Quoted 9 lines
drivers/i2c/chips/Makefile +0
-1@@ -18,7 +18,6 @@ obj-$(CONFIG_SENSORS_PCA9539) += pca9539.o obj-$(CONFIG_SENSORS_PCF8574) += pcf8574.o obj-$(CONFIG_PCF8575) += pcf8575.o obj-$(CONFIG_SENSORS_PCF8591) += pcf8591.o -obj-$(CONFIG_MENELAUS) += menelaus.o
I'll also remove drivers/i2c/chips/menelaus.c.
Quoted 1 line
and mmc is broken again
Hmm..
Tony
Re: [PATCH 3/3] Disable linux-omap version of menelaus
Quoted 16 lines · Tony Lindgren
Quoted 15 lines · Felipe Balbi
Quoted 14 lines · Kalle Valo
Fixes linker errors like this:
drivers/i2c/built-in.o: In function `menelaus_set_vdcdc':
lp5521.c:(.text+0x3910): multiple definition ofmenelaus_set_vdcdc' drivers/mfd/built-in.o:menelaus.c:(.text+0x95c): first defined here drivers/i2c/built-in.o: In functionmenelaus_set_vio':
lp5521.c:(.text+0x3990): multiple definition of `menelaus_set_vio'Signed-off-by Kalle Valo <[email protected]>---
drivers/i2c/chips/Makefile | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)
Quoted 11 lines
Quoted 9 lines
drivers/i2c/chips/Makefile obj-$(CONFIG_SENSORS_PCA9539) += pca9539.o · line 21
Quoted 9 lines
drivers/i2c/chips/Makefile +0
-1@@ -18,7 +18,6 @@ obj-$(CONFIG_SENSORS_PCA9539) += pca9539.o obj-$(CONFIG_SENSORS_PCF8574) += pcf8574.o obj-$(CONFIG_PCF8575) += pcf8575.o obj-$(CONFIG_SENSORS_PCF8591) += pcf8591.o -obj-$(CONFIG_MENELAUS) += menelaus.oI'll also remove
drivers/i2c/chips/menelaus.c.
why, did this driver make its way to mainline with a different name then ??
Where did Jean move it ?
Signature · 1 line
balbi
Tony Lindgren
maintainerRe: [PATCH 3/3] Disable linux-omap version of menelaus
Quoted 29 lines · Felipe Balbi
Quoted 16 lines · Tony Lindgren
Quoted 15 lines · Felipe Balbi
Quoted 14 lines · Kalle Valo
Fixes linker errors like this:
drivers/i2c/built-in.o: In function `menelaus_set_vdcdc':
lp5521.c:(.text+0x3910): multiple definition ofmenelaus_set_vdcdc' drivers/mfd/built-in.o:menelaus.c:(.text+0x95c): first defined here drivers/i2c/built-in.o: In functionmenelaus_set_vio':
lp5521.c:(.text+0x3990): multiple definition of `menelaus_set_vio'Signed-off-by Kalle Valo <[email protected]>---
drivers/i2c/chips/Makefile | 1 - 1 files changed, 0 insertions(+), 1 deletions(-)Quoted 11 lines
Quoted 9 lines
drivers/i2c/chips/Makefile obj-$(CONFIG_SENSORS_PCA9539) += pca9539.o · line 21
Quoted 9 lines
drivers/i2c/chips/Makefile +0
-1@@ -18,7 +18,6 @@ obj-$(CONFIG_SENSORS_PCA9539) += pca9539.o obj-$(CONFIG_SENSORS_PCF8574) += pcf8574.o obj-$(CONFIG_PCF8575) += pcf8575.o obj-$(CONFIG_SENSORS_PCF8591) += pcf8591.o -obj-$(CONFIG_MENELAUS) += menelaus.oI'll also remove
drivers/i2c/chips/menelaus.c.
Quoted 4 lines
why, did this driver make its way to mainline with a different name then ??
Where did Jean move it ?
Dave has been busy again.. 88e75cc347f66bc20e3c2b920431fc07253d69be.
Tony
Re: [PATCH 3/3] Disable linux-omap version of menelaus
Quoted 1 line · Tony Lindgren
Dave has been busy again..
88e75cc347f66bc20e3c2b920431fc07253d69be.
aaa ok, it's difficult to follow Dave, heh :-)
Signature · 1 line
balbi
Re: [PATCH 3/3] Disable linux-omap version of menelaus
In reply to Tony LindgrenQuoted 11 lines · Tony Lindgren
Quoted 9 lines
drivers/i2c/chips/Makefile obj-$(CONFIG_SENSORS_PCA9539) += pca9539.o · line 21
Quoted 9 lines
drivers/i2c/chips/Makefile +0
-1@@ -18,7 +18,6 @@ obj-$(CONFIG_SENSORS_PCA9539) += pca9539.o obj-$(CONFIG_SENSORS_PCF8574) += pcf8574.o obj-$(CONFIG_PCF8575) += pcf8575.o obj-$(CONFIG_SENSORS_PCF8591) += pcf8591.o -obj-$(CONFIG_MENELAUS) += menelaus.oI'll also remove
drivers/i2c/chips/menelaus.c.
Thanks. It's nice to see drivers going to upstream.
Signature · 1 line
Kalle Valo
Re: [PATCH 3/3] Disable linux-omap version of menelaus
Quoted 3 lines · Kalle Valo
Quoted 1 line
I'll also remove
drivers/i2c/chips/menelaus.c.Thanks. It's nice to see drivers going to upstream.
That driver has been upstream for quite a long time now. This change was just helping scrub drivers/i2c/chips, since it's going away.
That means all drivers which the OMAP tree has in that directory should be pushed upstream, or at least moved to a better home, soon ... :)
- Dave
Tony Lindgren
maintainerRe: [PATCH 3/3] Disable linux-omap version of menelaus
Quoted 5 lines · David Brownell
Quoted 3 lines · Kalle Valo
Quoted 1 line
I'll also remove
drivers/i2c/chips/menelaus.c.Thanks. It's nice to see drivers going to upstream.
Quoted 7 lines
That driver has been upstream for quite a long time now. This change was just helping scrub
drivers/i2c/chips, since it's going away.That means all drivers which the OMAP tree has in that directory should be pushed upstream, or at least moved to a better home, soon ... :)
Or else we'll just remove them until somebody patches them back against the mainline tree.
Tony
Re: [PATCH 3/3] Disable linux-omap version of menelaus
Quoted 7 lines · Tony Lindgren
Quoted 4 lines
That means all drivers which the OMAP tree has in that directory should be pushed upstream, or at least moved to a better home, soon ... :)
Or else we'll just remove them until somebody patches them back against the mainline tree.
Right:
- lp5521.c
- tsl2563.c
- twl4030-madc.c
- twl4030-poweroff.c
- twl4030-pwrbutton.c
Re: [PATCH 3/3] Disable linux-omap version of menelaus
Quoted 6 lines · David Brownell
Quoted 5 lines · Tony Lindgren
Quoted 4 lines
That means all drivers which the OMAP tree has in that directory should be pushed upstream, or at least moved to a better home, soon ... :)
Quoted 7 lines
Quoted 2 lines
Or else we'll just remove them until somebody patches them back against the mainline tree.
Right:
-
lp5521.c
-tsl2563.c
at least these two I had patched them and moved to other locations, looks the patches weren't applied.
Signature · 1 line
balbi
Tony Lindgren
maintainerRe: [PATCH 3/3] Disable linux-omap version of menelaus
Quoted 10 lines · Felipe Balbi
Quoted 9 lines · David Brownell
Quoted 7 lines · Tony Lindgren
Quoted 4 lines
That means all drivers which the OMAP tree has in that directory should be pushed upstream, or at least moved to a better home, soon ... :)
Or else we'll just remove them until somebody patches them back against the mainline tree.
Quoted 7 lines
Quoted 4 lines
Right:
-
lp5521.c
-tsl2563.cat least these two I had patched them and moved to other locations, looks the patches weren't applied.
Maybe try to send them to the right drivers lists for mainline integration?
Tony
Re: [PATCH 3/3] Disable linux-omap version of menelaus
Quoted 13 lines · Tony Lindgren
Quoted 12 lines · Felipe Balbi
Quoted 11 lines · David Brownell
Quoted 7 lines · Tony Lindgren
Quoted 4 lines
That means all drivers which the OMAP tree has in that directory should be pushed upstream, or at least moved to a better home, soon ... :)
Or else we'll just remove them until somebody patches them back against the mainline tree.
Right:
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
-
lp5521.c
-tsl2563.cat least these two I had patched them and moved to other locations, looks the patches weren't applied.
Maybe try to send them to the right drivers lists for mainline integration?
but then you'd have to drop them from l-o ;-)
Signature · 1 line
balbi
Quoted 3 lines · Kalle Valo
In currently linux-omap tree
n800_defconfigdoesn't compile because of few compiler and linker errors. Here are the fixes/hacks which I use. I'll send them in case anyone else is interested them.
Thanks; I hope to try this again soon on an N810.