Skip to contentSkip to conversation

ASoC: remove stand-alone mode support from CS4270 codec driver

PATCH In review Timur Tabi 3 participants 6 messages Jan 23, 2009

Subsystems (3)
lore
Share & tools
lore

Timur Tabi

author
#0 lore raw

PATCH v2 1/1 ASoC: remove stand-alone mode support from CS4270 codec driver

The CS4270 supports stand-alone mode, where the codec is not connect to the I2C or SPI buses. Instead, input voltages configure the codec at power-on. The CS4270 ASoC device driver has partial support for this mode, but the code was never tested, and partial support doesn't help anyone. It also made the rest of the code more complicated than necessary.

---

v2: Added Kconfig changes

 sound/soc/codecs/Kconfig  |    1 +
 sound/soc/codecs/cs4270.c |   92 +++++++++++++-------------------------------
 sound/soc/fsl/Kconfig     |    3 +-
 3 files changed, 30 insertions(+), 66 deletions(-)
sound/soc/codecs/Kconfig +1 -0
index cb5fcd6..136e1bc 100644
@@ -65,6 +65,7 @@ config SND_SOC_AK4535
 # Cirrus Logic CS4270 Codec
 config SND_SOC_CS4270
 	tristate
+	depends on I2C
 
 # Cirrus Logic CS4270 Codec Hardware Mute Support
 # Select if you have external muting circuitry attached to your CS4270.
sound/soc/codecs/cs4270.c +27 -65

170 lines not on this page · raw message

sound/soc/fsl/Kconfig +2 -1
index c7c78c3..9fc9082 100644
@@ -10,7 +10,8 @@ config SND_SOC_MPC8610
 
 config SND_SOC_MPC8610_HPCD
 	tristate "ALSA SoC support for the Freescale MPC8610 HPCD board"
-	depends on MPC8610_HPCD
+	# I2C is necessary for the CS4270 driver
+	depends on MPC8610_HPCD && I2C
 	select SND_SOC_MPC8610
 	select SND_SOC_CS4270
 	select SND_SOC_CS4270_VD33_ERRATA
Signature · 1 line
1.5.5
#1 lore raw

At Thu, 22 Jan 2009 18:23:39 -0600,

Quoted 22 lines · Timur Tabi

The CS4270 supports stand-alone mode, where the codec is not connect to the I2C or SPI buses. Instead, input voltages configure the codec at power-on. The CS4270 ASoC device driver has partial support for this mode, but the code was never tested, and partial support doesn't help anyone. It also made the rest of the code more complicated than necessary.

---

v2: Added Kconfig changes

 sound/soc/codecs/Kconfig  |    1 +
 sound/soc/codecs/cs4270.c |   92 +++++++++++++-------------------------------
 sound/soc/fsl/Kconfig     |    3 +-
 3 files changed, 30 insertions(+), 66 deletions(-)
sound/soc/codecs/Kconfig +0 -0
index cb5fcd6..136e1bc 100644

sound/soc/codecs/Kconfig config SND_SOC_AK4535 · line 68

Quoted 4 lines
sound/soc/codecs/Kconfig +1 -0
@@ -65,6 +65,7 @@ config SND_SOC_AK4535
 # Cirrus Logic CS4270 Codec
 config SND_SOC_CS4270
 	tristate
+	depends on I2C

This "depends" doesn't work because CONFIG_SND_SOC_CS4270 is selected usually by others. The reverse-selection ignores the depends of the target item.

Takashi

#2 lore raw
Quoted 3 lines · Takashi Iwai

This "depends" doesn't work because CONFIG_SND_SOC_CS4270 is selected usually by others. The reverse-selection ignores the depends of the target item.

Applied with that dependency removed.

author
#3 lore raw
In reply to Takashi Iwai
Quoted 3 lines · Takashi Iwai

This "depends" doesn't work because CONFIG_SND_SOC_CS4270 is selected usually by others. The reverse-selection ignores the depends of the target item.

I considered that, but then I saw this:

config SND_SOC_TLV320AIC23
tristate
depends on I2C

and

config SND_OMAP_SOC_OSK5912

	tristate "SoC Audio support for omap osk5912"
	depends on SND_OMAP_SOC && MACH_OMAP_OSK
	select SND_OMAP_SOC_MCBSP
	select SND_SOC_TLV320AIC23
	help
	  Say Y if you want to add support for SoC audio on osk5912.

So I'm just doing the same thing that the OSK5912 Kconfig is doing.

Signature · 2 lines
Timur Tabi
Linux kernel developer at Freescale
#4 lore raw
Quoted 7 lines · Timur Tabi

I considered that, but then I saw this:

config SND_SOC_TLV320AIC23
tristate
depends on I2C

config SND_OMAP_SOC_OSK5912

Quoted 8 lines
	tristate "SoC Audio support for omap osk5912"
	depends on SND_OMAP_SOC && MACH_OMAP_OSK
	select SND_OMAP_SOC_MCBSP
	select SND_SOC_TLV320AIC23
	help
	  Say Y if you want to add support for SoC audio on osk5912.

So I'm just doing the same thing that the OSK5912 Kconfig is doing.

That's broken too, will fix.

#5 lore raw
In reply to Timur Tabi

At Fri, 23 Jan 2009 08:00:38 -0600,

Quoted 16 lines · Timur Tabi
Quoted 3 lines · Takashi Iwai

This "depends" doesn't work because CONFIG_SND_SOC_CS4270 is selected usually by others. The reverse-selection ignores the depends of the target item.

I considered that, but then I saw this:

config SND_SOC_TLV320AIC23
tristate
depends on I2C

and

config SND_OMAP_SOC_OSK5912

Quoted 8 lines
	tristate "SoC Audio support for omap osk5912"
	depends on SND_OMAP_SOC && MACH_OMAP_OSK
	select SND_OMAP_SOC_MCBSP
	select SND_SOC_TLV320AIC23
	help
	  Say Y if you want to add support for SoC audio on osk5912.

So I'm just doing the same thing that the OSK5912 Kconfig is doing.

Heh, you found a bug and have a chance to fix it ;)

thanks,

Takashi