Skip to contentSkip to conversation

ftrace interface for blktrace

PATCH In review Arnaldo Carvalho de Melo 3 participants 3 messages Jan 23, 2009 – Jan 26, 2009

lore
Share & tools
lore
#0 lore raw

cover ftrace interface for blktrace

Hi Jens,

Here is a third version, that also implements blk_add_trace_msg,
using ftrace_vprintk.

As soon as the TRACE_ITER_CONTEXT_INFO option is implemented
I'll provide the struct trace_event->bin() callback to synthesize the old blktrace record format so that we can test the output of trace_pipe with blkparse -i -.

Please let me know if this is acceptable for inclusion on
linux-tip.

Best Regards,

- Arnaldo

 block/blktrace.c       |  651 ++++++++++++++++++++++++++++++++++++++++++++++++-
 fs/partitions/check.c  |    7 
 include/linux/ftrace.h |    8 
 kernel/trace/trace.c   |    9 
 kernel/trace/trace.h   |    1 
 5 files changed, 671 insertions(+), 5 deletions(-)
#1 lore raw
Quoted 5 lines · Arnaldo Carvalho de Melo

Hi Jens,

Here is a third version, that also implements blk_add_trace_msg,
using ftrace_vprintk.

Quoted 7 lines

As soon as the TRACE_ITER_CONTEXT_INFO option is implemented
I'll provide the struct trace_event->bin() callback to synthesize the old blktrace record format so that we can test the output of trace_pipe with blkparse -i -.

Please let me know if this is acceptable for inclusion on
linux-tip.

Sure, go ahead and add it!

Signature · 1 line
Jens Axboe
#2 lore raw
Quoted 11 lines · Jens Axboe
Quoted 10 lines · Arnaldo Carvalho de Melo

Hi Jens,

Here is a third version, that also implements blk_add_trace_msg,
using ftrace_vprintk.

As soon as the TRACE_ITER_CONTEXT_INFO option is implemented
I'll provide the struct trace_event->bin() callback to synthesize the old blktrace record format so that we can test the output of trace_pipe with blkparse -i -.

Quoted 4 lines
Quoted 2 lines

Please let me know if this is acceptable for inclusion on
linux-tip.

Sure, go ahead and add it!

Cool - i've started tracking Arnaldo's patch by picking up the latest version into tip/tracing/blktrace and merging it into tip/master.

Arnaldo, could you please check latest tip/master:

http://people.redhat.com/mingo/tip.git/README

to see whether it's all OK, integrated with the latest tracing bits?

Ingo