Skip to contentSkip to conversation

ARM: OMAP: board-omap3beagle: set i2c-3 to 100kHz

PATCH In review Koen Kooi 8 participants 16 messages Jan 15, 2009 – Jan 27, 2009 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

Koen Kooi

author
#0 lore raw

PATCH 1/1 ARM: OMAP: board-omap3beagle: set i2c-3 to 100kHz

From: Koen Kooi <[email protected]>

Changing it to 100kHz is needed to make more devices works properly. Controlling the TI DLP Pico projector[1] doesn't work properly at 400kHz, 100kHz and lower work fine. EDID readout is unaffected by this change.

[1] http://focus.ti.com/dlpdmd/docs/dlpdiscovery.tsp?sectionId=60&tabId=2234

---
 arch/arm/mach-omap2/board-omap3beagle.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/board-omap3beagle.c +1 -1
index fe97bab..f279404 100644
@@ -227,7 +227,7 @@ static int __init omap3_beagle_i2c_init(void)
 #ifdef CONFIG_I2C2_OMAP_BEAGLE
 	omap_register_i2c_bus(2, 400, NULL, 0);
 #endif
-	omap_register_i2c_bus(3, 400, NULL, 0);
+	omap_register_i2c_bus(3, 100, NULL, 0);
 	return 0;
 }
 
Signature · 1 line
1.5.6.3
#1 lore raw

Sorry for the noise, I suck at sending patches :/

Op 15 jan 2009, om 20:30 heeft Koen Kooi het volgende geschreven:

Quoted 32 lines

From: Koen Kooi <[email protected]>

Changing it to 100kHz is needed to make more devices works properly. Controlling the TI DLP Pico projector[1] doesn't work properly at 400kHz, 100kHz and lower work fine. EDID readout is unaffected by this change.

[1] http://focus.ti.com/dlpdmd/docs/dlpdiscovery.tsp?sectionId=60&tabId=2234

---
arch/arm/mach-omap2/board-omap3beagle.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/board-omap3beagle.c +1 -1
index fe97bab..f279404 100644
@@ -227,7 +227,7 @@ static int __init omap3_beagle_i2c_init(void)
 #ifdef CONFIG_I2C2_OMAP_BEAGLE
 	omap_register_i2c_bus(2, 400, NULL, 0);
 #endif
-	omap_register_i2c_bus(3, 400, NULL, 0);
+	omap_register_i2c_bus(3, 100, NULL, 0);
 	return 0;
 }
 
Signature · 6 lines
1.5.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#2 lore raw
In reply to Koen Kooi

Op 15 jan 2009, om 20:30 heeft Koen Kooi het volgende geschreven:

Quoted 7 lines

From: Koen Kooi <[email protected]>

Changing it to 100kHz is needed to make more devices works properly. Controlling the TI DLP Pico projector[1] doesn't work properly at 400kHz, 100kHz and lower work fine. EDID readout is unaffected by this change.

[1] http://focus.ti.com/dlpdmd/docs/dlpdiscovery.tsp?sectionId=60&tabId=2234

Any comments on this patch?

regards,

Koen

Quoted 26 lines

---
arch/arm/mach-omap2/board-omap3beagle.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach-omap2/board-omap3beagle.c +1 -1
index fe97bab..f279404 100644
@@ -227,7 +227,7 @@ static int __init omap3_beagle_i2c_init(void)
 #ifdef CONFIG_I2C2_OMAP_BEAGLE
 	omap_register_i2c_bus(2, 400, NULL, 0);
 #endif
-	omap_register_i2c_bus(3, 400, NULL, 0);
+	omap_register_i2c_bus(3, 100, NULL, 0);
 	return 0;
 }
 
Signature · 6 lines
1.5.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#3 lore raw
Quoted 10 lines · Koen Kooi

Op 15 jan 2009, om 20:30 heeft Koen Kooi het volgende geschreven:

Quoted 7 lines

From: Koen Kooi <[email protected]>

Changing it to 100kHz is needed to make more devices works properly. Controlling the TI DLP Pico projector[1] doesn't work properly at 400kHz, 100kHz and lower work fine. EDID readout is unaffected by this change.

Quoted 5 lines
Quoted 3 lines

[1] http://focus.ti.com/dlpdmd/docs/dlpdiscovery.tsp?sectionId=60&tabId=2234

Any comments on this patch?

I2C-3 is only used for talking on DVI, right? Which means EDID ... and maybe DLP/Pico, unless someone uses it as an I2C adapter. (Which some folk hack together on PCs...)

Seems harmless to me, but I'd add a comment explaining why just 100 MHz. (The Pico manual says 400 KHz should work.)

- Dave

Quoted 29 lines

regards,

Koen

Quoted 21 lines

---
arch/arm/mach-omap2/board-omap3beagle.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach- renamed from arch/arm/mach-omap2/board-omap3beagle.c +0 -0

omap2/board-omap3beagle.c
index fe97bab..f279404 100644

arch/arm/mach-omap2/board-omap3beagle.c +1 -1
@@ -227,7 +227,7 @@ static int __init omap3_beagle_i2c_init(void)
 #ifdef CONFIG_I2C2_OMAP_BEAGLE
 	omap_register_i2c_bus(2, 400, NULL, 0);
 #endif
-	omap_register_i2c_bus(3, 400, NULL, 0);
+	omap_register_i2c_bus(3, 100, NULL, 0);
 	return 0;
 }
 
Signature · 1 line
1.5.6.3
#4 lore raw

Op 23 jan 2009, om 10:52 heeft David Brownell het volgende geschreven:

Quoted 17 lines · Koen Kooi
Quoted 10 lines

Op 15 jan 2009, om 20:30 heeft Koen Kooi het volgende geschreven:

Quoted 7 lines

From: Koen Kooi <[email protected]>

Changing it to 100kHz is needed to make more devices works properly. Controlling the TI DLP Pico projector[1] doesn't work properly at 400kHz, 100kHz and lower work fine. EDID readout is unaffected by this change.

Quoted 5 lines
Quoted 3 lines

[1] http://focus.ti.com/dlpdmd/docs/dlpdiscovery.tsp?sectionId=60&tabId=2234

Any comments on this patch?

Quoted 8 lines

I2C-3 is only used for talking on DVI, right? Which means EDID ... and maybe DLP/Pico, unless someone uses it as an I2C adapter. (Which some folk hack together on PCs...)

Seems harmless to me, but I'd add a comment explaining why just 100 MHz. (The Pico manual says 400 KHz should work.)

The updated manual will say 400kHz won't work, the TI DLP engineers were the ones that designed the pico that pointed the i2c speed problem out to me :) I'd be happy to change the patch if needed, but I think the updated manual will take care of most issues.

regards,

Koen

Quoted 34 lines

- Dave

Quoted 29 lines

regards,

Koen

Quoted 21 lines

---
arch/arm/mach-omap2/board-omap3beagle.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach- renamed from arch/arm/mach-omap2/board-omap3beagle.c +0 -0

omap2/board-omap3beagle.c
index fe97bab..f279404 100644

arch/arm/mach-omap2/board-omap3beagle.c +1 -1
@@ -227,7 +227,7 @@ static int __init omap3_beagle_i2c_init(void)
 #ifdef CONFIG_I2C2_OMAP_BEAGLE
 	omap_register_i2c_bus(2, 400, NULL, 0);
 #endif
-	omap_register_i2c_bus(3, 400, NULL, 0);
+	omap_register_i2c_bus(3, 100, NULL, 0);
 	return 0;
 }
 
Signature · 1 line
1.5.6.3
#5 lore raw
Quoted 29 lines · Koen Kooi

Op 23 jan 2009, om 10:52 heeft David Brownell het volgende geschreven:

Quoted 17 lines · Koen Kooi
Quoted 10 lines

Op 15 jan 2009, om 20:30 heeft Koen Kooi het volgende geschreven:

Quoted 7 lines

From: Koen Kooi <[email protected]>

Changing it to 100kHz is needed to make more devices works properly. Controlling the TI DLP Pico projector[1] doesn't work properly at 400kHz, 100kHz and lower work fine. EDID readout is unaffected by this change.

Quoted 5 lines
Quoted 3 lines

[1] http://focus.ti.com/dlpdmd/docs/dlpdiscovery.tsp?sectionId=60&tabId=2234

Any comments on this patch?

Quoted 8 lines

I2C-3 is only used for talking on DVI, right? Which means EDID ... and maybe DLP/Pico, unless someone uses it as an I2C adapter. (Which some folk hack together on PCs...)

Seems harmless to me, but I'd add a comment explaining why just 100 MHz. (The Pico manual says 400 KHz should work.)

Quoted 6 lines

The updated manual will say 400kHz won't work, the TI DLP engineers were the ones that designed the pico that pointed the i2c speed problem out to me :) I'd be happy to change the patch if needed, but I think the updated manual will take care of most issues.

regards,

Koen

Given that this port is only used on the DVI port for the BeagleBoard, I believe it is appropriate to set it to 100kHz as Koen has done.

Quoted 37 lines
Quoted 36 lines

- Dave

Quoted 29 lines

regards,

Koen

Quoted 21 lines

---
arch/arm/mach-omap2/board-omap3beagle.c | 2 +-

1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/mach- renamed from arch/arm/mach-omap2/board-omap3beagle.c +0 -0

omap2/board-omap3beagle.c
index fe97bab..f279404 100644

arch/arm/mach-omap2/board-omap3beagle.c +1 -1
@@ -227,7 +227,7 @@ static int __init omap3_beagle_i2c_init(void)
 #ifdef CONFIG_I2C2_OMAP_BEAGLE
 	omap_register_i2c_bus(2, 400, NULL, 0);
 #endif
-	omap_register_i2c_bus(3, 400, NULL, 0);
+	omap_register_i2c_bus(3, 100, NULL, 0);
 	return 0;
 }
 
Signature · 1 line
1.5.6.3
#6 lore raw
Quoted 3 lines · Jason Kridner

Given that this port is only used on the DVI port for the BeagleBoard, I believe it is appropriate to set it to 100kHz as Koen has done.

That's what I meant to say (kHz not MHZ!) ... except, also add a comment saying why the (un-obvious) restriction is being made.

Though I did note that since it's a nice level-shifted I2C, some folk may want to use it for non-DDC purposes [1], where a 100 KHz limit might not always be wanted.

- Dave

[1] http://www.paintyourdragon.com/uc/i2c/index.html

#7 lore raw

Op 24 jan 2009 om 21:30 heeft David Brownell <[email protected]> het volgende geschreven:\

Quoted 8 lines · Jason Kridner
Quoted 3 lines

Given that this port is only used on the DVI port for the BeagleBoard, I believe it is appropriate to set it to 100kHz as Koen has done.

That's what I meant to say (kHz not MHZ!) ... except, also add a comment saying why the (un-obvious) restriction is being made.

In the .c file or commit message?

Regards,

Koen

Quoted 8 lines

Though I did note that since it's a nice level-shifted I2C, some folk may want to use it for non-DDC purposes [1], where a 100 KHz limit might not always be wanted.

- Dave

[1] http://www.paintyourdragon.com/uc/i2c/index.html

#8 lore raw
Quoted 1 line · Koen Kooi

In the .c file or commit message?

A one line comment in the C file.

A message that is not in the archive (sent off-list or not yet received): [email protected]

#10 lore raw

No audio support for BeagleBoard in Latest GIT tree?

Hi everyone,

Last week, I downloaded the 2.6.29-rc2 (http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=tag;h=d31ce8060b0e875179ba5ca1d40475dc2a082cc7) and compiled it for the BeagleBoard. Everything seems to run fine (I disabled video support because I don't use it). However, there doesn't seem to be audio (twl4030 audio) support for the BeagleBoard; the default configuration (omap3_beagle_defconfig) doesn't enable audio and when I tried to enable ALSA, there's no option for the twl4030 driver. Is audio not yet supported in the last GIT tree? What the latest tag/tree (v2.6.28-omap1???) I should use that has audio support for the BeagleBoard.

I have a few more questions so maybe you guys can help me. The questions I'm going to ask are mostly new and not already answered (I searched the group and coudn't find any answers); I'm sorry if any has been asked before and maybe you can point me in the right direction. I'm new to the OMAP3 processor; I just started experimenting with the BeagleBoard a few weeks back (I also have TI Mistral OMAP3EVM board but I'm using the BeagleBoard since our OMAP3 custom board is based on the BeagleBoard). For the last couple years, I worked on TI's Davinci processor; our project decided recently to go with the OMAP3 because it's more powerful and consumes less power. For this reason, I have to port all our existing software to our new OMAP3 custom board. For the Davinci processor, I used the 2.6
.23 GIT version of the kernel (http://source.mvista.com/git/?p=linux-davinci-2.6.git) so I'm a little familiar with the kernel. Here are some questions I have
initially:

1) Is the X-loader really required? Can the BeagleBoard just boot straight to u-boot?
2) The BeagleBoard uses the twl4030 device for its audio (among other things); for our OMAP3 custom board, we're not using that, we're going to continue use the AIC33 codec (like what we used on our Davinci custom board). Is adding support for the AIC33 codec as simple as enabling that option in the OMAP3 GIT kernel configuration under ALSA? Or do I have to do a lot of porting? If so, what is the best approach, i.e. porting the AIC33 initialization/driver code for mthe Davinci GIT kernel into OMAP3 GIT kernel?
3) Is OSS audio API no longer supported? Our existing application uses the OSS audio API; the latest kernel seems to only support ALSA; is OSS emulation (on top of ALSA) working and/or reliable?
4) How reliable is the DSP bridge driver mentioned on the wiki page? On our Davinci board, we used TI's Code-Engine/DSP/BIOS DSPLINK driver to perform ARM-DSP IPC. This past week, I was able to download TI's DSPLINK (now open source, https://www-a.ti.com/downloads/sds_support/targetcontent/link/index.html) and build it with the default BeagleBoard 2.6.22-18 kernel and got the examples to run fine. I'm in the process of getting it to work with the latest OMAP3 GIT tree but I'm stuck now because I can't get the audio to work (my pre-first question).

OK, I think I've asked too many questions but hopefully someone can provide some advice and answers. Thanks in advance!!

Regards,
Andy

#11 lore raw

Re: No audio support for BeagleBoard in Latest GIT tree?

Hello,

Quoted 12 lines · On Tuesday 27 January 2009 11:18:16 ext [email protected] wrote:

Hi everyone,

Last week, I downloaded the 2.6.29-rc2
(http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=tag;
h=d31ce8060b0e875179ba5ca1d40475dc2a082cc7) and compiled it for the BeagleBoard. Everything seems to run fine (I disabled video support because I don't use it). However, there doesn't seem to be audio (twl4030 audio) support for the BeagleBoard; the default configuration (omap3_beagle_defconfig) doesn't enable audio and when I tried to enable ALSA, there's no option for the twl4030 driver. Is audio not yet supported in the last GIT tree? What the latest tag/tree (v2.6.28-omap1???) I should use that has audio support for the BeagleBoard.

You need to take this patch sent by Steve Sakoman:
http://git.kernel.org/?p=linux/kernel/git/tiwai/sound-2.6.git;a=commit;h=80c509fdd74f3b158267374cc55156965c8bf930
This has been sent to l-o also, so you can take the patch from this mailing list...

Quoted 5 lines

Regards,
Andy

Signature · 5 lines
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#12 lore raw

Re: No audio support for BeagleBoard in Latest GIT tree?

Quoted 6 lines

You need to take this patch sent by Steve Sakoman:
http://git.kernel.org/?p=linux/kernel/git/tiwai/sound-2.6.git;a=commit;h=80c509fdd74f3b158267374cc55156965c8bf930
This has been sent to l-o also, so you can take the patch from this mailing list...

Thanks! So where is the official OMAP3 GIT tree located? The one you mentioned above has Steve's patch but the one (Steve's own link) mentioned on the wiki page doesn't. There are 2 or 3 OMAP3 GIT sites out there and I don't know which one is the "official" working one. I just noticed the one sponsored by Montavista is now obsolete.

Regards,
Andy

#13 lore raw

Re: No audio support for BeagleBoard in Latest GIT tree?

Quoted 10 lines · On Tuesday 27 January 2009 12:35:40 ext [email protected] wrote:
Quoted 4 lines

You need to take this patch sent by Steve Sakoman:
http://git.kernel.org/?p=linux/kernel/git/tiwai/sound-2.6.git;a=commit;h=
80c509fdd74f3b158267374cc55156965c8bf930 This has been sent to l-o also, so you can take the patch from this mailing list...

Thanks! So where is the official OMAP3 GIT tree located? The one you mentioned above has Steve's patch but the one (Steve's own link) mentioned on the wiki page doesn't. There are 2 or 3 OMAP3 GIT sites out there and I don't know which one is the "official" working one. I just noticed the one sponsored by Montavista is now obsolete.

The link above points to sound-2.6 (Takashi Iwai's tree), the official ALSA/Sound tree.

AFAIK the official OMAP tree is:
http://git.kernel.org/?p=linux/kernel/git/tmlind/linux-omap-2.6.git;a=summary

Quoted 3 lines

Regards,
Andy

Signature · 5 lines
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#14 lore raw

Re: No audio support for BeagleBoard in Latest GIT tree?

In reply to [email protected]

l-o tree is now at
git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git

Quoted 17 lines · On Tue, Jan 27, 2009 at 4:05 PM, <[email protected]> wrote:
Quoted 6 lines

You need to take this patch sent by Steve Sakoman:
http://git.kernel.org/?p=linux/kernel/git/tiwai/sound-2.6.git;a=commit;h=80c509fdd74f3b158267374cc55156965c8bf930
This has been sent to l-o also, so you can take the patch from this mailing list...

Thanks! So where is the official OMAP3 GIT tree located? The one you mentioned above has Steve's patch but the one (Steve's own link) mentioned on the wiki page doesn't. There are 2 or 3 OMAP3 GIT sites out there and I don't know which one is the "official" working one. I just noticed the one sponsored by Montavista is now obsolete.

Regards,
Andy

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#15 lore raw

Re: No audio support for BeagleBoard in Latest GIT tree?

In reply to [email protected]
Quoted 1 line · On Tue, 27 Jan 2009 10:18:16 +0100 "ext [email protected]"…

2) The BeagleBoard uses the twl4030 device for its audio (among other things); for our OMAP3 custom board, we're not using that, we're going to continue use the AIC33 codec (like what we used on our Davinci custom board). Is adding support for the AIC33 codec as simple as enabling that option in the OMAP3 GIT kernel configuration under ALSA? Or do I have to do a lot of porting? If so, what is the best approach, i.e. porting the AIC33 initialization/driver code for mthe Davinci GIT kernel into OMAP3 GIT kernel?

With ALSA System on Chip (ASoC) porting is pretty simple. There is already driver for AIC33 (sound/soc/codecs/tlv320aic3x.c), ASoC OMAP platfrom drivers (sound/soc/omap) and also machine drivers using AIC33 (sound/soc/omap/n810.c and sound/soc/davinci/davinci-evm.c).

So what you need is basically to write your own machine driver using mostly copy-paste approach.

Quoted 1 line

3) Is OSS audio API no longer supported? Our existing application uses the OSS audio API; the latest kernel seems to only support ALSA; is OSS emulation (on top of ALSA) working and/or reliable?

At least some few OSS applications I have tried were working fine with OSS emulation.

Jarkko

#16 lore raw

Re: No audio support for BeagleBoard in Latest GIT tree?

Quoted 17 lines
Quoted 2 lines

2) The BeagleBoard uses the twl4030 device for its audio (among other things);

for our OMAP3 custom board, we're not using that, we're going to continue use the AIC33 codec (like what we used on our Davinci custom board). Is adding support for the AIC33 codec as simple as enabling that option in the OMAP3 GIT kernel configuration under ALSA? Or do I have to do a lot of porting? If so, what is the best approach, i.e. porting the AIC33 initialization/driver code for mthe Davinci GIT kernel into OMAP3 GIT kernel?

With ALSA System on Chip (ASoC) porting is pretty simple. There is already driver for AIC33 (sound/soc/codecs/tlv320aic3x.c), ASoC OMAP platfrom drivers (sound/soc/omap) and also machine drivers using AIC33 (sound/soc/omap/n810.c and sound/soc/davinci/davinci-evm.c).

So what you need is basically to write your own machine driver using mostly copy-paste approach.

Quoted 7 lines
Quoted 1 line

3) Is OSS audio API no longer supported? Our existing application uses the

OSS audio API; the latest kernel seems to only support ALSA; is OSS emulation (on top of ALSA) working and/or reliable?

At least some few OSS applications I have tried were working fine with OSS emulation.

Thanks for the advice and pointers. Hopefully, when I get my hands dirty in a few weeks and I get into troubles, people like you on this board can help.

Regards,
Andy