Skip to contentSkip to conversation

ide/net: flip the order of SATA and network init

PATCH In review Arjan van de Ven 4 participants 7 messages Jan 27, 2009 – Jan 28, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ide/net: flip the order of SATA and network init

Quoted 1 line

From e89d6840ad685a3c61f72367d4ac5bfed69ead0c Mon Sep 17 00:00:00 2001

From: Arjan van de Ven <[email protected]>
Date: Mon, 26 Jan 2009 18:58:11 -0800
Subject: [PATCH] ide/net: flip the order of SATA and network init

this patch flips the order in which sata and network drivers are initialized.

SATA probing takes quite a bit of time, and with the asynchronous infrastructure other drivers that run after it can execute in parallel. Network drivers do tend to take some real time talking to the hardware, so running these later is a good thing (the sata probe then runs concurrent)

This saves about 15% of my kernels boot time.

---
 drivers/Makefile |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
drivers/Makefile +3 -2
index c1bf417..2618a61 100644
@@ -36,13 +36,14 @@ obj-$(CONFIG_FB_INTEL)          += video/intelfb/
 
 obj-y				+= serial/
 obj-$(CONFIG_PARPORT)		+= parport/
-obj-y				+= base/ block/ misc/ mfd/ net/ media/
+obj-y				+= base/ block/ misc/ mfd/ media/
 obj-$(CONFIG_NUBUS)		+= nubus/
-obj-$(CONFIG_ATM)		+= atm/
 obj-y				+= macintosh/
 obj-$(CONFIG_IDE)		+= ide/
 obj-$(CONFIG_SCSI)		+= scsi/
 obj-$(CONFIG_ATA)		+= ata/
+obj-y				+= net/
+obj-$(CONFIG_ATM)		+= atm/
 obj-$(CONFIG_FUSION)		+= message/
 obj-$(CONFIG_FIREWIRE)		+= firewire/
 obj-y				+= ieee1394/
Signature · 8 lines
1.6.0.5



-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
maintainer Acked-by on v1 1/1
#1 lore raw

From: Arjan van de Ven <[email protected]>
Date: Tue, 27 Jan 2009 14:19:52 -0800

Quoted 4 lines

ide/net: flip the order of SATA and network init

this patch flips the order in which sata and network drivers are initialized.

Quoted 8 lines

SATA probing takes quite a bit of time, and with the asynchronous infrastructure other drivers that run after it can execute in parallel. Network drivers do tend to take some real time talking to the hardware, so running these later is a good thing (the sata probe then runs concurrent)

This saves about 15% of my kernels boot time.

I have no problem with this:

#2 lore raw
In reply to Arjan van de Ven
Quoted 30 lines · Arjan van de Ven
Quoted 1 line

From e89d6840ad685a3c61f72367d4ac5bfed69ead0c Mon Sep 17 00:00:00 2001

From: Arjan van de Ven <[email protected]>
Date: Mon, 26 Jan 2009 18:58:11 -0800
Subject: [PATCH] ide/net: flip the order of SATA and network init

this patch flips the order in which sata and network drivers are initialized.

SATA probing takes quite a bit of time, and with the asynchronous infrastructure other drivers that run after it can execute in parallel. Network drivers do tend to take some real time talking to the hardware, so running these later is a good thing (the sata probe then runs concurrent)

This saves about 15% of my kernels boot time.

---
 drivers/Makefile |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
drivers/Makefile +1 -1
index c1bf417..2618a61 100644
@@ -36,13 +36,14 @@ obj-$(CONFIG_FB_INTEL)          += video/intelfb/
 
 obj-y				+= serial/
 obj-$(CONFIG_PARPORT)		+= parport/
-obj-y				+= base/ block/ misc/ mfd/ net/ media/
+obj-y				+= base/ block/ misc/ mfd/ media/
 obj-$(CONFIG_NUBUS)		+= nubus/

drivers/Makefile obj-$(CONFIG_FB_INTEL) += video/intelfb/ · line 49

Quoted 10 lines
drivers/Makefile +2 -1
-obj-$(CONFIG_ATM)		+= atm/
 obj-y				+= macintosh/
 obj-$(CONFIG_IDE)		+= ide/
 obj-$(CONFIG_SCSI)		+= scsi/
 obj-$(CONFIG_ATA)		+= ata/
+obj-y				+= net/
+obj-$(CONFIG_ATM)		+= atm/
 obj-$(CONFIG_FUSION)		+= message/
 obj-$(CONFIG_FIREWIRE)		+= firewire/
 obj-y				+= ieee1394/

ACK, ok with me too

#3 lore raw
Quoted 2 lines · On Tue, 27 Jan 2009 18:35:37 -0500 Jeff Garzik <[email protected]> wrote:

ACK, ok with me too

ok so... which tree should this go via?

I would guess jgarzik's because he deals with both sata and net ;)

Jeff... how do you want to handle this?

Signature · 3 lines
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
maintainer
#4 lore raw

From: Arjan van de Ven <[email protected]>
Date: Tue, 27 Jan 2009 16:48:42 -0800

Quoted 7 lines
Quoted 2 lines · On Tue, 27 Jan 2009 18:35:37 -0500 Jeff Garzik <[email protected]> wrote:

ACK, ok with me too

ok so... which tree should this go via?

Feel free to just submit it directly to Linus, you have both of our ACKs :-)

#5 lore raw
Quoted 6 lines · David Miller

From: Arjan van de Ven <[email protected]>
Date: Tue, 27 Jan 2009 16:48:42 -0800

Quoted 3 lines

On Tue, 27 Jan 2009 18:35:37 -0500
Jeff Garzik <[email protected]> wrote:

Quoted 6 lines
Quoted 3 lines
Quoted 2 lines

ACK, ok with me too

ok so... which tree should this go via?

Feel free to just submit it directly to Linus, you have both of our ACKs :-)

ACK :)

#6 lore raw
In reply to Arjan van de Ven
Quoted 6 lines · Arjan van de Ven

From e89d6840ad685a3c61f72367d4ac5bfed69ead0c Mon Sep 17 00:00:00 2001
From: Arjan van de Ven <[email protected]>
Date: Mon, 26 Jan 2009 18:58:11 -0800
Subject: [PATCH] ide/net: flip the order of SATA and network init

this patch flips the order in which sata and network drivers are initialized.

it seems to affect much more than that, please see below

Quoted 17 lines

SATA probing takes quite a bit of time, and with the asynchronous infrastructure other drivers that run after it can execute in parallel. Network drivers do tend to take some real time talking to the hardware, so running these later is a good thing (the sata probe then runs concurrent)

This saves about 15% of my kernels boot time.

---
 drivers/Makefile |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)
drivers/Makefile +0 -0
index c1bf417..2618a61 100644

drivers/Makefile obj-$(CONFIG_FB_INTEL) += video/intelfb/ · line 43

Quoted 10 lines
drivers/Makefile +1 -2
@@ -36,13 +36,14 @@ obj-$(CONFIG_FB_INTEL)          += video/intelfb/
 
 obj-y				+= serial/
 obj-$(CONFIG_PARPORT)		+= parport/
-obj-y				+= base/ block/ misc/ mfd/ net/ media/
+obj-y				+= base/ block/ misc/ mfd/ media/
 obj-$(CONFIG_NUBUS)		+= nubus/
-obj-$(CONFIG_ATM)		+= atm/
 obj-y				+= macintosh/
 obj-$(CONFIG_IDE)		+= ide/
 obj-$(CONFIG_SCSI)		+= scsi/

scsi, ide, macintosh and nubus will be now init-ed after network.

No problem for ide but I'm not really sure about scsi...

Quoted 6 lines
drivers/Makefile +2 -0
 obj-$(CONFIG_ATA)		+= ata/
+obj-y				+= net/
+obj-$(CONFIG_ATM)		+= atm/
 obj-$(CONFIG_FUSION)		+= message/
 obj-$(CONFIG_FIREWIRE)		+= firewire/
 obj-y				+= ieee1394/