reversed logic in disconnect testing of hiddev
PATCH 1/1 reversed logic in disconnect testing of hiddev
The logic for testing for disconnection is reversed in an ioctl leading to false reports of disconnection.
Signed-off-by Oliver Neukum <[email protected]>
Tested-by Folkert van Heusden <[email protected]>
Hi,
this should go into the next rc of 2.6.29
Regards
Oliver
---
drivers/hid/usbhid/hiddev.c renamed from drivers/hid/usbhid/hiddev.c.alt +1 -1
@@ -656,7 +656,7 @@ static long hiddev_ioctl(struct file *ficase HIDIOCGSTRING :mutex_lock (&hiddev->existancelock); -if (!hiddev->exist) +if (hiddev->exist) r =hiddev_ioctl_string (hiddev, cmd, user_arg);else r = -ENODEV ;
Jiri Kosina
AppliedQuoted 7 lines · Oliver Neukum
The logic for testing for disconnection is reversed in an ioctl leading to false reports of disconnection.
Signed-off-by Oliver Neukum <[email protected]>Tested-by Folkert van Heusden <[email protected]>this should go into the next rc of 2.6.29
Applied, thanks Oliver.
Signature · 2 lines
Jiri Kosina SUSE Labs