Skip to contentSkip to conversation

blktrace: Use tracing_reset_online_cpus

PATCH Applied Arnaldo Carvalho de Melo 3 participants 4 messages Jan 28, 2009 – Jan 29, 2009 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 blktrace: Use tracing_reset_online_cpus

Impact: cleanup

Use tracing_reset_online_cpus instead of open coding it.

block/blktrace.c +1 -6
index 1b2267c..04d81d3 100644
@@ -1109,12 +1109,7 @@ static void blk_tracer_print_header(struct seq_file *m)
 
 static void blk_tracer_start(struct trace_array *tr)
 {
-	int cpu;
-
-	tr->time_start = ftrace_now(tr->cpu);
-
-	for_each_online_cpu(cpu)
-		tracing_reset(tr, cpu);
+	tracing_reset_online_cpus(tr);
 
 	mutex_lock(&blk_probe_mutex);
 	if (atomic_add_return(1, &blk_probes_ref) == 1)
#1 lore raw

2009/1/28 Arnaldo Carvalho de Melo <[email protected]>:

Quoted 16 lines

Impact: cleanup

Use tracing_reset_online_cpus instead of open coding it.

block/blktrace.c +0 -0
index 1b2267c..04d81d3 100644
@@ -1109,12 +1109,7 @@ static void blk_tracer_print_header(struct seq_file *m)
 
 static void blk_tracer_start(struct trace_array *tr)
 {

block/blktrace.c static void blk_tracer_print_header(struct seq_file *m) · line 1115

Quoted 10 lines
block/blktrace.c +1 -6
-       int cpu;
-
-       tr->time_start = ftrace_now(tr->cpu);
-
-       for_each_online_cpu(cpu)
-               tracing_reset(tr, cpu);
+       tracing_reset_online_cpus(tr);
 
       mutex_lock(&blk_probe_mutex);
       if (atomic_add_return(1, &blk_probes_ref) == 1)

Adding Steven in Cc, he uses to relay tracing patches as patchsets pull request to Ingo.

#2 lore raw

Em Wed, Jan 28, 2009 at 03:53:48PM +0100, Frédéric Weisbecker escreveu:

Quoted 24 lines

2009/1/28 Arnaldo Carvalho de Melo <[email protected]>:

Quoted 23 lines

Impact: cleanup

Use tracing_reset_online_cpus instead of open coding it.

block/blktrace.c +1 -6
index 1b2267c..04d81d3 100644
@@ -1109,12 +1109,7 @@ static void blk_tracer_print_header(struct seq_file *m)
 
 static void blk_tracer_start(struct trace_array *tr)
 {
-       int cpu;
-
-       tr->time_start = ftrace_now(tr->cpu);
-
-       for_each_online_cpu(cpu)
-               tracing_reset(tr, cpu);
+       tracing_reset_online_cpus(tr);
 
Quoted 6 lines

block/blktrace.c static void blk_tracer_print_header(struct seq_file *m) · line 1115

Quoted 3 lines
block/blktrace.c +0 -0
       mutex_lock(&blk_probe_mutex);
       if (atomic_add_return(1, &blk_probes_ref) == 1)

Adding Steven in Cc, he uses to relay tracing patches as patchsets pull request to Ingo.

Ok, will add him for the next one.

- Arnaldo