Skip to contentSkip to conversation

ahci: Fix build breakage

PATCH In review Kumar Gala 2 participants 8 messages Jan 28, 2009 libata

lore
Share & tools
lore

Kumar Gala

author
#0 lore raw

PATCH 1/1 ahci: Fix build breakage

The following commit introduces:

commit 1fd684346d41f6be2487c161f60d03a7feb68911

Author: Rafael J. Wysocki <[email protected]>
Date:   Mon Jan 19 20:57:36 2009 +0100

SATA AHCI: Blacklist system that spins off disks during ACPI power off

the following errors on non-x86 systems:

drivers/ata/ahci.c: In function 'ahci_broken_system_poweroff':
drivers/ata/ahci.c:2566: error: implicit declaration of function 'dmi_first_match' drivers/ata/ahci.c:2566: warning: initialization makes pointer from integer without a cast

---
 drivers/ata/ahci.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/ata/ahci.c +2 -0
index 77bba4c..2c84f53 100644
@@ -2550,6 +2550,7 @@ static void ahci_p5wdh_workaround(struct ata_host *host)
 
 static bool ahci_broken_system_poweroff(struct pci_dev *pdev)
 {
+#ifdef CONFIG_DMI
 	static const struct dmi_system_id broken_systems[] = {
 		{
 			.ident = "HP Compaq nx6310",
@@ -2570,6 +2571,7 @@ static bool ahci_broken_system_poweroff(struct pci_dev *pdev)
 		/* apply the quirk only to on-board controllers */
 		return slot == PCI_SLOT(pdev->devfn);
 	}
+#endif
 
 	return false;
 }
Signature · 1 line
1.5.6.6
author
#1 lore raw

PATCH 1/1 ata_piix: Fix build breakage

The following commit introduces:

commit 5f451fe1ab5d73b987051f0d23c85216c552e163

Author: Rafael J. Wysocki <[email protected]>
Date:   Mon Jan 19 20:59:22 2009 +0100

SATA PIIX: Blacklist system that spins off disks during ACPI power off

the following build errors on non-x86 systems:

drivers/ata/ata_piix.c: In function 'piix_broken_system_poweroff':
drivers/ata/ata_piix.c:1405: error: implicit declaration of function 'dmi_first_match' drivers/ata/ata_piix.c:1405: warning: initialization makes pointer from integer without a cast

---
 drivers/ata/ata_piix.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/ata/ata_piix.c +2 -0
index 54961c0..14874e1 100644
@@ -1389,6 +1389,7 @@ static void piix_iocfg_bit18_quirk(struct ata_host *host)
 
 static bool piix_broken_system_poweroff(struct pci_dev *pdev)
 {
+#ifdef CONFIG_DMI
 	static const struct dmi_system_id broken_systems[] = {
 		{
 			.ident = "HP Compaq 2510p",
@@ -1409,6 +1410,7 @@ static bool piix_broken_system_poweroff(struct pci_dev *pdev)
 		/* apply the quirk only to on-board controllers */
 		return slot == PCI_SLOT(pdev->devfn);
 	}
+#endif
 
 	return false;
 }
Signature · 1 line
1.5.6.6
author
#2 lore raw

PATCH 1/1 sata_sil: Fix build breakage

The following commit introduces:

commit e57db7bde7bff95ae812736ca00c73bd5271455b

Author: Rafael J. Wysocki <[email protected]>
Date:   Mon Jan 19 20:58:29 2009 +0100

SATA Sil: Blacklist system that spins off disks during ACPI power off

the following build errors on non-x86 systems:

drivers/ata/sata_sil.c: In function 'sil_broken_system_poweroff':
drivers/ata/sata_sil.c:713: error: implicit declaration of function 'dmi_first_match' drivers/ata/sata_sil.c:713: warning: initialization makes pointer from integer without a cast

---
 drivers/ata/sata_sil.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/ata/sata_sil.c +2 -0
index bfd55b0..3f0549d 100644
@@ -697,6 +697,7 @@ static void sil_init_controller(struct ata_host *host)
 
 static bool sil_broken_system_poweroff(struct pci_dev *pdev)
 {
+#ifdef CONFIG_DMI
 	static const struct dmi_system_id broken_systems[] = {
 		{
 			.ident = "HP Compaq nx6325",
@@ -717,6 +718,7 @@ static bool sil_broken_system_poweroff(struct pci_dev *pdev)
 		/* apply the quirk only to on-board controllers */
 		return slot == PCI_SLOT(pdev->devfn);
 	}
+#endif
 
 	return false;
 }
Signature · 1 line
1.5.6.6
author
#3 lore raw

Re: [PATCH] sata_sil: Fix build breakage

Quoted 11 lines · Kumar Gala

The following commit introduces:

commit e57db7bde7bff95ae812736ca00c73bd5271455b

Author: Rafael J. Wysocki <[email protected]>
Date:   Mon Jan 19 20:58:29 2009 +0100

SATA Sil: Blacklist system that spins off disks during ACPI power
off

the following build errors on non-x86 systems:

Quoted 8 lines

drivers/ata/sata_sil.c: In function 'sil_broken_system_poweroff':
drivers/ata/sata_sil.c:713: error: implicit declaration of function 'dmi_first_match' drivers/ata/sata_sil.c:713: warning: initialization makes pointer from integer without a cast

---
drivers/ata/sata_sil.c | 2 ++

1 files changed, 2 insertions(+), 0 deletions(-)

it was pointed out that fixing include/linux/dmi.h was the better way to fix this. I've posted a patch for fixing dmi.h that supersedes this patch.

- k

#4 lore raw

Re: [PATCH] sata_sil: Fix build breakage

Quoted 19 lines · Kumar Gala
Quoted 16 lines · Kumar Gala

The following commit introduces:

commit e57db7bde7bff95ae812736ca00c73bd5271455b

Author: Rafael J. Wysocki <[email protected]>
Date:   Mon Jan 19 20:58:29 2009 +0100

SATA Sil: Blacklist system that spins off disks during ACPI power off

the following build errors on non-x86 systems:

drivers/ata/sata_sil.c: In function 'sil_broken_system_poweroff':
drivers/ata/sata_sil.c:713: error: implicit declaration of function 'dmi_first_match'
drivers/ata/sata_sil.c:713: warning: initialization makes pointer from integer without a cast

Quoted 9 lines
Quoted 4 lines

---
drivers/ata/sata_sil.c | 2 ++

1 files changed, 2 insertions(+), 0 deletions(-)

it was pointed out that fixing include/linux/dmi.h was the better way to fix this. I've posted a patch for fixing dmi.h that supersedes this patch.

It breaks build for me in the same way even after your fix (d8204ee2: dmi: Fix build breakage)

Subject: [PATCH] sata_sil: Fix build breakage
From: Alexander Beregalov <[email protected]>

Commit e57db7b (SATA Sil: Blacklist system that spins off disks during ACPI power off) breaks build like the following, in both cases when CONFIG_DMI set or not.

drivers/ata/sata_sil.c: In function 'sil_broken_system_poweroff':
drivers/ata/sata_sil.c:713: error: implicit declaration of function 'dmi_first_match' drivers/ata/sata_sil.c:713: warning: initialization makes pointer from integer without a cast

sata_sil.c should include dmi.h

---

 drivers/ata/sata_sil.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/ata/sata_sil.c +1 -0
index bfd55b0..9f02959 100644
@@ -44,6 +44,7 @@
 #include <linux/device.h>
 #include <scsi/scsi_host.h>
 #include <linux/libata.h>
+#include <linux/dmi.h>
 
 #define DRV_NAME	"sata_sil"
 #define DRV_VERSION	"2.4"
author
#5 lore raw

Re: [PATCH] ata_piix: Fix build breakage

In reply to Kumar Gala
Quoted 11 lines · Kumar Gala

The following commit introduces:

commit 5f451fe1ab5d73b987051f0d23c85216c552e163

Author: Rafael J. Wysocki <[email protected]>
Date:   Mon Jan 19 20:59:22 2009 +0100

SATA PIIX: Blacklist system that spins off disks during ACPI
power off

the following build errors on non-x86 systems:

Quoted 8 lines

drivers/ata/ata_piix.c: In function 'piix_broken_system_poweroff':
drivers/ata/ata_piix.c:1405: error: implicit declaration of function 'dmi_first_match' drivers/ata/ata_piix.c:1405: warning: initialization makes pointer from integer without a cast

---
drivers/ata/ata_piix.c | 2 ++

1 files changed, 2 insertions(+), 0 deletions(-)

it was pointed out that fixing include/linux/dmi.h was the better way to fix this. I've posted a patch for fixing dmi.h that supersedes this patch.

- k

author
#6 lore raw

Re: [PATCH] ata_piix: Fix build breakage

In reply to Kumar Gala
Quoted 11 lines · Kumar Gala

The following commit introduces:

commit 5f451fe1ab5d73b987051f0d23c85216c552e163

Author: Rafael J. Wysocki <[email protected]>
Date:   Mon Jan 19 20:59:22 2009 +0100

SATA PIIX: Blacklist system that spins off disks during ACPI
power off

the following build errors on non-x86 systems:

Quoted 8 lines

drivers/ata/ata_piix.c: In function 'piix_broken_system_poweroff':
drivers/ata/ata_piix.c:1405: error: implicit declaration of function 'dmi_first_match' drivers/ata/ata_piix.c:1405: warning: initialization makes pointer from integer without a cast

---
drivers/ata/ata_piix.c | 2 ++

1 files changed, 2 insertions(+), 0 deletions(-)

it was pointed out that fixing include/linux/dmi.h was the better way to fix this. I've posted a patch for fixing dmi.h that supersedes this patch.

- k

author
#7 lore raw
In reply to Kumar Gala
Quoted 11 lines · Kumar Gala

The following commit introduces:

commit 1fd684346d41f6be2487c161f60d03a7feb68911

Author: Rafael J. Wysocki <[email protected]>
Date:   Mon Jan 19 20:57:36 2009 +0100

SATA AHCI: Blacklist system that spins off disks during ACPI
power off

the following errors on non-x86 systems:

Quoted 8 lines

drivers/ata/ahci.c: In function 'ahci_broken_system_poweroff':
drivers/ata/ahci.c:2566: error: implicit declaration of function 'dmi_first_match' drivers/ata/ahci.c:2566: warning: initialization makes pointer from integer without a cast

---
drivers/ata/ahci.c | 2 ++

1 files changed, 2 insertions(+), 0 deletions(-)

it was pointed out that fixing include/linux/dmi.h was the better way to fix this. I've posted a patch for fixing dmi.h that supersedes this patch.

- k