kthreads: simplify the startup synchronization
PATCH 2/4 kthreads: simplify the startup synchronization
We use two completions two create the kernel thread, this is a bit ugly. kthread() wakes up create_kthread() via ->started, then create_kthread() wakes up the caller kthread_create() via ->done. But kthread() does not need to wait for kthread(), it can just return. Instead kthread() itself can wake up the caller of kthread_create().
Kill kthread_create_info->started, ->done is enough. This improves the scalability a bit and sijmplifies the code.
The only problem if kernel_thread() fails, in that case create_kthread() must do complete(&create->done).
kernel/kthread.c renamed from kernel/kthread.c~2_COMPLETION +2 -6
@@ -29,7 +29,6 @@ struct kthread_create_info/* Information passed to kthread() from kthreadd. */ int (*threadfn)(void *data);void *data; -struct completion started;/* Result passed back to kthread_create() from kthreadd. */ struct task_struct *result;
@@ -77,7 +76,7 @@ static int kthread(void *_create)/* OK, tell user we're spawned, wait for stop or wakeup */ __set_current_state (TASK_UNINTERRUPTIBLE ); create->result = current; -complete (&create->started); +complete (&create->done);schedule ();if (!kthread_should_stop ())
@@ -99,10 +98,8 @@ static void create_kthread(struct kthrea pid =kernel_thread (kthread, create,CLONE_FS |CLONE_FILES |SIGCHLD );if (pid <0 ) { create->result =ERR_PTR (pid); - }else { -wait_for_completion (&create->started); +complete (&create->done); } -complete (&create->done); }/**
@@ -133,7 +130,6 @@ struct task_struct *kthread_create(int ( create.threadfn = threadfn; create.data = data; -init_completion (&create.started);init_completion (&create.done);spin_lock (&kthread_create_lock);
Quoted 6 lines · On Friday 30 January 2009 23:03:54 Oleg Nesterov wrote:
We use two completions two create the kernel thread, this is a bit ugly.
kthread()wakes upcreate_kthread()via ->started, thencreate_kthread()wakes up the callerkthread_create()via ->done. Butkthread()does not need to wait forkthread(), it can just return. Insteadkthread()itself can wake up the caller ofkthread_create().
Quoted 7 lines
Kill
kthread_create_info->started, ->done is enough. This improves the scalability a bit and sijmplifies the code.The only problem if
kernel_thread()fails, in that casecreate_kthread()must docomplete(&create->done).Signed-off-by Oleg Nesterov <[email protected]>
Nice! I'll apply this one after the minor respin of 1/4.
Thanks,
Rusty.