Skip to contentSkip to conversation

e1000: Fix PCI enable to honor the need_ioport flag

PATCH Applied Karsten Keil 2 participants 2 messages Feb 3, 2009 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 e1000: Fix PCI enable to honor the need_ioport flag

On machine were no IO ports are assigned the call to pci_enable_device() will fail, even if need_ioport is false, we need to use pci_enable_device_mem() here.

---
 drivers/net/e1000/e1000_main.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/e1000/e1000_main.c +1 -1
index c986978..6bd63cc 100644
@@ -940,7 +940,7 @@ static int __devinit e1000_probe(struct pci_dev *pdev,
 		err = pci_enable_device(pdev);
 	} else {
 		bars = pci_select_bars(pdev, IORESOURCE_MEM);
-		err = pci_enable_device(pdev);
+		err = pci_enable_device_mem(pdev);
 	}
 	if (err)
 		return err;
Signature · 6 lines
1.5.6.4


-- 
Karsten Keil
SuSE Labs
maintainer Applied
#1 lore raw

From: Karsten Keil <[email protected]>
Date: Tue, 3 Feb 2009 18:52:17 +0100

Quoted 5 lines

On machine were no IO ports are assigned the call to pci_enable_device() will fail, even if need_ioport is false, we need to use pci_enable_device_mem() here.

Applied.

Please CC: [email protected] for networking patches in the future so that they get properly tracked at:

http://patchwork.ozlabs.org/project/netdev/list/

Thank you.