Skip to contentSkip to conversation

cxgb3 - Fix lro switch

PATCH Applied Divy Le Ray 2 participants 3 messages Feb 5, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 cxgb3 - Fix lro switch

From: Divy Le Ray <[email protected]>

The LRO switch is always set to 1 in the rx processing loop. It breaks the accelerated iSCSI receive traffic. Fix its computation.

---

 drivers/net/cxgb3/sge.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
drivers/net/cxgb3/sge.c +1 -2
index 379a132..d31791f 100644
@@ -2276,8 +2276,7 @@ no_mem:
 		} else if ((len = ntohl(r->len_cq)) != 0) {
 			struct sge_fl *fl;
 
-			if (eth)
-				lro = qs->lro_enabled && is_eth_tcp(rss_hi);
+			lro &= eth && is_eth_tcp(rss_hi);
 
 			fl = (len & F_RSPD_FLQ) ? &qs->fl[1] : &qs->fl[0];
 			if (fl->use_pages) {
maintainer Applied
#1 lore raw

From: Divy Le Ray <[email protected]>
Date: Wed, 04 Feb 2009 16:25:47 -0800

Quoted 5 lines

The LRO switch is always set to 1 in the rx processing loop. It breaks the accelerated iSCSI receive traffic. Fix its computation.

Applied, thank you.

Could you slightly reformat your Subject lines for patches? Please use something like "cxgb3: $(description)" instead of the "cxgb3 - $(description)" you're using now.

It'll be one less thing I need to edit when applying your patches :-)

Thanks!

#2 lore raw
Quoted 11 lines · David Miller

From: Divy Le Ray <[email protected]>
Date: Wed, 04 Feb 2009 16:25:47 -0800

Quoted 6 lines

The LRO switch is always set to 1 in the rx processing loop. It breaks the accelerated iSCSI receive traffic. Fix its computation.

Quoted 9 lines

Applied, thank you.

Could you slightly reformat your Subject lines for patches? Please use something like "cxgb3: $(description)" instead of the "cxgb3 - $(description)" you're using now.

It'll be one less thing I need to edit when applying your patches :-)

Sorry about that. I'll use this format from now on.

cheers,
Divy