Skip to contentSkip to conversation

e1000e: normalize usage of serdes_has_link

PATCH Applied Alex Chiang 3 participants 3 messages Feb 4, 2009 – Feb 6, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 e1000e: normalize usage of serdes_has_link

Cosmetic change to use struct e1000_mac_info.serdes_has_link consistently as the 'bool' that it's declared as.

No functional change.

---

 ethtool.c |    2 +-
 lib.c     |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/net/e1000e/ethtool.c +1 -1
index e48956d..2557aee 100644
@@ -1589,7 +1589,7 @@ static int e1000_link_test(struct e1000_adapter *adapter, u64 *data)
 	*data = 0;
 	if (hw->phy.media_type == e1000_media_type_internal_serdes) {
 		int i = 0;
-		hw->mac.serdes_has_link = 0;
+		hw->mac.serdes_has_link = false;
 
 		/*
 		 * On some blade server designs, link establishment
drivers/net/e1000e/lib.c +2 -2
index 6674110..ac2f34e 100644
@@ -501,7 +501,7 @@ s32 e1000e_check_for_fiber_link(struct e1000_hw *hw)
 		ew32(TXCW, mac->txcw);
 		ew32(CTRL, (ctrl & ~E1000_CTRL_SLU));
 
-		mac->serdes_has_link = 1;
+		mac->serdes_has_link = true;
 	}
 
 	return 0;
@@ -566,7 +566,7 @@ s32 e1000e_check_for_serdes_link(struct e1000_hw *hw)
 		ew32(TXCW, mac->txcw);
 		ew32(CTRL, (ctrl & ~E1000_CTRL_SLU));
 
-		mac->serdes_has_link = 1;
+		mac->serdes_has_link = true;
 	} else if (!(E1000_TXCW_ANE & er32(TXCW))) {
 		/*
 		 * If we force link for non-auto-negotiation switch, check
Acked-by on v1 1/1
#1 lore raw
Quoted 8 lines

-----Original Message-----
From: Alex Chiang [mailto:[email protected]]
Sent: Wednesday, February 04, 2009 2:05 PM
To: [email protected]
Cc: Kirsher, Jeffrey T; [email protected]; Brandeburg, Jesse; Allan, Bruce W; [email protected]
Subject: [net-next PATCH] e1000e: normalize usage of serdes_has_link

Quoted 6 lines

Cosmetic change to use struct e1000_mac_info.serdes_has_link consistently as the 'bool' that it's declared as.

No functional change.

Cheers,
Jeff

maintainer Applied
#2 lore raw

From: "Kirsher, Jeffrey T" <[email protected]>
Date: Wed, 4 Feb 2009 17:23:18 -0800

Quoted 8 lines
Quoted 8 lines

-----Original Message-----
From: Alex Chiang [mailto:[email protected]]
Sent: Wednesday, February 04, 2009 2:05 PM
To: [email protected]
Cc: Kirsher, Jeffrey T; [email protected]; Brandeburg, Jesse; Allan, Bruce W; [email protected]
Subject: [net-next PATCH] e1000e: normalize usage of serdes_has_link

Quoted 8 lines
Quoted 6 lines

Cosmetic change to use struct e1000_mac_info.serdes_has_link consistently as the 'bool' that it's declared as.

No functional change.

Applied, thanks.