Skip to contentSkip to conversation

Soekris net5501 board support code

PATCH In review Alessandro Zummo 2 participants 3 messages Feb 5, 2009 – Feb 6, 2009 x86 platform drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Soekris net5501 board support code

Board support code for the Soekris net5501.

---
 drivers/platform/x86/Kconfig   |   14 ++++++
 drivers/platform/x86/Makefile  |    1 
 drivers/platform/x86/soekris.c |   92 +++++++++++++++++++++++++++++++++++++++++
 3 files changed, 107 insertions(+)
drivers/platform/x86/soekris.c new file +92 -0
@@ -0,0 +1,92 @@
+/*
+ * Soekris board support code
+ *
+ * Copyright (C) 2008-2009 Tower Technologies
+ * Written by Alessandro Zummo <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2
+ * as published by the Free Software Foundation.
+ */
+
+#include <linux/kernel.h>
+#include <linux/init.h>
+#include <linux/io.h>
+#include <linux/string.h>
+#include <linux/leds.h>
+#include <linux/platform_device.h>
+#include <linux/gpio.h>
+
+#include <asm/geode.h>
+
+static struct gpio_led net5501_leds[] = {
+	{
+		.name = "error",
+		.gpio = 6,
+		.default_trigger = "default-on",
+	},
+};
+
+static struct gpio_led_platform_data net5501_leds_data = {
+	.num_leds = ARRAY_SIZE(net5501_leds),
+	.leds = net5501_leds,
+};
+
+static struct platform_device net5501_leds_dev = {
+	.name = "leds-gpio",
+	.id = -1,
+	.dev.platform_data = &net5501_leds_data,
+};
+
+static void __init init_net5501(void)
+{
+	platform_device_register(&net5501_leds_dev);
+}
+
+struct soekris_board {
+	u16	offset;
+	char	*sig;
+	u8	len;
+	void	(*init)(void);
+};
+
+static struct soekris_board __initdata boards[] = {
+	{ 0xb7b, "net5501", 7, init_net5501 },	/* net5501 v1.33/1.33c */
+	{ 0xb1f, "net5501", 7, init_net5501 },	/* net5501 v1.32i */
+};
+
+static int __init soekris_init(void)
+{
+	int i;
+	unsigned char *rombase, *bios;
+
+	if (!is_geode() || geode_has_vsa2())
+		return 0;
+
+	rombase = ioremap(0xffff0000, 0xffff);
+	if (!rombase)
+		return 0;
+
+	bios = rombase + 0x20;	/* null terminated */
+
+	if (strncmp(bios, "comBIOS", 7))
+		goto unmap;
+
+	for (i = 0; i < ARRAY_SIZE(boards); i++) {
+		unsigned char *model = rombase + boards[i].offset;
+
+		if (strncmp(model, boards[i].sig, boards[i].len) == 0) {
+			printk(KERN_INFO "Soekris %s: %s\n", model, bios);
+
+			if (boards[i].init)
+				boards[i].init();
+			break;
+		}
+	}
+
+unmap:
+	iounmap(rombase);
+	return 0;
+}
+
+arch_initcall(soekris_init);
drivers/platform/x86/Kconfig +14 -0
@@ -395,4 +395,18 @@ config ACPI_TOSHIBA
 
 	  If you have a legacy free Toshiba laptop (such as the Libretto L1
 	  series), say Y.
+
+config SOEKRIS
+	bool "Soekris net5501 support"
+	depends on MGEODE_LX
+	select GPIOLIB
+	select GEODE_GPIO
+	select LEDS_CLASS
+	select LEDS_GPIO
+	select LEDS_TRIGGER_DEFAULT_ON
+	default n
+	help
+	  Add support for the Soekris net5501 board (detection, error led
+	  and GPIO).
+
 endif # X86_PLATFORM_DEVICES
drivers/platform/x86/Makefile +1 -0
@@ -18,3 +18,4 @@ obj-$(CONFIG_INTEL_MENLOW)	+= intel_menl
 obj-$(CONFIG_ACPI_WMI)		+= wmi.o
 obj-$(CONFIG_ACPI_ASUS)		+= asus_acpi.o
 obj-$(CONFIG_ACPI_TOSHIBA)	+= toshiba_acpi.o
+obj-$(CONFIG_SOEKRIS)		+= soekris.o
Signature · 6 lines
 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it
#1 lore raw

drivers/platform/x86/soekris.c line 68

Quoted 11 lines · On Thu, 5 Feb 2009 16:13:19 +0100 Alessandro Zummo…
drivers/platform/x86/soekris.c new file +11 -0
+static int __init soekris_init(void)
+{
+	int i;
+	unsigned char *rombase, *bios;
+
+	if (!is_geode() || geode_has_vsa2())
+		return 0;
+
+	rombase = ioremap(0xffff0000, 0xffff);
+	if (!rombase)
+		return 0;

Is it appropriate to silently "succeed" if the ioremap() failed?

Quoted 20 lines
drivers/platform/x86/soekris.c new file +20 -0
+	bios = rombase + 0x20;	/* null terminated */
+
+	if (strncmp(bios, "comBIOS", 7))
+		goto unmap;
+
+	for (i = 0; i < ARRAY_SIZE(boards); i++) {
+		unsigned char *model = rombase + boards[i].offset;
+
+		if (strncmp(model, boards[i].sig, boards[i].len) == 0) {
+			printk(KERN_INFO "Soekris %s: %s\n", model, bios);
+
+			if (boards[i].init)
+				boards[i].init();
+			break;
+		}
+	}
+
+unmap:
+	iounmap(rombase);
+	return 0;
#2 lore raw
Quoted 5 lines · On Fri, 6 Feb 2009 15:21:21 -0800 Andrew Morton <[email protected]>…

drivers/platform/x86/soekris.c line 68

Quoted 3 lines
drivers/platform/x86/soekris.c new file +3 -0
+	rombase = ioremap(0xffff0000, 0xffff);
+	if (!rombase)
+		return 0;  

Is it appropriate to silently "succeed" if the ioremap() failed?

maybe not.. I'll add a printk. ty.

Signature · 6 lines
 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it