Skip to contentSkip to conversation

powerpc/83xx: Fix missing #{address,size}-cells in mpc8313erdb.dts

PATCH Applied Anton Vorontsov 2 participants 2 messages Feb 5, 2009 – Feb 6, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 powerpc/83xx: Fix missing #{address,size}-cells in mpc8313erdb.dts

commit b31a1d8b41513b96e9c7ec2f68c5734cef0b26a4 ("gianfar: Convert gianfar to an of_platform_driver") introduced a child node for the ethernet@25000 controller, but no address and size cells specifiers were added, and that makes dtc unhappy:

DTC: dts->dtb on file "arch/powerpc/boot/dts/mpc8313erdb.dts"
Warning (reg_format): "reg" property in /soc8313@e0000000/ethernet@25000/mdio@25520 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) Warning (avoid_default_addr_size): Relying on default #address-cells value for /soc8313@e0000000/ethernet@25000/mdio@25520 Warning (avoid_default_addr_size): Relying on default #size-cells value for /soc8313@e0000000/ethernet@25000/mdio@25520

---
 arch/powerpc/boot/dts/mpc8313erdb.dts |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
arch/powerpc/boot/dts/mpc8313erdb.dts +2 -0
index 909a89c..3f84cd0 100644
@@ -219,6 +219,8 @@
 		};
 
 		enet1: ethernet@25000 {
+			#address-cells = <1>;
+			#size-cells = <1>;
 			cell-index = <1>;
 			device_type = "network";
 			model = "eTSEC";
Signature · 1 line
1.5.6.5
Applied
#1 lore raw

Re: [PATCH 1/2] powerpc/83xx: Fix missing #{address, size}-cells in mpc8313erdb.dts

Quoted 10 lines · Anton Vorontsov

commit b31a1d8b41513b96e9c7ec2f68c5734cef0b26a4 ("gianfar: Convert gianfar to an of_platform_driver") introduced a child node for the ethernet@25000 controller, but no address and size cells specifiers were added, and that makes dtc unhappy:

DTC: dts->dtb on file "arch/powerpc/boot/dts/mpc8313erdb.dts"
Warning (reg_format): "reg" property in /soc8313@e0000000/ethernet@25000/mdio@25520 has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) Warning (avoid_default_addr_size): Relying on default #address-cells value for /soc8313@e0000000/ethernet@25000/mdio@25520 Warning (avoid_default_addr_size): Relying on default #size-cells value for /soc8313@e0000000/ethernet@25000/mdio@25520

Quoted 4 lines

---
arch/powerpc/boot/dts/mpc8313erdb.dts | 2 ++

1 files changed, 2 insertions(+), 0 deletions(-)

applied to merge

- k