Skip to contentSkip to conversation

ppc4xx: Make PCIE support selectable

PATCH New Dirk Eibach 3 participants 3 messages Feb 3, 2009 – Feb 7, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ppc4xx: Make PCIE support selectable

On some platforms PCIE support is not required, but would be included because the cpu supports it. To reduce fooprint it is now configurable via CONFIG_PCI_DISABLE_PCIE.

---
 cpu/ppc4xx/4xx_pci.c  |    5 +++--
 cpu/ppc4xx/4xx_pcie.c |    2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)
cpu/ppc4xx/4xx_pci.c +3 -2
index e8871fc..2e75886 100644
@@ -588,8 +588,9 @@ void pci_init_board(void)
 	int busno;
 
 	busno = pci_440_init (&ppc440_hose);
-#if defined(CONFIG_440SPE) || \
-    defined(CONFIG_460EX) || defined(CONFIG_460GT)
+#if (defined(CONFIG_440SPE) || \
+    defined(CONFIG_460EX) || defined(CONFIG_460GT)) && \
+    !defined(CONFIG_PCI_DISABLE_PCIE)
 	pcie_setup_hoses(busno + 1);
 #endif
 }
cpu/ppc4xx/4xx_pcie.c +1 -1
index fd40d8a..58d96bb 100644
@@ -33,7 +33,7 @@
 
 #if (defined(CONFIG_440SPE) || defined(CONFIG_405EX) ||	\
     defined(CONFIG_460EX) || defined(CONFIG_460GT)) && \
-    defined(CONFIG_PCI)
+    defined(CONFIG_PCI) && !defined(CONFIG_PCI_DISABLE_PCIE)
 
 #include <asm/4xx_pcie.h>
 
Signature · 1 line
1.5.6.5
Applied
#1 lore raw

PATCH 1/1 ppc4xx: Make PCIE support selectable

Quoted 3 lines · Dirk Eibach

On some platforms PCIE support is not required, but would be included because the cpu supports it. To reduce fooprint it is now configurable via CONFIG_PCI_DISABLE_PCIE.

Applied to ppc4xx/master. Thanks.

BTW: Please CC me on 4xx related patches in the future. This makes it easier for me to spot those patches.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================

#2 lore raw

PATCH 1/1 ppc4xx: Make PCIE support selectable

In reply to Dirk Eibach

Dear Dirk Eibach,

Quoted 9 lines · In message <[email protected]> you wrote:

On some platforms PCIE support is not required, but would be included because the cpu supports it. To reduce fooprint it is now configurable via CONFIG_PCI_DISABLE_PCIE.

---
 cpu/ppc4xx/4xx_pci.c  |    5 +++--
 cpu/ppc4xx/4xx_pcie.c |    2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

Sorry, I'm too late with my review comment:

Please document the new CONFIG_PCI_DISABLE_PCIE in the README.

As Stefan has already pushed this into mainline, please send it as additional patch.

Thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Be careful what you wish for. You never know who will be listening.
                                      - Terry Pratchett, _Soul Music_