Skip to contentSkip to conversation

sm501fb: check fb_alloc_cmap return value and handle failure properly

PATCH In review Andres Salomon 2 participants 2 messages Feb 7, 2009 – Feb 9, 2009 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

PATCH 6/15 sm501fb: check fb_alloc_cmap return value and handle failure properly

---
 drivers/video/sm501fb.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
drivers/video/sm501fb.c +4 -1
index dcd9879..eb5d73a 100644
@@ -1525,7 +1525,10 @@ static int sm501fb_init_fb(struct fb_info *fb,
 	}
 
 	/* initialise and set the palette */
-	fb_alloc_cmap(&fb->cmap, NR_PALETTE, 0);
+	if (fb_alloc_cmap(&fb->cmap, NR_PALETTE, 0)) {
+		dev_err(info->dev, "failed to allocate cmap memory\n");
+		return -ENOMEM;
+	}
 	fb_set_cmap(&fb->cmap, fb);
 
 	ret = (fb->fbops->fb_check_var)(&fb->var, fb);
Signature · 9 lines
1.5.6.5


------------------------------------------------------------------------------
Create and Deploy Rich Internet Apps outside the browser with Adobe(R)AIR(TM)
software. With Adobe AIR, Ajax developers can use existing skills and code to
build responsive, highly engaging applications that combine the power of local
resources and data with the reach of the web. Download the Adobe AIR SDK and
Ajax docs to start building applications today-http://p.sf.net/sfu/adobe-com
Acked-by on v1 6/15
#1 lore raw
Quoted 3 lines · On Sat, 7 Feb 2009 12:14:48 -0500 Andres Salomon <[email protected]> wrote:

---

Quoted 22 lines
 drivers/video/sm501fb.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)
drivers/video/sm501fb.c +4 -1
index dcd9879..eb5d73a 100644
@@ -1525,7 +1525,10 @@ static int sm501fb_init_fb(struct fb_info *fb,
 	}
 
 	/* initialise and set the palette */
-	fb_alloc_cmap(&fb->cmap, NR_PALETTE, 0);
+	if (fb_alloc_cmap(&fb->cmap, NR_PALETTE, 0)) {
+		dev_err(info->dev, "failed to allocate cmap memory\n");
+		return -ENOMEM;
+	}
 	fb_set_cmap(&fb->cmap, fb);
 
 	ret = (fb->fbops->fb_check_var)(&fb->var, fb);
Signature · 1 line
1.5.6.5