Skip to contentSkip to conversation

x86: Don't pretend that non-framepointer stack traces are reliable

PATCH Applied Arjan van de Ven 2 participants 2 messages Feb 7, 2009 – Feb 9, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: Don't pretend that non-framepointer stack traces are reliable

Quoted 1 line

From f460ce92e09770691855b98a904556e92d39ead9 Mon Sep 17 00:00:00 2001

From: Arjan van de Ven <[email protected]>
Date: Sat, 7 Feb 2009 12:20:20 -0800
Subject: [PATCH] x86: Don't pretend that non-framepointer stack traces are reliable

without frame pointers enabled, the x86 stack traces should not pretend to be reliable; instead they should just be what they are:
unreliable.

The effect of this is that they have a ? printed in the stacktrace, to warn the reader that these entries are guesses rather than known based on more reliable information.

---
 arch/x86/kernel/dumpstack.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/x86/kernel/dumpstack.c +1 -1
index 077c9ea..4eda941 100644
@@ -100,7 +100,7 @@ print_context_stack(struct thread_info *tinfo,
 				frame = frame->next_frame;
 				bp = (unsigned long) frame;
 			} else {
-				ops->address(data, addr, bp == 0);
+				ops->address(data, addr, 0);
 			}
 			print_ftrace_graph_addr(addr, data, ops, tinfo, graph);
 		}
Signature · 8 lines
1.6.0.6



-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
Applied
#1 lore raw
Quoted 9 lines · Arjan van de Ven
Quoted 1 line

From f460ce92e09770691855b98a904556e92d39ead9 Mon Sep 17 00:00:00 2001

From: Arjan van de Ven <[email protected]>
Date: Sat, 7 Feb 2009 12:20:20 -0800
Subject: [PATCH] x86: Don't pretend that non-framepointer stack traces are reliable

without frame pointers enabled, the x86 stack traces should not pretend to be reliable; instead they should just be what they are:
unreliable.

Quoted 8 lines

The effect of this is that they have a ? printed in the stacktrace, to warn the reader that these entries are guesses rather than known based on more reliable information.

---
 arch/x86/kernel/dumpstack.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

applied to tip/x86/debug, thanks Arjan!

Ingo