Skip to contentSkip to conversation

generic ieee80211_sta_commit()?

DISCUSSION Alina Friedrichsen 2 participants 5 messages Feb 7, 2009 – Feb 8, 2009

lore
Share & tools
lore
#0 lore raw

Hello,

after a "ip link set wlan0 down" and than "ip link set wlan0 up" the wi= fi connection don't come up again. If you do a "iwconfig wlan0 channel = 4" beaconing in IBSS doesn't work anymore.

My thought to fix this is to add a generic ieee80211_sta_commit() funct= ion which is called after the most config changes (e.g. SSID, BSSID, ch= annel, interface up, ...), so that a clean rejoin is done by the functi= on and the driver hangs not in an undefined state. And I think it's mor= e elegant, because ieee80211_sta_set_bssid() then doesn't need to call = ieee80211_sta_set_ssid() anymore to do the rejoin.

What do you think about it? If agree I will implement it after Johannes=
IBSS changes are applied to avoid confusion.

Regards
Alina

--=20
Jetzt 1 Monat kostenlos! GMX FreeDSL - Telefonanschluss + DSL=20 f=FCr nur 17,95 Euro/mtl.!* http://dsl.gmx.de/?ac=3DOM.AD.PD003K11308T4=
569a
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#1 lore raw

Hi,

Quoted 5 lines · Alina Friedrichsen

Hello,

after a "ip link set wlan0 down" and than "ip link set wlan0 up" the wifi connection don't come up again. If you do a "iwconfig wlan0 channel 4" beaconing in IBSS doesn't work anymore.

What if you set the SSID again? I'd think that would help?

Quoted 7 lines

My thought to fix this is to add a generic ieee80211_sta_commit() function which is called after the most config changes (e.g. SSID, BSSID, channel, interface up, ...), so that a clean rejoin is done by the function and the driver hangs not in an undefined state. And I think it's more elegant, because ieee80211_sta_set_bssid() then doesn't need to call ieee80211_sta_set_ssid() anymore to do the rejoin.

That could make sense, not exactly sure at this point. I'm also still wondering about the other issue with turning _off_ IBSS, with essid off or so, see my other mail.

Quoted 2 lines

What do you think about it? If agree I will implement it after Johannes IBSS changes are applied to avoid confusion.

Sounds reasonable, if it fixes a bug. I'd have to see the patch, I guess. I'd like to also do assoc/IBSS stuff in cfg80211 at some point soonish.

johannes

#2 lore raw

Hello!

Quoted 1 line

What if you set the SSID again? I'd think that would help?

Yes it only works again if you do so.

Quoted 2 lines

That could make sense, not exactly sure at this point. I'm also still wondering about the other issue with turning _off_ IBSS, with essid o=

ff

Quoted 1 line

or so, see my other mail.

What mail do you mean?

Quoted 1 line

Sounds reasonable, if it fixes a bug.

I think it's a clean-up, too.

Quoted 3 lines

I'd have to see the patch, I
guess. I'd like to also do assoc/IBSS stuff in cfg80211 at some point soonish.

How do you mean it?

Regards
Alina

--=20
Jetzt 1 Monat kostenlos! GMX FreeDSL - Telefonanschluss + DSL=20 f=FCr nur 17,95 Euro/mtl.!* http://dsl.gmx.de/?ac=3DOM.AD.PD003K11308T4=
569a
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
Quoted 3 lines · Alina Friedrichsen
Quoted 1 line

What if you set the SSID again? I'd think that would help?

Yes it only works again if you do so.

Ok.

Quoted 5 lines
Quoted 3 lines

That could make sense, not exactly sure at this point. I'm also still wondering about the other issue with turning _off_ IBSS, with essid off or so, see my other mail.

What mail do you mean?

Subject: turning off IBSS (with wext)

Quoted 9 lines
Quoted 1 line

Sounds reasonable, if it fixes a bug.

I think it's a clean-up, too.

Quoted 3 lines

I'd have to see the patch, I
guess. I'd like to also do assoc/IBSS stuff in cfg80211 at some point soonish.

How do you mean it?

Well, I want to push configuration for bss/ibss into cfg80211.

johannes

#4 lore raw

Hello Johannes!

Quoted 1 line

Subject: turning off IBSS (with wext)

It looks to me that there and elsewhere is a need for more sanity check= s.

Quoted 1 line

Well, I want to push configuration for bss/ibss into cfg80211.

ACK

Regards
Alina

--=20
Jetzt 1 Monat kostenlos! GMX FreeDSL - Telefonanschluss + DSL=20 f=FCr nur 17,95 Euro/mtl.!* http://dsl.gmx.de/?ac=3DOM.AD.PD003K11308T4=
569a
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles= s" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html