Skip to contentSkip to conversation

crypto/des_generic: Ignore parity on triple keys

PATCH In review George Spelvin 1 participant 1 message Feb 8, 2009 Crypto API

lore
Share & tools
lore
#0 lore raw

PATCH 5/10 crypto/des_generic: Ignore parity on triple keys

des3_ede_setkey now ignores unused bits (often used for parity) when comparing keys to report weak combinations.

---
 crypto/des_generic.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
crypto/des_generic.c +2 -2
index 24d7f93..d9a81d8 100644
@@ -821,8 +821,8 @@ static int des3_ede_setkey(struct crypto_tfm *tfm, const u8 *key,
 	u32 *expkey = dctx->expkey;
 	u32 *flags = &tfm->crt_flags;
 
-	if (unlikely(!((K[0] ^ K[2]) | (K[1] ^ K[3])) ||
-		     !((K[2] ^ K[4]) | (K[3] ^ K[5]))) &&
+	if (unlikely(!(((K[0] ^ K[2]) | (K[1] ^ K[3])) & 0xfefefefe) ||
+		     !(((K[2] ^ K[4]) | (K[3] ^ K[5])) & 0xfefefefe)) &&
 		     (*flags & CRYPTO_TFM_REQ_WEAK_KEY))
 	{
 		*flags |= CRYPTO_TFM_RES_WEAK_KEY;
Signature · 1 line
1.6.0.6