Skip to contentSkip to conversation

USB keyboard

PATCH In review Robert Millan 2 participants 6 messages Feb 8, 2009 – Feb 21, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 USB keyboard

Hi,

This patch implements USB keyboard support. It is based on work by Marco Gerards, to which I made some adjustments, synced with trunk, and fixed a pair of bugs.

Signature · 5 lines
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."

2009-02-08 Robert Millan <[email protected]>

Implement USB keyboard support (based on patch by Marco Gerards)

* conf/i386-pc.rmk (pkglib_MODULES): Add `usb_keyboard.mod'. (usb_keyboard_mod_SOURCES, usb_keyboard_mod_CFLAGS) (usb_keyboard_mod_LDFLAGS): New variables.

* term/usb_keyboard.c: New file.

i386-pc.rmk +6 -1
Index: conf/i386-pc.rmk
===================================================================
@@ -172,7 +172,7 @@ pkglib_MODULES = biosdisk.mod _chain.mod
 	ata.mod vga.mod memdisk.mod pci.mod lspci.mod \
 	aout.mod _bsd.mod bsd.mod pxe.mod pxecmd.mod datetime.mod date.mod \
 	datehook.mod lsmmap.mod \
-	usb.mod uhci.mod ohci.mod usbtest.mod usbms.mod
+	usb.mod uhci.mod ohci.mod usbtest.mod usbms.mod usb_keyboard.mod
 
 # For biosdisk.mod.
 biosdisk_mod_SOURCES = disk/i386/pc/biosdisk.c
@@ -333,6 +333,11 @@ usbms_mod_SOURCES = disk/usbms.c
 usbms_mod_CFLAGS = $(COMMON_CFLAGS)
 usbms_mod_LDFLAGS = $(COMMON_LDFLAGS)
 
+# For usb_keyboard.mod
+usb_keyboard_mod_SOURCES = term/usb_keyboard.c
+usb_keyboard_mod_CFLAGS = $(COMMON_CFLAGS)
+usb_keyboard_mod_LDFLAGS = $(COMMON_LDFLAGS)
+
 # For pxe.mod
 pxe_mod_SOURCES = fs/i386/pc/pxe.c
 pxe_mod_CFLAGS = $(COMMON_CFLAGS)
usb_keyboard.c +257 -0

257 lines not on this page · raw message

#1 lore raw

didn't this work already? or was this only cause of efi? just while testing the input issue on my mac i attached a usb keyboard too, and that worked.

Quoted 20 lines · Robert Millan

Hi,

This patch implements USB keyboard support. It is based on work by Marco Gerards, to which I made some adjustments, synced with trunk, and fixed a pair of bugs.

--
Robert Millan

The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."

_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel

#2 lore raw
Quoted 2 lines · On Sun, Feb 08, 2009 at 09:04:56PM +0100, step21 wrote:

didn't this work already? or was this only cause of efi? just while testing the input issue on my mac i attached a usb keyboard too, and that worked.

When the firmware (BIOS/EFI/OFW) supports USB and GRUB uses its callbacks, then USB keyboards can work. Using the driver helps when the firmware doesn't support USB, or when its USB support is broken in some way.

Signature · 5 lines
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."
#3 lore raw

Thanks for clarifying this.

Quoted 21 lines · Robert Millan
Quoted 2 lines · On Sun, Feb 08, 2009 at 09:04:56PM +0100, step21 wrote:

didn't this work already? or was this only cause of efi? just while testing the input issue on my mac i attached a usb keyboard too, and that worked.

When the firmware (BIOS/EFI/OFW) supports USB and GRUB uses its callbacks, then USB keyboards can work.  Using the driver helps when the firmware doesn't support USB, or when its USB support is broken in some way.

--
Robert Millan

 The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."

_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel

#4 lore raw

O.k., finally got everything patched and booted from it. What I did: Just to be sure set root with "root=(hd0,2)" then set debug=usbkeyb or usb_keyboard (tried both)
then insmod uhci;insmod usb_keyboard; terminal_input usb_keyboard I get no new promp and it "hangs".
To get debug output, do I have to include a #define DEBUG_USB_KEYBOARD or something in the src too in addition to debug=usbkeyb
?

Quoted 27 lines · On Mon, Feb 9, 2009 at 3:27 PM, step21 <[email protected]> wrote:

Thanks for clarifying this.

Quoted 21 lines · Robert Millan
Quoted 2 lines · On Sun, Feb 08, 2009 at 09:04:56PM +0100, step21 wrote:

didn't this work already? or was this only cause of efi? just while testing the input issue on my mac i attached a usb keyboard too, and that worked.

When the firmware (BIOS/EFI/OFW) supports USB and GRUB uses its callbacks, then USB keyboards can work.  Using the driver helps when the firmware doesn't support USB, or when its USB support is broken in some way.

--
Robert Millan

 The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."

_______________________________________________
Grub-devel mailing list
[email protected]
http://lists.gnu.org/mailman/listinfo/grub-devel

#5 lore raw
In reply to Robert Millan
Quoted 6 lines · Robert Millan

Hi,

This patch implements USB keyboard support. It is based on work by Marco Gerards, to which I made some adjustments, synced with trunk, and fixed a pair of bugs.

Committed.

Signature · 5 lines
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."