ppc: Fix roll over bug in flush_cache()
PATCH 1/1 ppc: Fix roll over bug in flush_cache()
If we call flush_cache(0xfffff000, 0x1000) it would never terminate the loop since end = 0xffffffff and we'd roll over our counter from 0xfffffe0 to 0 (assuming a 32-byte cache line)
Signed-off-by Kumar Gala <[email protected]>
--- lib_ppc/cache.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)
lib_ppc/cache.c +4 -2
@@ -33,14 +33,16 @@ void flush_cache(ulong start_addr, ulong size) start = start_addr & ~(CONFIG_SYS_CACHELINE_SIZE -1 ); end = start_addr + size -1 ; -for (addr = start; addr <= end; addr +=CONFIG_SYS_CACHELINE_SIZE ) { +for (addr = start; (addr <= end) && (addr >= start); + addr +=CONFIG_SYS_CACHELINE_SIZE ) { asmvolatile ("dcbst 0,%0" : :"r" (addr) :"memory" );WATCHDOG_RESET (); }/* wait for all dcbst to complete on bus */ asmvolatile ("sync" : : :"memory" ); -for (addr = start; addr <= end; addr +=CONFIG_SYS_CACHELINE_SIZE ) { +for (addr = start; (addr <= end) && (addr >= start); + addr +=CONFIG_SYS_CACHELINE_SIZE ) { asmvolatile ("icbi 0,%0" : :"r" (addr) :"memory" );WATCHDOG_RESET (); }
Signature · 1 line
1.5.6.6
Wolfgang Denk
AppliedPATCH 1/1 ppc: Fix roll over bug in flush_cache()
Dear Kumar Gala,
Quoted 8 lines · In message <[email protected]> you…
If we call
flush_cache(0xfffff000, 0x1000)it would never terminate the loop since end =0xffffffffand we'd roll over our counter from0xfffffe0to 0 (assuming a 32-byte cache line)Signed-off-by Kumar Gala <[email protected]>--- lib_ppc/cache.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Probably the best operating system in the world is the [operating
system] made for the PDP-11 by Bell Laboratories."
- Ted Nelson, October 1977