Skip to contentSkip to conversation

: net: Kill skbuff macros from the stone ages.

PATCH In review David Miller 2 participants 3 messages Feb 10, 2009

Subsystems (2)
lore
Share & tools
lore

David Miller

author maintainer
#0 lore raw

PATCH 1/1 : net: Kill skbuff macros from the stone ages.

I've commited the following to net-next-2.6

net: Kill skbuff macros from the stone ages.

This kills of HAVE_ALLOC_SKB and HAVE_ALIGNABLE_SKB.

Nothing in-tree uses them and nothing in-tree has used them since 2.0.x times.

---
 include/linux/skbuff.h |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
include/linux/skbuff.h +0 -3
index 5eba400..9247008 100644
@@ -29,9 +29,6 @@
 #include <linux/dmaengine.h>
 #include <linux/hrtimer.h>
 
-#define HAVE_ALLOC_SKB		/* For the drivers to know */
-#define HAVE_ALIGNABLE_SKB	/* Ditto 8)		   */
-
 /* Don't change this without changing skb_csum_unnecessary! */
 #define CHECKSUM_NONE 0
 #define CHECKSUM_UNNECESSARY 1
Signature · 1 line
1.6.1.2.253.ga34a
#1 lore raw

include/linux/skbuff.h line 33

Quoted 2 lines · David Miller
include/linux/skbuff.h +0 -2
-#define HAVE_ALLOC_SKB		/* For the drivers to know */
-#define HAVE_ALIGNABLE_SKB	/* Ditto 8)		   */

BTW, after net_device_ops conversion will be finished, netdev HAVE_* macros should be deleted as well.

author maintainer
#2 lore raw

From: Alexey Dobriyan <[email protected]>
Date: Tue, 10 Feb 2009 11:50:24 +0300

Quoted 6 lines · David Miller

include/linux/skbuff.h line 33

Quoted 2 lines
include/linux/skbuff.h +0 -2
-#define HAVE_ALLOC_SKB		/* For the drivers to know */
-#define HAVE_ALIGNABLE_SKB	/* Ditto 8)		   */

BTW, after net_device_ops conversion will be finished, netdev HAVE_* macros should be deleted as well.

I agree.

To be honest the whole HAVE_* was a really dumb idea. Althought I suppose at the time it might have made some kind of sense.