4 bytes kernel memory disclosure in SO_BSDCOMPAT gsopt
Subsystems (3)
PATCH 1/1 4 bytes kernel memory disclosure in SO_BSDCOMPAT gsopt
Hello lkml,
In function sock_getsockopt() located in net/core/sock.c, optval v.val is not correctly initialized and directly returned in userland in case we have SO_BSDCOMPAT option set.
This dummy code should trigger the bug:
int main(void)
{
unsigned char buf[4] = { 0, 0, 0, 0 };
int len;
int sock;
sock = socket(33, 2, 2);
getsockopt(sock, 1, SO_BSDCOMPAT, &buf, &len);
printf("%x%x%x%x\n", buf[0], buf[1], buf[2], buf[3]);
close(sock);
}Here is a patch that fix this bug by initalizing v.val just after its declaration.
Bests,
Signature · 2 lines
Clément LECIGNE, :%s/coin/& coin/g
net/core/sock.c 2008-11-26 14:37:45.000000000 -0800 renamed from net/core/sock.c 2008-11-26 14:37:17.000000000 -0800 +2 -0
@@ -695,6 +695,8 @@ if (len < 0) return -EINVAL; + v.val = 0; + switch(optname) { case SO_DEBUG: v.val = sock_flag(sk, SOCK_DBG);
David Miller
maintainerFrom: Clément LECIGNE <[email protected]>
Date: Wed, 11 Feb 2009 15:56:56 +0100
Quoted 5 lines
Hello lkml,
In function
sock_getsockopt()located innet/core/sock.c, optval v.val is not correctly initialized and directly returned in userland in case we haveSO_BSDCOMPAToption set.This dummy code should trigger the bug:
Some problems with your patch:
1) Your patch doesn't apply properly. It has been corrupted.
Somehow, even though you used an attachment, tab characters were transformed into spaces.
2) Networking patches should be sent with at least [email protected] CC:'d so that your patch gets properly traced at http://patchwork.ozlabs.org/project/netdev/list/
3) You need to provide a proper "Signed-off-by:" line with your patch description. See linux/Documentation/SubmittingPatches for details.
Please fix these issues up and resubmit your patch.
Thank you.