atmel_serial might lose modem status change
Subsystems (2)
PATCH 1/2 atmel_serial might lose modem status change
From: Atsushi Nemoto <[email protected]>
I found a problem of handling of modem status of atmel_serial driver.
With the commit 1ecc26 ("atmel_serial: split the interrupt handler"), handling of modem status signal was splitted into two parts. The atmel_tasklet_func() compares new status with irq_status_prev, but irq_status_prev is not correct if signal status was changed while the port is closed.
Here is a sequence to cause problem:
1. Remote side sets CTS (and DSR).
2. Local side close the port.
3. Local side clears RTS and DTR.
4. Remote side clears CTS and DSR.
5. Local side reopen the port. hw_stopped becomes 1.
6. Local side sets RTS and DTR.
7. Remote side sets CTS and DSR.
Then CTS change interrupt can be received, but since CTS bit in irq_status_prev and new status is same, uart_handle_cts_change() will not be called (so hw_stopped will not be cleared, i.e. cannot send any data).
I suppose irq_status_prev should be initialized at somewhere in open sequence.
Itai Levi pointed out that we need to initialize atmel_port->irq_status as well here. His analysis is as follows:
Quoted 22 lines
Regarding the second part of the patch (which resets
irq_status_prev), it turns out that both versions of the patch (mine and Atsushi's) still leave enough room for faulty behavior when opening the port.This is because we are not resetting both
irq_status_prevandirq_statusinatmel_startup()to CSR, which leads faulty behavior in the following sequences:First case:
1. closing the port while CTS line = 1 (TX not allowed)
2. setting CTS line = 0 (TX allowed)
3. opening the port
4. transmitting one char
5. Cannot transmit more chars, although CTS line is 0Second case:
1. closing the port while CTS line = 0 (TX allowed)
2. setting CTS line = 1 (TX not allowed)
3. opening the port
4. receiving some chars
5. Now we can transmit, although CTS line is 1
Quoted 7 lines
This reason for this is that the tasklet is scheduled as a result of TX or RX interrupts (not a status change!), in steps 4 above. Inside the tasklet, the
atmel_port->irq_status(which holds the value from the previous session) is compared toatmel_port->irq_status_prev. Hence, a status-change of the CTS line is faultily detected.Both cases were verified on 9260 hardware.
---
drivers/serial/atmel_serial.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/serial/atmel_serial.c renamed from drivers/serial/atmel_serial.c~atmel_serial-might-lose-modem-status-change +4 -0
@@ -877,6 +877,10 @@ static int atmel_startup(struct uart_por } } +/* Save current CSR for comparison in atmel_tasklet_func() */ + atmel_port->irq_status_prev =UART_GET_CSR (port); + atmel_port->irq_status = atmel_port->irq_status_prev; +/* * Finally, enable the serial port */
_
Quoted 9 lines · [email protected] wrote:
From: Atsushi Nemoto <[email protected]>
I found a problem of handling of modem status of
atmel_serialdriver.With the commit 1ecc26 ("
atmel_serial: split the interrupt handler"), handling of modem status signal was splitted into two parts. Theatmel_tasklet_func()compares new status withirq_status_prev, butirq_status_previs not correct if signal status was changed while the port is closed.
I think this is 2.6.29 material. It fixes a real bug.
Haavard