Skip to contentSkip to conversation

sfc: modify allocation error message

PATCH Applied [email protected] 2 participants 2 messages Feb 11, 2009 – Feb 13, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 sfc: modify allocation error message

From: Mike Travis <[email protected]>

Change error message when alloc_cpumask_var fails.

---

 drivers/net/sfc/efx.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/sfc/efx.c renamed from drivers/net/sfc/efx.c~sfc-modify-allocation-error-message +2 -2
diff -puN drivers/net/sfc/efx.c~sfc-modify-allocation-error-message drivers/net/sfc/efx.c
@@ -857,9 +857,9 @@ static int efx_wanted_rx_queues(void)
 	int count;
 	int cpu;
 
-	if (!alloc_cpumask_var(&core_mask, GFP_KERNEL)) {
+	if (unlikely(!alloc_cpumask_var(&core_mask, GFP_KERNEL))) {
 		printk(KERN_WARNING
-		       "efx.c: allocation failure, irq balancing hobbled\n");
+		       "sfc: RSS disabled due to allocation failure\n");
 		return 1;
 	}
 

_

maintainer Acked-by on v1 1/2
#1 lore raw

From: [email protected]
Date: Wed, 11 Feb 2009 13:27:34 -0800

Quoted 5 lines

Change error message when alloc_cpumask_var fails.

This has to go into whatever tree adds the alloc_cpumask_var() call to this function, and that isn't one of the networking trees. :-)

Anyways, for the record I'm fine with this change: