Skip to contentSkip to conversation

test 199: test features2 fixup for the regular case, too

PATCH In review Christoph Hellwig 2 participants 2 messages Feb 14, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 test 199: test features2 fixup for the regular case, too

Eric Sandeen noted that we should not only test the mount ro first, then remount rw case in 199 but also the regular mount rw case.

199 +16 -2
Index: xfstests-dev/199
===================================================================
@@ -1,8 +1,10 @@
 #! /bin/sh
 # FS QA Test No. 199
 #
-# Check that a filesystem first mounted read-only and then remounted
-# performs the features2 fixup properly.
+# Check that the features2 localtion fixups work correctly.  We check both
+# a regualar read-write mount of a filesystem and the case where the
+# filesystem is first mounted read-only and then later remounted read-write,
+# which is the usual case for the root filesystem.
 #
 #-----------------------------------------------------------------------
 # Copyright (c) 2008 Christoph Hellwig.
@@ -51,8 +53,20 @@
 echo "Clearing features2:"
 xfs_db -x $SCRATCH_DEV -c 'sb' -c 'write features2 0'
 
+_scratch_mount
+umount $SCRATCH_MNT
+echo "Features 2 after mount rw:"
+xfs_db -x $SCRATCH_DEV -c 'sb' -c 'print features2'
+
+#
+# Clear the normal flags again for the second rount.
+#
+echo "Clearing features2:"
+xfs_db -x $SCRATCH_DEV -c 'sb' -c 'write features2 0'
+
 #
 # And print the flags after a mount ro and remount rw
+#
 _scratch_mount -o ro
 _scratch_mount -o remount,rw
 umount $SCRATCH_MNT
199.out +4 -0
Index: xfstests-dev/199.out
===================================================================
@@ -4,6 +4,10 @@
 bad_features2 = 0x8
 Clearing features2:
 features2 = 0
+Features 2 after mount rw:
+features2 = 0x8
+Clearing features2:
+features2 = 0
 Features 2 after mount ro and remount rw:
 features2 = 0x8
 *** done

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

#1 lore raw
Quoted 11 lines · Christoph Hellwig

Eric Sandeen noted that we should not only test the mount ro first, then remount rw case in 199 but also the regular mount rw case.

Index: xfstests-dev/199
===================================================================

199 line 4

Quoted 6 lines
199 +1 -2
@@ -1,8 +1,10 @@
 #! /bin/sh
 # FS QA Test No. 199
 #
-# Check that a filesystem first mounted read-only and then remounted
-# performs the features2 fixup properly.
+# Check that the features2 localtion fixups work correctly.  We check both
                                 ^^^ typo (location)

199 line 5

Quoted 1 line
199 +1 -0
+# a regualar read-write mount of a filesystem and the case where the
         ^^^ typo (regular)

With those fixes, ACK, thanks!

-Eric

Quoted 42 lines
199 +14 -0
+# filesystem is first mounted read-only and then later remounted read-write,
+# which is the usual case for the root filesystem.
 #
 #-----------------------------------------------------------------------
 # Copyright (c) 2008 Christoph Hellwig.
@@ -51,8 +53,20 @@
 echo "Clearing features2:"
 xfs_db -x $SCRATCH_DEV -c 'sb' -c 'write features2 0'
 
+_scratch_mount
+umount $SCRATCH_MNT
+echo "Features 2 after mount rw:"
+xfs_db -x $SCRATCH_DEV -c 'sb' -c 'print features2'
+
+#
+# Clear the normal flags again for the second rount.
+#
+echo "Clearing features2:"
+xfs_db -x $SCRATCH_DEV -c 'sb' -c 'write features2 0'
+
 #
 # And print the flags after a mount ro and remount rw
+#
 _scratch_mount -o ro
 _scratch_mount -o remount,rw
 umount $SCRATCH_MNT

Index: xfstests-dev/199.out
===================================================================

199.out +4 -0
@@ -4,6 +4,10 @@
 bad_features2 = 0x8
 Clearing features2:
 features2 = 0
+Features 2 after mount rw:
+features2 = 0x8
+Clearing features2:
+features2 = 0
 Features 2 after mount ro and remount rw:
 features2 = 0x8
 *** done
Quoted 5 lines

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs